[Bug 11802] New: Homeworld: sound broken usually [regression]

http://bugs.winehq.org/show_bug.cgi?id=11802

Summary: Homeworld: sound broken usually [regression]
           Product: Wine
           Version: 0.9.56.
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Usually when starting up Homeworld v1.05, the sound will not work, but not
always. Works fine under Wine 0.9.53.

When it doesn't work it's broken from the very beginning. At the Sierra intro
movie, it will not have any sound. Then there will not be any sound throughout
the running of the program. There are no other noticeable issues during play.
But also when this happens upon a normal exit of the app via its menu system it
will normally (always?) hang in the console window after it closes its
application window. In the few cases when there is sound upon startup exiting
normally does not hang.

Choosing different audio drivers in winecfg seem to have any affect.

Running 'wineboot -s' or 'wineserver -k' doesn't seem to help either.

For a while it seemed like switching the default settings Windows Version in
winecfg back between 'Windows XP' and 'Windows 2000' would help, but usually
not. Probably just a coincidence though, as sometimes it will run fine anyway
and it certainly doesn't work every time.

Tested on the latest git version (wine-0.9.56-264-g848383a), broken there as
well as the release version (from gentoo distro wine-0.9.56).

[Bug 11802] Homeworld: sound broken usually [regression]

http://bugs.winehq.org/show_bug.cgi?id=11802

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #1 from Lei Zhang   2008-03-01 16:02:00 ---
Can you do a regression test?

http://wiki.winehq.org/RegressionTesting

The game crashed on me with Wine 0.9.56. Did you have to do anything special to
get it to run?

[Bug 11802] Homeworld: sound broken usually [regression]

http://bugs.winehq.org/show_bug.cgi?id=11802

--- Comment #2 from Mike Nelson   2008-03-02 11:08:24 ---
(In reply to comment #1)
> Can you do a regression test?
>
> http://wiki.winehq.org/RegressionTesting
>
> The game crashed on me with Wine 0.9.56. Did you have to do anything special to
> get it to run?

I didn't have to do anything special to get it to run. But I did see it crash
at the beginning sometimes. Usually if I just 'wineserver -k' and then retry it
it will work fine. Sometimes it take a few tries of this before it works. No
idea why.

These are the steps I was using generally,

- $ rm ~/.wine -rf
- $ wincfg (leave everything at default; just click ok) (sometimes i was trying
'Windows XP' configuration.)
- $ mount /mnt/cdrom
- $ cd /mnt/cdrom
- $ wine HWSetup.exe (to install)
- $ cd ~
- $ wine ~/Homeworld105Patch.exe
- $ wincfg (set D: drive to /mnt/cdrom)
- $ cd ~/.wine/drive_c/Sierra/Homeworld
- $ wine homeworld.exe /window /1280 (set renderer to opengl; exit then rerun
with same parameters)

I'll try and run the regression with bisect like you suggested and see what I
come up with.

[Bug 11802] Homeworld: sound broken usually [regression]

http://bugs.winehq.org/show_bug.cgi?id=11802

Mike Nelson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #3 from Mike Nelson   2008-03-02 17:35:04 ---
Here are the results of the regression test below. I'm not 100% on this, as
it's not 100% reproducible.

Starting up the game 4 times with sound and no failures (no runs without sound)
I'd count as a good build otherwise it was counted as a bad build. Times when
the game just crashed outright at the beginning I would discount as a bad test
and just rerun until I got a good test. This intermittent crashing on startup
issue might be another bug to file.

c19af910ebafa9b1928b0f67bee68f6b0b237e8e is first bad commit
commit c19af910ebafa9b1928b0f67bee68f6b0b237e8e
Author: Alexandre Julliard 
Date:   Thu Jan 17 19:53:59 2008 +0100

winex11.drv: Don't create a win_data structure for the desktop window,
except in the process that owns it.

Handle desktop size changes by sending a message to the desktop owner.

:040000 040000 b7c030353fe92121bb999481724a3689429b2e8a
80fd2c5f4ace2707abb01648bd61663a6c9d7626 M      dlls

[Bug 11802] Homeworld: sound broken usually [regression]

http://bugs.winehq.org/show_bug.cgi?id=11802

Timo-Heikki Mäkelä  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Timo-Heikki Mäkelä   2008-03-02 18:39:13 ---
On basis of that bisect it seems winex11.drv would be the correct component.

There will be need for more info on what is happening. Could you run this in
terminal and attach the log (as an attachment), please?

[Bug 11802] Homeworld: sound broken usually [regression]

http://bugs.winehq.org/show_bug.cgi?id=11802

--- Comment #5 from Austin English   2008-03-02 19:02:07 ---
(In reply to comment #3)
> Here are the results of the regression test below. I'm not 100% on this, as
> it's not 100% reproducible.

If you aren't sure, then try reverting the patch (or compile right before this
patch if it won't compile cleanly).

$ git revert c19af910ebafa9b1928b0f67bee68f6b0b237e8e
$ ./configure --verbose && make clean && make depend && make

[Bug 11802] Homeworld: sound broken usually [regression]

http://bugs.winehq.org/show_bug.cgi?id=11802

--- Comment #6 from Lei Zhang   2008-03-03 00:11:39 ---
(In reply to comment #2)
> - $ wine homeworld.exe /window /1280 (set renderer to opengl; exit then rerun
>
> with same parameters)

Ah, you did do something special there...

Thanks for doing the regression test. I'll double check the results tomorrow.

[Bug 11802] Homeworld: sound broken usually [regression]

http://bugs.winehq.org/show_bug.cgi?id=11802

--- Comment #7 from Mike Nelson   2008-03-03 21:20:09 ---
(In reply to comment #5)
> (In reply to comment #3)
> > Here are the results of the regression test below. I'm not 100% on this, as
> > it's not 100% reproducible.
>
> If you aren't sure, then try reverting the patch (or compile right before this
> patch if it won't compile cleanly).
>
> $ git revert c19af910ebafa9b1928b0f67bee68f6b0b237e8e
> $ ./configure --verbose && make clean && make depend && make

git revert couldn't cleanly un-merge that patch from HEAD and the changes are
non-trivial, at least to me. But now it looks like that is probably not the
problem patch anyway.

I tested before and after this supposedly bad check-in and I was able to repro
the issue on both "good" and "bad" versions. After another regression from that
"good" revision back to wine-0.9.53 I found that I could indeed repro it on
wine-0.9.53 as well (after many many runs). It just seems to happen a lot more
often on the more current versions. I'm a bit at a loss now. This may not be a
regression issue after all. Seems like some sort of timing issue during
startup.

[Bug 11802] Homeworld: sound broken usually [regression]

http://bugs.winehq.org/show_bug.cgi?id=11802

--- Comment #8 from Mike Nelson   2008-03-03 21:28:05 ---
Also when I was re-testing I was using the following to test. In order to use a
more normal install.

$ rm /home/mike/.wine/ -rf && ./wine /mnt/cdrom/HWSetup.EXE &&
./programs/winecfg/winecfg && ./wine
/home/mike/stuff/games/Homeworld105Patch.exe

(Installing with default options. Using winecfg to set D: drive to /mnt/cdrom,
and selecting Yes to running the game after the patch was installed.)

Rerunning with the following after crashes or re-running a good run to verify.

$ cd /home/mike/.wine/drive_c/Sierra/Homeworld && ~/projects/wine/wine
homeworld.exe ; cd -

[Bug 11802] Homeworld: sound broken usually [regression]

http://bugs.winehq.org/show_bug.cgi?id=11802

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |

--- Comment #9 from Lei Zhang   2008-03-03 22:55:03 ---
Ah, it didn't work on my desktop (no cdrom drive) because I was using an ISO
file.

On my T43p laptop, with Ubuntu, Wine 0.9.56, and the actual CD, Homeworld 1.05
worked just fine. The sound played and 3d graphics worked in OpenGL mode. (ah,
good memories...) Since I don't see the bug, I guess I can't help you with the
regression test - which looks incorrect as others have pointed out. (removing
Alexandre)

Just a thought - perhaps this is happening because some other software is
grabbing the sound card? Many sound cards don't have a hardware mixer, so only
one program can use it at any time.

[Bug 11802] Homeworld: sound broken usually [regression]

http://bugs.winehq.org/show_bug.cgi?id=11802

--- Comment #10 from Lei Zhang   2008-03-04 11:27:34 ---
BTW, do you have the same issue with the demo? [1] If so, others can probably
test it out and see whether they can reproduce the problem.

[1] http://www.fileshack.com/file.x/569/Homeworld+Demo

[Bug 11802] Homeworld: sound broken usually [regression]

http://bugs.winehq.org/show_bug.cgi?id=11802

--- Comment #11 from Mike Nelson   2008-03-05 21:56:45 ---
(In reply to comment #10)
> BTW, do you have the same issue with the demo? [1] If so, others can probably
> test it out and see whether they can reproduce the problem.
>
> [1] http://www.fileshack.com/file.x/569/Homeworld+Demo

I could repro this with the demo in 0.9.53 (very less often) but not in 0.9.56.

[Bug 11802] Homeworld: sound broken usually

http://bugs.winehq.org/show_bug.cgi?id=11802

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Homeworld: sound broken     |Homeworld: sound broken
                   |usually [regression]        |usually

--- Comment #12 from Austin English   2008-06-04 11:20:59 ---
Is this still an issue in 1.0-rc3 or newer wine?

[Bug 11802] Homeworld: sound broken usually

http://bugs.winehq.org/show_bug.cgi?id=11802

--- Comment #13 from Mike Nelson   2008-06-08 12:27:22 ---
I just tested on 1.0-rc4 and I still get the issue intermittently although it
seems like it works more often than before. It worked the first few times that
I tried it. Then it works less and less often. Still crashes sometimes at
startup as well but that is a different issue.

[Bug 11802] Homeworld: sound broken usually

http://bugs.winehq.org/show_bug.cgi?id=11802

--- Comment #14 from Austin English   2008-12-08 04:15:48 ---
Is this still an issue in current (1.1.10 or newer) wine?

[Bug 11802] Homeworld: sound broken usually

http://bugs.winehq.org/show_bug.cgi?id=11802

--- Comment #15 from Mike Nelson   2008-12-08 22:13:50 ---
(In reply to comment #14)
> Is this still an issue in current (1.1.10 or newer) wine?

Still an issue in wine-1.1.10. Just tested it. Still happens sometimes, but
works more often than not.

[Bug 11802] Homeworld: sound broken usually

http://bugs.winehq.org/show_bug.cgi?id=11802

--- Comment #16 from Austin English   2009-06-08 11:52:10 ---
Is this still an issue in current (1.1.23 or newer) wine?

[Bug 11802] Homeworld: sound broken usually

http://bugs.winehq.org/show_bug.cgi?id=11802

--- Comment #17 from Mike Nelson   2009-06-13 12:39:16 ---
(In reply to comment #16)
> Is this still an issue in current (1.1.23 or newer) wine?

Still get this same behaviour in wine-1.1.23 and current git
(45629dc050f46988c23ded35ad18bbd8c63e4e65)

[Bug 11802] Homeworld: sound broken usually

http://bugs.winehq.org/show_bug.cgi?id=11802

--- Comment #18 from Austin English   2010-01-04 12:16:55 ---
This is your friendly reminder that there has been no bug activity for 6
months. Is this still an issue in current (1.1.35 or newer) wine?

[Bug 11802] Homeworld: sound broken usually

http://bugs.winehq.org/show_bug.cgi?id=11802

--- Comment #19 from Mike Nelson   2010-01-05 08:27:01 ---
(In reply to comment #18)
> This is your friendly reminder that there has been no bug activity for 6
> months. Is this still an issue in current (1.1.35 or newer) wine?

Thanks, I'll give it a test in a few days.

[Bug 11802] Homeworld: sound broken usually

http://bugs.winehq.org/show_bug.cgi?id=11802

--- Comment #20 from Mike Nelson   2010-01-15 18:06:23 ---
(In reply to comment #18)
> This is your friendly reminder that there has been no bug activity for 6
> months. Is this still an issue in current (1.1.35 or newer) wine?

Still happens on 1.1.36. I could only get it to run under the Windows 2000
configuration but it had no sound.

[Bug 11802] Homeworld: sound broken usually

http://bugs.winehq.org/show_bug.cgi?id=11802

Xavier Vachon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #21 from Xavier Vachon   2010-07-19 13:21:16 ---
In current git (wine 1.2), I am unable to reproduce this bug. I started the
game 5 times, each time I have sound for the intro videos, menus and game.
Sound is set to ALSA and Windows to XP, I use Homeworld 1.05 with Gentoo Linux
X64

[Bug 11802] Homeworld: sound broken usually

http://bugs.winehq.org/show_bug.cgi?id=11802

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #22 from Austin English   2010-07-19 14:38:57 ---
Reported fixed.

[Bug 11802] Homeworld: sound broken usually

http://bugs.winehq.org/show_bug.cgi?id=11802

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #23 from Alexandre Julliard   2010-07-30 12:55:00 ---
Closing bugs fixed in 1.3.0.