https://bugs.winehq.org/show_bug.cgi?id=49173
Bug ID: 49173 Summary: widl generates invalid code for Gecko's ISimpleDOM.idl Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: rpc Assignee: wine-bugs@winehq.org Reporter: emilio@crisal.io Distribution: ---
Compiling the following IDL file t.idl:
import "objidl.idl"; import "oaidl.idl";
[object, uuid(1814ceeb-49e2-407f-af99-fa755a7d2607)] interface ISimpleDOMNode : IUnknown { [propget, local] HRESULT localInterface([out][retval] void **localInterface); [propget, call_as(get_localInterface)] HRESULT remoteLocalInterface([out][retval] IUnknown **localInterface); }
With:
$ ./tools/widl/widl -m 64 --win64 -robust -Oicf t.idl -I include
Generates the following bit:
struct _PARAM_STRUCT { ISimpleDOMNode *This; IUnknown **localInterface; HRESULT _RetVal DECLSPEC_ALIGN(8); } *pParamStruct = (struct _PARAM_STRUCT *)pStubMsg->StackTop;
Which fails to compile like:
3:11.30 ISimpleDOM_p.c(65,24): error: expected ';' at end of declaration list 3:11.30 HRESULT _RetVal DECLSPEC_ALIGN(8);
Moving the DECLSPEC_ALIGN code before _RetVal fixes it.
https://bugs.winehq.org/show_bug.cgi?id=49173
--- Comment #1 from Emilio Cobos Álvarez (:emilio) emilio@crisal.io --- https://www.winehq.org/pipermail/wine-devel/2020-May/166368.html
https://bugs.winehq.org/show_bug.cgi?id=49173
Emilio Cobos Álvarez (:emilio) emilio@crisal.io changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED
--- Comment #2 from Emilio Cobos Álvarez (:emilio) emilio@crisal.io --- https://source.winehq.org/git/wine.git/commitdiff/b1084ff910864a44d6fd0e0bda...
https://bugs.winehq.org/show_bug.cgi?id=49173
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |5.8 Fixed by SHA1| |b1084ff910864a44d6fd0e0bda6 | |b2b6c64987b2e Component|rpc |tools
https://bugs.winehq.org/show_bug.cgi?id=49173
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #3 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 5.9.
https://bugs.winehq.org/show_bug.cgi?id=49173
--- Comment #4 from Michael Stefaniuc mstefani@winehq.org --- Removing the 5.0.x milestone from bug fixes included in 5.0.2.