[Bug 49172] New: Always true condition `code > 0xffff` in vbscript/global.c

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49172

Bug ID: 49172
           Summary: Always true condition `code > 0xffff` in
                    vbscript/global.c
           Product: Wine
           Version: 5.8
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: vbscript
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

code > 0xffff is always true - probably code > 0 should look like code < 0

https://github.com/wine-mirror/wine/blob/59987bc9ecdd0dbafd768a95c21a14884bc...

[Bug 49172] Always true condition `code > 0xffff` in vbscript/global.c

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49172

Robert Wilhelm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Robert Wilhelm  ---

Tests show that err.raise should set err.number to 5 (=invalid argument) when
parameter is 0 or >0xffff.

Therefore I think it should read:

if(code == 0 || code > 0xffff)
        return E_INVALIDARG;

I send a patch to wine-devel.

[Bug 49172] Always true condition `code > 0xffff` in vbscript/global.c

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49172

--- Comment #2 from Robert Wilhelm  ---
This is fixed now with commit 
https://source.winehq.org/git/wine.git/commitdiff/7d48c52816e170eb44dcb64a23...
and released in wine-5.18.

[Bug 49172] Always true condition `code > 0xffff` in vbscript/global.c

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49172

Vijay Kamuju  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
      Fixed by SHA1|                            |7d48c52816e170eb44dcb64a236
                   |                            |345aaf9cad7fd
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #3 from Vijay Kamuju  ---
Fix confirmed

[Bug 49172] Always true condition `code > 0xffff` in vbscript/global.c

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49172

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 5.19.

[Bug 49172] Always true condition `code > 0xffff` in vbscript/global.c

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49172

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0.x

[Bug 49172] Always true condition `code > 0xffff` in vbscript/global.c

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49172

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|5.0.x                       |---

--- Comment #5 from Michael Stefaniuc  ---
Removing the 5.0.x milestone from bug fixes included in 5.0.4.