http://bugs.winehq.org/show_bug.cgi?id=58443
Bug ID: 58443 Summary: x11 'minimized' windows not re-fullscreening (fallout 3 / new vegas) Product: Wine Version: 10.4 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: zlice@crtdrift.us Distribution: ---
c67bfdbeba1860c891e53c64379f5e86d8e8b664 / https://gitlab.winehq.org/wine/wine/-/commit/c67bfdbeba1860c891e53c64379f5e8...
reading the title of the mr makes sense, however this completely breaks fullscreen for fallout 3 and new vegas, and im sure other older games
as mentioned https://bugs.winehq.org/show_bug.cgi?id=58442 - there have been a lot of fullscreen/focus/window bugs so it's hard to tell what all is what
i spent a bunch of time to just bisect so i'll have to look for what is going on tomorrow
http://bugs.winehq.org/show_bug.cgi?id=58443
zlice zlice@crtdrift.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |c67bfdbeba1860c891e53c64379 | |f5e86d8e8b664
http://bugs.winehq.org/show_bug.cgi?id=58443
--- Comment #1 from zlice zlice@crtdrift.us --- for reference, fluxbox and openbox both were refusing to bring this back from being minimized
http://bugs.winehq.org/show_bug.cgi?id=58443
--- Comment #2 from zlice zlice@crtdrift.us --- 3ae66c75cf443c0be403d9fe4e4da3c19b3ad9a8 also contributes to this behavior
https://gitlab.winehq.org/wine/wine/-/commit/3ae66c75cf443c0be403d9fe4e4da3c...
i am question a lot of it ?
in event.c : window_set_wm_state - `set_focus` - it looks like it should be `if _NET_ACTIVE_WINDOW - return` or something
in window.c : `if (data->hwnd == foreground || data->is_fullscreen) activate = TRUE;`
makes no sense? fullscreen does not imply active in linux/x11? i have mpv fullscreened in the background all the time while i look stuff up. or may have something fullscreen on another monitor that is not active.
even then, why try to activate a foreground window? that should mean it's active?
seeing that window_set_wm_state is called on state change notifiy's and WindowPosChanged, that seems wrong
event.c has another 'check if foreground && active) - set_net_active ... which seems weird
idk the wine code that well, so this is probably beyond me. but it definitely breaks even without the previous MINIMIZE check previously bisected
http://bugs.winehq.org/show_bug.cgi?id=58443
--- Comment #3 from zlice zlice@crtdrift.us --- so dlls/winex11.drv/window.cc -- X11DRV_GetWindowStateUpdates
is the part that seems to juggle old/new foreground and causes something to go fubar
reverting that bit makes fallout 3 stay active while alt tabbing, which i personally love but isn't exactly what the game does in windows (but then again f windows behavior, like-for-like means a lot of shit breaks anyway)
AND it comes back from being manually minimized
this ALSO works with the original MINIMIZE check in set_window_pos() left in
hopefully that helps. will comment it out for myself and if i notice anything else breaking because of it i'll update here
http://bugs.winehq.org/show_bug.cgi?id=58443
--- Comment #4 from zlice zlice@crtdrift.us --- after some short testing, i don't think this would work for most people. openbox and jwm do seem to think fullscreen implies above all windows and maximized, but change focus and then you are lost.
these games on fluxbox will behave like normal sane windows and stay up on alt+tab, which again i cannot stress enough how much i love
fallout 3 fallout nv mass effect 1 kotor spec ops the line prey fallout 4 (has bAlwaysActive ini setting for this, which pretty much means it's forced on?)
watch dogs seems to see it's not focused and minimizes
-
WineHQ Bugzilla