http://bugs.winehq.org/show_bug.cgi?id=19862
Summary: CodeCreatures crashes. Product: Wine Version: 1.1.28 Platform: PC URL: http://ftp.sunet.se/pub/games/PC/guru3d/benchmark/Code creatures_Benchmark_Pro_Setup.exe OS/Version: Linux Status: NEW Keywords: download Severity: normal Priority: P2 Component: directx-d3d AssignedTo: wine-bugs@winehq.org ReportedBy: xerox_xerox2000@yahoo.co.uk
I tried some benchmark programs from guru3d, this (rather old) benchmark program crashes. I'll attach the log generated by the app itsself. The console output didn't really tell anything interesting.
Note for myself, the dumb hack below makes the app run fine. diff --git a/dlls/d3d8/texture.c b/dlls/d3d8/texture.c index c22c491..58b5365 100644 --- a/dlls/d3d8/texture.c +++ b/dlls/d3d8/texture.c @@ -270,7 +270,7 @@ static HRESULT WINAPI IDirect3DTexture8Impl_UnlockRect(LPDIRECT3DTEXTURE8 iface, hr = IWineD3DTexture_UnlockRect(This->wineD3DTexture, Level); wined3d_mutex_unlock();
- return hr; + return 0;//hr; }
static HRESULT WINAPI IDirect3DTexture8Impl_AddDirtyRect(LPDIRECT3DTEXTURE8 iface, CONST RECT *pDirtyRect) {
http://bugs.winehq.org/show_bug.cgi?id=19862
--- Comment #1 from Louis Lenders xerox_xerox2000@yahoo.co.uk 2009-08-27 18:07:49 --- Created an attachment (id=23291) --> (http://bugs.winehq.org/attachment.cgi?id=23291) the crash log from the application
http://bugs.winehq.org/show_bug.cgi?id=19862
--- Comment #2 from Henri Verbeet hverbeet@gmail.com 2009-08-28 11:33:37 --- It's possible d3d8 should return D3D_OK if the surface isn't locked, that would be consistent with the behaviour for e.g. vertex buffers. It's also possible it should return D3DERR_INVALIDCALL and the program simply doesn't recognize the ddraw error code we return. Could you write some tests for that? The behaviour is likely different between ddraw and d3d8/d3d9, so you need tests for all three. d3d10 Unmap() doesn't have a return code.
http://bugs.winehq.org/show_bug.cgi?id=19862
--- Comment #3 from Louis Lenders xerox_xerox2000@yahoo.co.uk 2009-08-29 05:39:28 --- (In reply to comment #2)
Could you write some tests for that? The behaviour is likely different between ddraw and d3d8/d3d9, so you need tests for all three. d3d10 Unmap() doesn't have a return code.
I think i should be able to write test for d3d8/d3d9 as I fiddled around with those tests it a bit before. I'll do later on this week.
As for ddraw, not sure i will be able to write test, never looked at it really (btw this app uses d3d8, not ddraw)
http://bugs.winehq.org/show_bug.cgi?id=19862
--- Comment #4 from Louis Lenders xerox_xerox2000@yahoo.co.uk 2009-08-31 04:32:58 --- Created an attachment (id=23348) --> (http://bugs.winehq.org/attachment.cgi?id=23348) d3d8: test unlocking twice.
I saw there was a test for double locking already, so i just merged a few lines for double unlocking, that was the easiest. Hope that's ok
I tested in windows, and it appaers IDirect3DTexture8_UnlockRect does return D3D_OK, when unlocking twice.
IDirect3DSurface8_UnlockRect returns D3DERR_INVALIDCALL in that case
I'll attach tests for d3d9 hereafter
http://bugs.winehq.org/show_bug.cgi?id=19862
Louis Lenders xerox_xerox2000@yahoo.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #23348|0 |1 is obsolete| |
http://bugs.winehq.org/show_bug.cgi?id=19862
--- Comment #5 from Louis Lenders xerox_xerox2000@yahoo.co.uk 2009-08-31 04:36:47 --- Created an attachment (id=23349) --> (http://bugs.winehq.org/attachment.cgi?id=23349) d3d8: test unlocking twice.
Here it is again:
I saw there was a test for double locking already, so i just merged a few lines for double unlocking, that was the easiest. Hope that's ok
I tested in windows, and it appaers IDirect3DTexture8_UnlockRect does return D3D_OK, when unlocking twice.
IDirect3DSurface8_UnlockRect returns D3DERR_INVALIDCALL in that case
I'll attach tests for d3d9 hereafter
http://bugs.winehq.org/show_bug.cgi?id=19862
--- Comment #6 from Louis Lenders xerox_xerox2000@yahoo.co.uk 2009-08-31 04:48:09 --- Created an attachment (id=23350) --> (http://bugs.winehq.org/attachment.cgi?id=23350) d3d9: test double unlocking
tests for double unlocking in d3d9, behaves same as d3d8 on windows.
http://bugs.winehq.org/show_bug.cgi?id=19862
--- Comment #7 from Louis Lenders xerox_xerox2000@yahoo.co.uk 2009-08-31 05:14:36 --- Created an attachment (id=23351) --> (http://bugs.winehq.org/attachment.cgi?id=23351) patch that fixes the bug.
Maybe something like the attached is a possible fix. I dunno how ddraw does things however
http://bugs.winehq.org/show_bug.cgi?id=19862
Niko Sandschneider nsandschn@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nsandschn@gmx.de
--- Comment #8 from Niko Sandschneider nsandschn@gmx.de 2010-06-15 13:53:30 --- Codecreatures doesn't crash in wine-1.2-rc3-43-gba9ec15, so this seems to be fixed. All the benchmark tests fail though. Tested with a Radeon 5770 and Catalyst 10.5
http://bugs.winehq.org/show_bug.cgi?id=19862
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #9 from Dmitry Timoshkov dmitry@codeweavers.com 2010-06-16 03:59:13 --- Reported fixed.
http://bugs.winehq.org/show_bug.cgi?id=19862
Louis Lenders xerox_xerox2000@yahoo.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |
--- Comment #10 from Louis Lenders xerox_xerox2000@yahoo.co.uk 2010-06-16 09:46:33 --- Doesn't work here. Still reports Unlock failed. Niko, didn't you get that error window?
http://bugs.winehq.org/show_bug.cgi?id=19862
--- Comment #11 from Niko Sandschneider nsandschn@gmx.de 2010-06-16 15:30:44 --- No, I don't see this. What I completely forgot to mention was that I needed 'winetricks mfc42'. Otherwise Codecreatures didn't start because of:
err:module:import_dll Library MFC42.DLL (which is needed by L"C:\Program Files\Codecult\Codecreatures Benchmark Pro\Codecreatures Benchmark Pro.exe") not found
Sorry about that :( When do you get the Unlock error? Right on startup or after you execute the benchmark tests?
http://bugs.winehq.org/show_bug.cgi?id=19862
--- Comment #12 from Louis Lenders xerox_xerox2000@yahoo.co.uk 2010-06-16 15:41:30 --- Created an attachment (id=28901) --> (http://bugs.winehq.org/attachment.cgi?id=28901) screenshot of errormessage
I attached errormessage i get. This is after clicking button 'User defined benchmark'
http://bugs.winehq.org/show_bug.cgi?id=19862
--- Comment #13 from Niko Sandschneider nsandschn@gmx.de 2010-06-16 16:04:20 --- Okay, your screenshot helped to find the the difference. I was running the app in fullscreen mode. When I run it in virtual desktop mode I get the same error as you.
http://bugs.winehq.org/show_bug.cgi?id=19862
joaopa jeremielapuree@yahoo.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree@yahoo.fr
--- Comment #14 from joaopa jeremielapuree@yahoo.fr 2010-12-08 00:13:37 CST --- Louis, did you send your patches to the wine-patches list?
http://bugs.winehq.org/show_bug.cgi?id=19862
--- Comment #15 from Louis Lenders xerox_xerox2000@yahoo.co.uk 2010-12-09 17:21:28 CST --- (In reply to comment #14)
Louis, did you send your patches to the wine-patches list?
IIRC yes, but i'm not 100% sure. Maybe a d3d-guru could give some feedback.
http://bugs.winehq.org/show_bug.cgi?id=19862
--- Comment #16 from joaopa jeremielapuree@yahoo.fr 2012-11-19 01:20:15 CST --- Still a bug in current wine?
https://bugs.winehq.org/show_bug.cgi?id=19862
--- Comment #17 from Artem S. Tashkinov t.artem@mailcity.com --- (In reply to joaopa from comment #16)
Still a bug in current wine?
Yep:
***************************************************************** ***************************************************************** Codecreatures Engine LogFile Date: 9/6/2014 / Time:1:19:15 PM ***************************************************************** ***************************************************************** ----------------------------------------------------------------- Guru Meditation ----------------------------------------------------------------- Fatal error detected: Module: GECTextureBasic::Unlock Msg:'Texture unlock failed. This is a fatal error.' at line:855 File:<U:\golem\work\source\engine\system\graphic\GEDX8GRAPHICDRV\ge_dx8image.cpp> ----------------------------------------------------------------- History Log ----------------------------------------------------------------- LOG BEGIN. @cerr: 00000.055 GECAdminPlugin ReadAnSetEngineInfo - warning: musicdriver could not be set. Musicdriver was not initialised.! @cerr: 00000.055 GECAdminPlugin ReadAnSetEngineInfo - warning: networkdriver could not be set. Networkdriver was not initialised.! @cerr: 00000.055 GECAdminPlugin ReadAndSetEngineInfo - (null) could not be found in configuration file. @serr: 00000.851 :GECMemoryMappedFile::Open -> File mapping creation for open file: "C:\users\birdie\Temp\g0191667e.tch" failed due to no apparent reason!. @serr: 00000.853 :geSoundCacheGetStatus - not supported ... @serr: 00000.853 :geSoundCacheSetStatus - not supported ... @serr: 00000.889 :CPPluginInstance_Create - could not create plugininstance. PNID: 9 is not a valid PluginID. @serr: 00000.889 :CPPluginInstance_Create - could not create plugininstance. PNID: 5 is not a valid PluginID. @serr: 00000.889 :geSoundCacheClear - not supported ... @serr: 00000.989 :GECMemoryMappedFile::Open -> File mapping creation for open file: "C:\users\birdie\Temp\g01916708.tch" failed due to no apparent reason!. @cerr: 00005.342 GECSceneZoneCach RemoveZone - couldnt remove zone from GridArray. Zone isnt in Array. Zone: 1 @cerr: 00005.444 GECSceneZoneCach RemoveZone - couldnt remove zone from GridArray. Zone isnt in Array. Zone: 2 @cerr: 00005.453 GECSceneZoneCach RemoveZone - couldnt remove zone from GridArray. Zone isnt in Array. Zone: 3 @cerr: 00005.482 GECSceneZoneCach RemoveZone - couldnt remove zone from GridArray. Zone isnt in Array. Zone: 4 @cerr: 00005.486 GECSceneZoneCach RemoveZone - couldnt remove zone from GridArray. Zone isnt in Array. Zone: 5 @cerr: 00005.489 GECSceneZoneCach RemoveZone - couldnt remove zone from GridArray. Zone isnt in Array. Zone: 6 @serr: 00005.499 :Callback: geItemAddRef - couldnt get archivefile. Guid {F80638A3-A580-42D0-B683-C8DFD1C7A505} @cerr: 00005.499 GECItemAdmin Load - archiveFileGuid: {F80638A3-A580-42D0-B683-C8DFD1C7A505} is not adressed as a valid archiveFile. Couldn't found file @serr: 00006.124 :GECTextureBasic::Lock - can't lock texture. Object is already locked. Texturehandle: 0x00dd0514 @serr: 00006.124 :GECTextureBasic::Lock - can't lock texture. Object is already locked. Texturehandle: 0x00dd0514 @serr: 00006.124 :GECTextureBasic::Lock - can't lock texture. Object is already locked. Texturehandle: 0x00dd0514 @serr: 00006.125 :GECTextureBasic::Lock - can't lock texture. Object is already locked. Texturehandle: 0x00dd0514 @serr: 00006.125 :GECTextureBasic::Lock - can't lock texture. Object is already locked. Texturehandle: 0x00dd0514 @serr: 00006.126 :GECTextureBasic::Lock - can't lock texture. Object is already locked. Texturehandle: 0x00dd0514 @serr: 00006.127 :GECTextureBasic::Lock - can't lock texture. Object is already locked. Texturehandle: 0x00dd0514 @serr: 00006.128 :GECTextureBasic::Lock - can't lock texture. Object is already locked. Texturehandle: 0x00dd0514 @serr: 00006.129 :DirectX ERROR String: 'D3DERR_INVALIDCALL' !!! @serr: 00006.130 :DirectX ERROR Description: 'Invalid call'. LOG END. Time: 00006.176. ----------------------------------------------------------------- Debug Heap ----------------------------------------------------------------- Heap profiler not active! ----------------------------------------------------------------- Call Stack ----------------------------------------------------------------- ----------------------------------------------------------------- Register ----------------------------------------------------------------- *****************************************************************
https://bugs.winehq.org/show_bug.cgi?id=19862
--- Comment #18 from Artem S. Tashkinov t.artem@mailcity.com --- I also ran the benchmark in Wine's virtual desktop mode (I hate apps changing my desktop resolution).
https://bugs.winehq.org/show_bug.cgi?id=19862
--- Comment #19 from Artem S. Tashkinov t.artem@mailcity.com --- A small correction: in normal mode it crashes with the same error message.
https://bugs.winehq.org/show_bug.cgi?id=19862
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #20 from super_man@post.com --- Used virtual desktop. The benchmark refuses to run similar to the picture attached here.
wine 1.7.52
https://bugs.winehq.org/show_bug.cgi?id=19862
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xerox_xerox2000@yahoo.co.uk
https://bugs.winehq.org/show_bug.cgi?id=19862
Józef Kucia joseph.kucia@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=28874 CC| |joseph.kucia@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=19862
Józef Kucia joseph.kucia@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |8f8c2a8ade8d8b2c61c5f1614aa | |477900d6ab449 Resolution|--- |FIXED Status|REOPENED |RESOLVED
--- Comment #21 from Józef Kucia joseph.kucia@gmail.com --- Fixed by commit 8f8c2a8ade8d8b2c61c5f1614aa477900d6ab449.
https://bugs.winehq.org/show_bug.cgi?id=19862
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dredgingthelake@gmail.com
--- Comment #22 from Bruno Jesus 00cpxxx@gmail.com --- *** Bug 28874 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=19862
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #23 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 2.0-rc6.
https://bugs.winehq.org/show_bug.cgi?id=19862
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.8.x
https://bugs.winehq.org/show_bug.cgi?id=19862
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.8.x |---
--- Comment #24 from Michael Stefaniuc mstefani@redhat.com --- Removing 1.8.x milestone from bugs included in 1.8.7.
-
wine-bugs＠winehq.org