[Bug 47483] New: Significant performance regression in Overwatch due to loader-KeyboardLayouts patch

https://bugs.winehq.org/show_bug.cgi?id=47483

Bug ID: 47483
           Summary: Significant performance regression in Overwatch due to
                    loader-KeyboardLayouts patch
           Product: Wine-staging
           Version: 4.12.1
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail]
      Distribution: ---

Seems like this patch creates a lot of entries in system.reg (around 600 lines)
that all look pretty much like this: 
[System\CurrentControlSet\Control\Keyboard Layouts\000b0c00] 1562521578
6843440
#time=1d534ebe1c1fd30
This somehow??? results in 40% drop of FPS in my test app/game, Overwatch
(could be similar to this? https://bugs.winehq.org/show_bug.cgi?id=47431)
Reverting the patch fixes it but only if I also remove all the spammy entries
from the system.reg in the prefix. Leaving them causes even older versions Wine
versions to experience the performance drop.

[Bug 47483] Significant performance regression in Overwatch due to loader-KeyboardLayouts patch

https://bugs.winehq.org/show_bug.cgi?id=47483

--- Comment #1 from Alistair Leslie-Hughes  ---
Could you please attach a +reg log?

[Bug 47483] Significant performance regression in Overwatch due to loader-KeyboardLayouts patch

https://bugs.winehq.org/show_bug.cgi?id=47483

--- Comment #2 from Alexandr Oleynikov  ---
Created attachment 64863
  --> https://bugs.winehq.org/attachment.cgi?id=64863
overwatch_-all,+reg

Attaching -all,+reg log (had to run it with -all as there was a lot of spam
from other components)

[Bug 47483] Significant performance regression in Overwatch due to loader-KeyboardLayouts patch

https://bugs.winehq.org/show_bug.cgi?id=47483

--- Comment #3 from Alistair Leslie-Hughes  ---
Created attachment 64869
  --> https://bugs.winehq.org/attachment.cgi?id=64869
Improve GetKeyboardLayoutList

Can you please try the attached patch?

[Bug 47483] Significant performance regression in Overwatch due to loader-KeyboardLayouts patch

https://bugs.winehq.org/show_bug.cgi?id=47483

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 47483] Significant performance regression in Overwatch due to loader-KeyboardLayouts patch

https://bugs.winehq.org/show_bug.cgi?id=47483

--- Comment #4 from Alexandr Oleynikov  ---
The patch fixed it and made it run like before, thanks.

[Bug 47483] Significant performance regression in Overwatch due to loader-KeyboardLayouts patch

https://bugs.winehq.org/show_bug.cgi?id=47483

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #5 from Alistair Leslie-Hughes  ---
This is now fixed.

[Bug 47483] Significant performance regression in Overwatch due to loader-KeyboardLayouts patch

https://bugs.winehq.org/show_bug.cgi?id=47483

--- Comment #6 from Dmitry Timoshkov  ---
(In reply to Alistair Leslie-Hughes from comment #3)
> Created attachment 64869 [details]
> Improve GetKeyboardLayoutList

This patch has broken formatting due to tabs being treated as 4 spaces.
Looks like the same patch was committed.

[Bug 47483] Significant performance regression in Overwatch due to loader-KeyboardLayouts patch

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47483

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alistair Leslie-Hughes  ---
Closing Fixed wine-staging.