[Bug 25975] New: Regression: Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

Summary: Regression: Edge of Chaos window display does not
                    update
           Product: Wine
           Version: 1.3.5
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Running the regression test, but I'm caught in the middle of a crash-on-startup
which was fixed but no idea when.

The video output of the game never updates by itself. It does update once if I
click the window to move it (super+click, ...). Every time I do that, it
complains:

err:x11settings:X11DRV_ChangeDisplaySettingsEx No matching mode found
1680x1050x32 @0! (XRandR)
fixme:win:EnumDisplayDevicesW ((null),0,0x33e910,0x00000000), stub!

Last known working version: wine-1.3.0
First known broken version: wine-1.3.5

[Bug 25975] Regression: Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Regression: Edge of Chaos   |Edge of Chaos window
                   |window display does not     |display does not update
                   |update                      |

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

--- Comment #1 from Jerome Leclanche  2011-02-03 07:58:51 CST ---

5fa84c56c344927dcb13b12409fbf64d738438f4 is the first bad commit
commit 5fa84c56c344927dcb13b12409fbf64d738438f4
Author: Henri Verbeet 
Date:   Tue Oct 5 14:32:35 2010 +0200

ddraw: Remove another hack.

It breaks actual front buffer / back buffer flips.

:040000 040000 3b85800dcfb6069dc55abe0daa21e63694c1d600
5add7ba691e5b542e503ea14b373af3b9a569a36 M      dlls
:040000 040000 dd04818a2c84caaf8d64932e313154e159ad5621
205e27a6da9999ca94a47e7bedffbb4b0d02e0c5 M      include

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Jerome Leclanche  2011-02-03 08:09:00 CST ---
CC Henri

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |directx-ddraw

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

--- Comment #3 from Jerome Leclanche  2011-03-27 13:28:27 CDT ---
That's interesting. With vlc running in the background, the screenspace taken
by the video is properly updated.

Anyway: only happens with compositing enabled.

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

--- Comment #4 from Henri Verbeet  2011-04-06 17:58:26 CDT ---
(In reply to comment #3)
> That's interesting. With vlc running in the background, the screenspace taken
> by the video is properly updated.
>
> Anyway: only happens with compositing enabled.

Yeah, that would be consistent with a missing glFlush() somewhere. Could you
create a +ddraw,+d3d,+d3d_surface log? I suspect surface_blt_fbo(), but I'd
like to make sure.

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

--- Comment #5 from Jerome Leclanche  2011-04-06 18:15:05 CDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > That's interesting. With vlc running in the background, the screenspace taken
> > by the video is properly updated.
> >
> > Anyway: only happens with compositing enabled.
>
> Yeah, that would be consistent with a missing glFlush() somewhere. Could you
> create a +ddraw,+d3d,+d3d_surface log? I suspect surface_blt_fbo(), but I'd
> like to make sure.

With compositing enabled or disabled?

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

--- Comment #6 from Henri Verbeet  2011-04-06 18:18:29 CDT ---
Shouldn't really matter. Enabled, I guess.

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

--- Comment #7 from Jerome Leclanche  2011-04-06 19:14:12 CDT ---
Created an attachment (id=33968)
 --> (http://bugs.winehq.org/attachment.cgi?id=33968)
WINEDEBUG=+ddraw,+d3d,+d3d_surface wine iw2eocgs

Trace attached. Compositing enabled, I focused/unfocused the window a few times
and exit. The crash at the end is another bug.

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

--- Comment #8 from Henri Verbeet  2011-04-07 06:27:04 CDT ---
Created an attachment (id=33977)
 --> (http://bugs.winehq.org/attachment.cgi?id=33977)
patch

Does this patch help?

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

--- Comment #9 from Jerome Leclanche  2011-04-07 06:29:02 CDT ---
(In reply to comment #8)
> Created an attachment (id=33977)

--> (http://bugs.winehq.org/attachment.cgi?id=33977) [details]
> patch
>
> Does this patch help?

Yep. Thanks.

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

--- Comment #10 from Henri Verbeet  2011-04-12 11:22:57 CDT ---
Should be fixed by 55e957a31a8fea55a27285483202723db06407bc.

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Jerome Leclanche  2011-04-12 12:59:39 CDT ---
Yes.

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  2011-04-15 12:49:54 CDT ---
Closing bugs fixed in 1.3.18.

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |55e957a31a8fea55a2728548320
                   |                            |2723db06407bc
    Regression SHA1|                            |5fa84c56c344927dcb13b12409f
                   |                            |bf64d738438f4

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.gog.com/en/gamec
                   |                            |ard/independence_war_2

[Bug 25975] Edge of Chaos window display does not update

http://bugs.winehq.org/show_bug.cgi?id=25975

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-ddraw               |directx-d3d