[Bug 28828] New: gmail notifier getting unexpected http headers

http://bugs.winehq.org/show_bug.cgi?id=28828

Bug #: 28828
           Summary: gmail notifier getting unexpected http headers
           Product: Wine
           Version: 1.3.30
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: wininet
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

adys@azura ~/downloads % wine GmailInstaller.exe 
fixme:wininet:URLCache_FindFirstFreeEntry Grow file
err:wininet:CommitUrlCacheEntryInternal no free entries
fixme:wininet:URLCache_FindFirstFreeEntry Grow file
err:wininet:CommitUrlCacheEntryInternal no free entries
...
fixme:wininet:URLCache_FindFirstFreeEntry Grow file
err:wininet:CommitUrlCacheEntryInternal no free entries
fixme:wininet:URLCache_FindFirstFreeEntry Grow file
err:wininet:CommitUrlCacheEntryInternal no free entries
err:wininet:HTTP_ParseRfc1123Date unexpected month L"-Ja"

[12:26:12] <jacek> Adys: looks like we get a http header that we don't expect

[Bug 28828] gmail notifier getting unexpected http headers

http://bugs.winehq.org/show_bug.cgi?id=28828

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Installer
                URL|                            |http://toolbar.google.com/g
                   |                            |mail-helper/notifier_window
                   |                            |s.html

[Bug 28828] gmail notifier getting unexpected http headers

http://bugs.winehq.org/show_bug.cgi?id=28828

--- Comment #1 from Jerome Leclanche  2011-10-20 06:34:38 CDT ---

trace:wininet:HTTP_GetResponseHeaders raw headers: L"HTTP/1.1 401
Unauthorized\r\nContent-Type: text/plain; charset=UTF-8\r\nWWW-Authenticate:
basic realm="Please log in to your Google Account"\r\nCache-control:
no-cache, no-store\r\nPragma: no-cache\r\nExpires: Mon, 01-Jan-1990 00:00:00
GMT\r\nDate: Thu, 20 Oct 2011 11:33:47 GMT\r\nX-Content-Type-Op"...
trace:wininet:HTTP_GetResponseHeaders <--
trace:wininet:INTERNET_SendCallback  callback(0x40a5e0) (0x3 (0x128de0),
00000004, 41 (INTERNET_STATUS_RESPONSE_RECEIVED), 0x9ae97c, 4)
trace:wininet:INTERNET_SendCallback  end callback().
trace:wininet:HTTP_GetCustomHeaderIndex L"Connection", 0, 0
trace:wininet:HTTP_GetCustomHeaderIndex Return: -1
trace:wininet:HTTP_GetCustomHeaderIndex L"Set-Cookie", 0, 0
trace:wininet:HTTP_GetCustomHeaderIndex Return: -1
trace:wininet:HTTP_GetCustomHeaderIndex L"Cache-Control", 0, 0
trace:wininet:HTTP_GetCustomHeaderIndex Return: 8
trace:wininet:HTTP_GetCustomHeaderIndex L"Expires", 0, 0
trace:wininet:HTTP_GetCustomHeaderIndex Return: 10
err:wininet:HTTP_ParseRfc1123Date unexpected month L"-Ja"

[Bug 28828] gmail notifier getting unexpected http headers

http://bugs.winehq.org/show_bug.cgi?id=28828

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #2 from Juan Lang  2011-10-21 15:44:47 CDT ---
Confirming by reading the code (which I wrote.)  Here's the relevant comment:

/* FIXME: only accepts dates in RFC 1123 format and asctime() format,
 * which may not be the only formats actually seen in the wild.
 * http://www.hackcraft.net/web/datetime/ suggests at least RFC 850 dates
 * should be accepted as well.

According to that URL, an RFC 850 date format is:
rfc850-date  = weekday "," SP date2 SP time SP "GMT"

where weekday is one of "Monday", "Tuesday", etc.  But what we see is "Mon"
instead.  Looks like we'll have to be even more permissive.

[Bug 28828] gmail notifier getting unexpected http headers

http://bugs.winehq.org/show_bug.cgi?id=28828

--- Comment #3 from Juan Lang  2011-10-21 16:32:10 CDT ---
Created attachment 37047
  --> http://bugs.winehq.org/attachment.cgi?id=37047
Patch: Accept RFC 850 dates in HTTP headers

Does this patch help?

[Bug 28828] gmail notifier getting unexpected http headers

http://bugs.winehq.org/show_bug.cgi?id=28828

--- Comment #4 from Jerome Leclanche  2011-10-21 16:39:49 CDT ---
(In reply to comment #3)
Yeah, I don't see the errs anymore.

[Bug 28828] gmail notifier getting unexpected http headers

http://bugs.winehq.org/show_bug.cgi?id=28828

--- Comment #5 from Jerome Leclanche  2011-10-22 05:34:55 CDT ---
Patch sent

[Bug 28828] gmail notifier getting unexpected http headers

http://bugs.winehq.org/show_bug.cgi?id=28828

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Jerome Leclanche  2011-10-24 15:45:11 CDT ---
Fixed by aeca2f98fa6086b0a83d9acece336e91a6a6df6f -- nice
emergency-regression-fix, Juan ;)

[Bug 28828] gmail notifier getting unexpected http headers

http://bugs.winehq.org/show_bug.cgi?id=28828

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |aeca2f98fa6086b0a83d9acece3
                   |                            |36e91a6a6df6f

[Bug 28828] gmail notifier getting unexpected http headers

http://bugs.winehq.org/show_bug.cgi?id=28828

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  2011-11-04 14:15:44 CDT ---
Closing bugs fixed in 1.3.32.