http://bugs.winehq.org/show_bug.cgi?id=20522
Summary: Graphic Glitcheson Game Maker games with 1.1.31 and 1.1.32 Product: Wine Version: 1.1.32 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: zombie@terralab.com
Graphic Glitches for transparent objects appear in Wine 1.1.31 and 32. (1.1.30 is unaffected and runs perfectly.)
Particularly affected is RockMan: Mega Man in Paradise, where transparent objects appear as being bright green, rendering the game unplayable.
fixme:dsalsa:IDsDriverBufferImpl_SetVolumePan (0x1f5bae8,0x1f5ba70): stub fixme:win:EnumDisplayDevicesW ((null),0,0x33f528,0x00000000), stub! fixme:d3d_surface:IWineD3DBaseSurfaceImpl_Blt Can't handle WINEDDBLT_ASYNC flag right now. fixme:mcimidi:MIDI_mciPlay NIY: MIDI port=0, track=0 fixme:ddraw:IDirectDrawImpl_WaitForVerticalBlank (0x16a618)->(1,(nil)): Stub
http://bugs.winehq.org/show_bug.cgi?id=20522
Jeff Zaroyko jeffz@jeffz.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Summary|Graphic Glitcheson Game |Graphic Glitcheson Game |Maker games with 1.1.31 and |Maker games |1.1.32 |
--- Comment #1 from Jeff Zaroyko jeffz@jeffz.name 2009-10-30 15:08:44 --- please post the results of your regression testing http://wiki.winehq.org/RegressionTesting
http://bugs.winehq.org/show_bug.cgi?id=20522
--- Comment #2 from Wylda wylda@volny.cz 2009-11-08 19:17:55 --- Created an attachment (id=24611) --> (http://bugs.winehq.org/attachment.cgi?id=24611) Megaman in paradise - problem with blitting in 24bit color depth
Hopefully this tiny game will help to find out source of all troubles in affected area...
1. Confirming, please consider UNCONFIRMED->NEW and KEYWORDS: +DOWNLOAD
2. Did a regression test between 1.1.30 and 1.1.31:
6b8753185f30197047773af6a26eafd34d45367c is first bad commit commit 6b8753185f30197047773af6a26eafd34d45367c Author: Roderick Colenbrander thunderbird2k@gmail.com Date: Sat Sep 26 14:52:46 2009 +0200
winex11: Add support for 16-bit/32-bit DIB sections.
:040000 040000 f2d2821909d152a1d37ae2932bf6017d7b622344 74221a3bdd0b8be716ed4c7900a58fddc93a2f08 M dlls
3. There are another bug reports suffering from this commit, see bug 20380, bug 20391, bug 20554.
4. Revert of this patch on top of wine-1.1.31 makes that problem goes away.
5. Adding author of this patch to CC and voting for this bug report.
Download: http://www.yoyogames.com/games/launch/10014
There is an easy work around. If you switch to 16bit color depth, there is no problem with blitting, but extra error shows up in this case "err:x11drv:X11DRV_CreateBitmap Trying to make bitmap with planes=1, bpp=32".
In other words: To see this bug, i have to have desktop color depth set to 24bit.
http://bugs.winehq.org/show_bug.cgi?id=20522
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |thunderbird2k@gmail.com, | |wylda@volny.cz
http://bugs.winehq.org/show_bug.cgi?id=20522
Jeff Zaroyko jeffz@jeffz.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #3 from Jeff Zaroyko jeffz@jeffz.name 2009-11-08 23:52:03 --- confirming then, thanks for the regression test Wylda.
http://bugs.winehq.org/show_bug.cgi?id=20522
--- Comment #4 from Roderick Colenbrander thunderbird2k@gmail.com 2009-11-11 13:59:19 --- I see wined3d (?) performing 24-bit -> 32-bit and 32-bit -> 32-bit. Under the hood we use a ARGB xrender format which preserves an alpha channel when it is around. If I use X8R8G8B8 the app renders properly but then the alpha channel is lost when apps use that which you don't know beforehand. I can't easily say where the real bug is. It might be that I'm not using xrender properly (but I don't think this is the case), so I think the issue is somewhere in wined3d. A log in combination +ddraw,+d3d_surface or so might be useful.
http://bugs.winehq.org/show_bug.cgi?id=20522
--- Comment #5 from Wylda wylda@volny.cz 2009-11-11 23:22:58 --- Created an attachment (id=24687) --> (http://bugs.winehq.org/attachment.cgi?id=24687) Megaman in paradise, 24bit color depth; wine-1.1.32-539-gab081aa; +ddraw,+d3d_surface
(In reply to comment #4)
A log in combination +ddraw,+d3d_surface or so might be useful.
Don't be shy for asking another traces. I'm still patient reporter ;)
http://bugs.winehq.org/show_bug.cgi?id=20522
--- Comment #6 from Roderick Colenbrander thunderbird2k@gmail.com 2009-11-14 09:41:26 --- I have submitted a patch to wine-patches to fix the bug. The bug itself was in wined3d and the 32-bit dibsection patch uncovered it. Another part of wined3d already had a similar fix for years.
http://bugs.winehq.org/show_bug.cgi?id=20522
--- Comment #7 from Wylda wylda@volny.cz 2009-11-15 04:46:48 --- (In reply to comment #6)
I have submitted a patch to wine-patches to fix the bug. The bug itself was in wined3d and the 32-bit dibsection patch uncovered it. Another part of wined3d already had a similar fix for years.
That is great news! Thank you for your hard work Roderick.
Unfortunately this game has still the same problem in unpatched wine-1.1.33. I'm not familiar with wine-patches list/forum/whatever... So could you attach mentioned patch to this bug report for me to test is?
--private keyword: bisected
http://bugs.winehq.org/show_bug.cgi?id=20522
--- Comment #8 from Roderick Colenbrander thunderbird2k@gmail.com 2009-11-15 05:13:01 --- Created an attachment (id=24758) --> (http://bugs.winehq.org/attachment.cgi?id=24758) fix
Here's the patch.
http://bugs.winehq.org/show_bug.cgi?id=20522
--- Comment #9 from Wylda wylda@volny.cz 2009-11-15 06:04:27 --- (In reply to comment #8)
Created an attachment (id=24758)
--> (http://bugs.winehq.org/attachment.cgi?id=24758) [details]
fix
Here's the patch.
Patch works perfectly on top of 1.1.33. Thank you again for great work Roderick.
Do you think, that it fixes all the following bug:
* bug 20380 * bug 20391 * bug 20554
Unfortunately i have to leave now and will be able to test those bugs latter today.
http://bugs.winehq.org/show_bug.cgi?id=20522
--- Comment #10 from Roderick Colenbrander thunderbird2k@gmail.com 2009-11-15 06:38:53 --- The three bugs are not related. The only bug of which I don't know the cause yet is 20380 as I haven't seen that bug on my system.
http://bugs.winehq.org/show_bug.cgi?id=20522
--- Comment #11 from Wylda wylda@volny.cz 2009-12-15 16:57:43 --- (In reply to comment #8)
Here's the patch.
Hi Roderick, why this patch was not merged into git? Because bug 21022 shows, that it still affect games even in 1.1.34.
Another piece of knowledge with this issue - when set to Win98, it displays the game correctly whereas WinXP has described problem with blitting.
http://bugs.winehq.org/show_bug.cgi?id=20522
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bobtheblueberry@gmail.com
--- Comment #12 from Vitaliy Margolen vitaliy@kievinfo.com 2009-12-15 19:40:06 --- *** Bug 21022 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=20522
Roderick Colenbrander thunderbird2k@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #13 from Roderick Colenbrander thunderbird2k@gmail.com 2009-12-17 10:39:40 --- The patch wasn't in git because it broke some other tests. I have updated the patch and it is in GIT now.
http://bugs.winehq.org/show_bug.cgi?id=20522
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #14 from Alexandre Julliard julliard@winehq.org 2009-12-18 13:07:47 --- Closing bugs fixed in 1.1.35.
http://bugs.winehq.org/show_bug.cgi?id=20522
--- Comment #15 from Wylda wylda@volny.cz 2009-12-19 17:22:13 ---
Confirming, fixed in 1.1.35. Thank you Roderick!
http://bugs.winehq.org/show_bug.cgi?id=20522
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |6b8753185f30197047773af6a26 | |eafd34d45367c