[Bug 40177] New: multicharacter constant warning in wineqtdecoder

https://bugs.winehq.org/show_bug.cgi?id=40177

Bug ID: 40177
           Summary: multicharacter constant warning in wineqtdecoder
           Product: Wine
           Version: 1.9.3
          Hardware: x86
                OS: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]

gcc-4.8.4 shows me a warning
~~~
dlls/wineqtdecoder/qtsplitter.c:1049:187: warning: multi-character character
constant [-Wmultichar]
     err = NewMovieFromDataRef(&filter->pQTMovie,
newMovieActive|newMovieDontInteractWithUser|newMovieDontAutoUpdateClock|newMovieDontAskUnresolvedDataRefs|newMovieAsyncOK,
&id, dataRef, 'WINE');
~~~~
Should it be "WINE" or some other idea?
According to spec it must be (file, URL, pointer, or handle), not a character
and moreover not a multicharacter.

[Bug 40177] multicharacter constant warning in wineqtdecoder

https://bugs.winehq.org/show_bug.cgi?id=40177

--- Comment #1 from Henri Verbeet  ---
It's probably supposed to be a FourCC.

[Bug 40177] multicharacter constant warning in wineqtdecoder

https://bugs.winehq.org/show_bug.cgi?id=40177

--- Comment #2 from Sergey Isakov  ---
OK, it works
~~~~
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

int main(int argc, char **argv)
{
    unsigned int Wine = 'WINE';
    printf("%#x\n", Wine);
}
~~~
$ ./four_cc 
0x57494e45
~~~

Sorry for disturbing. 
I should set CFLAGS = "-Wno-multichar"

[Bug 40177] multicharacter constant warning in wineqtdecoder

https://bugs.winehq.org/show_bug.cgi?id=40177

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #3 from [e-mail] ---
So is this valid or invalid? You can yourself mark bugs closed. Not everyone
can do that.

[Bug 40177] multicharacter constant warning in wineqtdecoder

https://bugs.winehq.org/show_bug.cgi?id=40177

Sergey Isakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from Sergey Isakov  ---
> According to spec it must be (file, URL, pointer, or handle), not a character and >moreover not a multicharacter.

But it has reliable syntax.

[Bug 40177] multicharacter constant warning in wineqtdecoder

https://bugs.winehq.org/show_bug.cgi?id=40177

--- Comment #5 from Henri Verbeet  ---
(In reply to winetest from comment #3)
> So is this valid or invalid? You can yourself mark bugs closed. Not everyone
> can do that.

I think the warning is valid and these should use mmioFOURCC.

[Bug 40177] multicharacter constant warning in wineqtdecoder

https://bugs.winehq.org/show_bug.cgi?id=40177

Matteo Bruni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|RESOLVED                    |REOPENED
         Resolution|WORKSFORME                  |---

--- Comment #6 from Matteo Bruni  ---
(In reply to Henri Verbeet from comment #5)
> I think the warning is valid and these should use mmioFOURCC.

Same here.

[Bug 40177] multicharacter constant warning in wineqtdecoder

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=40177

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|REOPENED                    |NEW

--- Comment #7 from Anastasius Focht  ---
Hello folks,

obviously still present. I guess fixing this is too hard *pepega*.

https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/wineqtdecoder/qtsplit...

Regards