[Bug 52028] New: Regression: Themed contents doesn't displays correctly in some themes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52028

Bug ID: 52028
           Summary: Regression: Themed contents doesn't displays correctly
                    in some themes
           Product: Wine
           Version: 6.21
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comctl32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 71028
  --> https://bugs.winehq.org/attachment.cgi?id=71028
good vs bad

Regression test result:
7c9cacd47f969181624b2c5fafd7554188d7fa47 is the first bad commit
commit 7c9cacd47f969181624b2c5fafd7554188d7fa47
Author: Zhiyi Zhang 
Date:   Fri Nov 5 14:34:58 2021 +0800

comctl32/button: Correctly place parts for themed group boxes.

Signed-off-by: Zhiyi Zhang 
    Signed-off-by: Alexandre Julliard

dlls/comctl32/button.c | 49 +++++++++++++++++++++++++++----------------------
 1 file changed, 27 insertions(+), 22 deletions(-)

Procedure:
1 - Open winecfg
2 -- Apply a theme that presents this issue

I've used a modified theme from VLT by evgkursai. Original msstyles file
presents this issue too. You can download it here:
https://www.deviantart.com/evgkursai/art/VLT-2-0-VS-36103075

[Bug 52028] Regression: Themed contents doesn't displays correctly in some themes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52028

Josesk Volpe  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
       Distribution|---                         |ArchLinux
                 CC|                            |[e-mail]
    Regression SHA1|                            |7c9cacd47f969181624b2c5fafd
                   |                            |7554188d7fa47

[Bug 52028] Regression: Themed contents doesn't displays correctly in some themes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52028

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #1 from Zhiyi Zhang  ---
Confirmed. I will look into it.

[Bug 52028] Regression: Themed contents doesn't displays correctly in some themes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52028

--- Comment #2 from Zhiyi Zhang  ---
Created attachment 71053
  --> https://bugs.winehq.org/attachment.cgi?id=71053
fix

[Bug 52028] Regression: Themed contents doesn't displays correctly in some themes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52028

--- Comment #3 from Josesk Volpe  ---
¡Fix confirmed!

[Bug 52028] Regression: Themed contents doesn't displays correctly in some themes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52028

--- Comment #4 from Josesk Volpe  ---
That's kinda funny when patches are 1 line of code hehehe xD

[Bug 52028] Regression: Themed contents doesn't displays correctly in some themes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52028

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |438078d045c83499ec8a62441b2
                   |                            |b9fb14b1d4cea

--- Comment #5 from Zhiyi Zhang  ---
Fixed by 438078d045c83499ec8a62441b2b9fb14b1d4cea

[Bug 52028] Regression: Themed contents doesn't displays correctly in some themes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52028

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 6.23.

[Bug 52028] Themed contents don't display correctly in some themes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52028

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
            Summary|Regression: Themed contents |Themed contents don't
                   |doesn't displays correctly  |display correctly in some
                   |in some themes              |themes