https://bugs.winehq.org/show_bug.cgi?id=56429
Bug ID: 56429 Summary: Latest Steam repeatedly restarts when starting game or alt-tab, seems to be xinput2 related. Product: Wine Version: 9.4 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winex11.drv Assignee: wine-bugs@winehq.org Reporter: ikalvachev@gmail.com Regression SHA1: 0f1322d2df4c5238c601a2865b6e65ad14bfa26a Distribution: ---
Upgraded to latest wine-9.4 and Steam seemed to work fine. Then Steam upgraded itself and I couldn't launch games anymore.
When starting a game from withing steam library, the game launch begins normally. However steam window disappears and the console log bursts messages until a new window is opened. However this restart kills the started game.
I could reproduce the issue if I simply press ALT+TAB in Steam, however it doesn't trigger if I change focus with the mouse.
There are not crash reports winedbg starting. It restarts on its own.
I did a bisect and landed on: --- 0f1322d2df4c5238c601a2865b6e65ad14bfa26a winex11: Support XInput2 events on individual windows. --- Looking back into the log, before steam window opens, I can see a couple messages like: --- X Error of failed request: BadWindow (invalid Window parameter) Major opcode of failed request: 131 (XInputExtension) Minor opcode of failed request: 46 () Resource id in failed request: 0x80020e Serial number of failed request: 469 Current serial number in output stream: 491 --- These seems harmless, they appear before steam window is shown.
The following message appears when I trigger the issue with alt+tab: --- 06f8:fixme:winsock:setsockopt Ignoring SO_RANDOMIZE_PORT X Error of failed request: BadWindow (invalid Window parameter) Major opcode of failed request: 10 (X_UnmapWindow) Resource id in failed request: 0x2e00003 Serial number of failed request: 1098 Current serial number in output stream: 1099 06a0:fixme:kernelbase:AppPolicyGetProcessTerminationMethod FFFFFFFA, 0031FECC 0610:fixme:kernelbase:AppPolicyGetProcessTerminationMethod FFFFFFFA, 0031FECC 0024:fixme:file:GetLongPathNameW UNC pathname L"\\?\C:\Program Files\Steam\bin\cef\cef.win7\steamwebhelper.exe" 0024:fixme:file:GetLongPathNameW UNC pathname L"\\?\C:\Program Files\Steam\bin\cef\cef.win7\steamwebhelper.exe" ---
The issue happens only with the latest Steam client Restarts: --- Steam Beta Branch: Stable Client Steam Version 1709846872 Steam Client Build Date: Wed, Mar 6 10:31 PM UTC -08:00 Steam Web Build Date: Thu, Mar 7 11:17 PM UTC -08:00 Steam API Version: SteamClient021 ---
Since I keep snapshots of previous wine prefixes, I found out that this is the steam that Works: --- Steam Beta Branch: Stable Client Steam Version 1705108172 Steam Client Build Date: Sat, Jan 13 2:54 AM UTC -08:00 Steam Web Build Date: Fri, Jan 12 7:02 PM UTC -08:00 Steam API Version: SteamClient021 --
I'm using slackware-current X.Org X Server 1.21.1.11
Running `xinput --version` returns: --- xinput version 1.6.4 XI version on server: 2.4 ---
https://bugs.winehq.org/show_bug.cgi?id=56429
mrdeathjr28@yahoo.es changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mrdeathjr28@yahoo.es
https://bugs.winehq.org/show_bug.cgi?id=56429
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de
https://bugs.winehq.org/show_bug.cgi?id=56429
Rémi Bernon rbernon@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |rbernon@codeweavers.com
https://bugs.winehq.org/show_bug.cgi?id=56429
random-nick@mail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |random-nick@mail.com
--- Comment #1 from random-nick@mail.com --- I am also experiencing this bug and can confirm that commit is the first bad commit, and also that it affects the current master (7c5b9304a62b794ba07110e15eef6aec3a46ef0a) too.
I also discovered a way to reproduce this in a fresh prefix without having to install anything: 1. open taskmgr ("wine taskmgr" in terminal) 2. open another window, for example explorer (click New Task button, write explorer and press enter) 3. close the taskmgr window, which should cause the first BadWindow message to print 4. try to move the other window from step 2, which should cause that window to close and the second BadWindow message to print
https://bugs.winehq.org/show_bug.cgi?id=56429
--- Comment #2 from random-nick@mail.com --- Present in 9.6 and 9.7 too
I forgot add in my previous comment that the bug does not seem to happen when virtual desktop is enabled
https://bugs.winehq.org/show_bug.cgi?id=56429
--- Comment #3 from Ken Sharp imwellcushtymelike@gmail.com --- Does it work on Windows? The Steam client is plagued with bugs of its own.
https://bugs.winehq.org/show_bug.cgi?id=56429
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download
https://bugs.winehq.org/show_bug.cgi?id=56429
--- Comment #4 from random-nick@mail.com --- It's definitely a wine bug, if it was a steam bug there wouldn't be X errors, and besides, my reproduction steps in Comment 1 do not involve steam at all, but have the same X errors and have the same first bad commit
https://bugs.winehq.org/show_bug.cgi?id=56429
--- Comment #5 from random-nick@mail.com --- I did some testing with taskmgr on various desktop environments, under the assumption that this varies according to setup, and it seems that this might be a bug related to the systray. On DEs such as GNOME and Openbox where there is no systray (and so the wine systray is used) there are no X errors and it seems to work correctly. On most DEs I tested which have a systray (LXDE, LXQt, MATE, XFCE, Cinnamon on X11) the reproduction steps in Comment 1 work as is written. The only DE I tested with a systray where the they don't is KDE, but the first X error still shows up and it seems to break the systray for wine applications (e.g. if you have 2 taskmgrs and so 2 systray icons, when you trigger the bug by closing one taskmgr, both tray icons will disappear)
https://bugs.winehq.org/show_bug.cgi?id=56429
DarkOK dark@darkok.xyz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark@darkok.xyz
--- Comment #6 from DarkOK dark@darkok.xyz --- I can also reproduce the systray issue, and also came here from bisecting and hit the same XInput2 commit.
This is a huge issue for me since I frequently use programs that minimise to the tray, and this being broken makes me hardly able to use them as closing one program that's in the tray causes all the other icons to close, making the other programs inaccessible.
https://bugs.winehq.org/show_bug.cgi?id=56429
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Latest Steam repeatedly |Applications crash with |restarts when starting game |BadWindow X error |or alt-tab, seems to be | |xinput2 related. | Keywords| |source Status|UNCONFIRMED |NEW Ever confirmed|0 |1
--- Comment #7 from Ken Sharp imwellcushtymelike@gmail.com --- (In reply to random-nick from comment #4)
if it was a steam bug there wouldn't be X errors
That is 100% incorrect.
Confirming in Wine 9.7 using the steps in Comment #1.
Running in a Xephyr window also avoids the crash (in reference to Comment #5).
I would expect this to affect quite a lot of apps, so I guess we should keep an eye out for duplicates. Potentially major but we'll see how it goes.
NOTE: If you find your app is affected by this bug then simply link it in the AppDB.
https://bugs.winehq.org/show_bug.cgi?id=56429
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |idarktemplar@mail.ru
--- Comment #8 from Ken Sharp imwellcushtymelike@gmail.com --- *** Bug 56610 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=56429
Zeb Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com
--- Comment #9 from Zeb Figura z.figura12@gmail.com --- (In reply to Ken Sharp from comment #7)
(In reply to random-nick from comment #4)
if it was a steam bug there wouldn't be X errors
That is 100% incorrect.
What? Where are you getting that?
https://bugs.winehq.org/show_bug.cgi?id=56429
--- Comment #10 from Ken Sharp imwellcushtymelike@gmail.com --- After the first BadWindow, "explorer.exe /desktop" is the process that disappears. Attempting to start it again has no effect and it silently exits. Any background apps running (Quicktime's tray exe for example) continue to run.
"wineboot -s" doesn't do anything either, neither does "wineboot -e".
https://bugs.winehq.org/show_bug.cgi?id=56429
--- Comment #11 from Rémi Bernon rbernon@codeweavers.com --- This is probably the same thing as bug 56607 but I don't understand how the blamed commit can cause this X error. I'm not able to reproduce on GNOME so far, still looking into it.
https://bugs.winehq.org/show_bug.cgi?id=56429
--- Comment #12 from Rémi Bernon rbernon@codeweavers.com --- Created attachment 76399 --> https://bugs.winehq.org/attachment.cgi?id=76399 Possible fix
Can someone able to reproduce check whether this change helps?
https://bugs.winehq.org/show_bug.cgi?id=56429
--- Comment #13 from Ken Sharp imwellcushtymelike@gmail.com --- Tried the patch against current git and it doesn't make any difference. The crashes still occur in the same place. I'm using MATE, haven't tested another WM yet (though it also occurs in a Xephyr window with Marco and "effects" off).
https://bugs.winehq.org/show_bug.cgi?id=56429
--- Comment #14 from Ken Sharp imwellcushtymelike@gmail.com --- (In reply to Ken Sharp from comment #13)
(though it also occurs in a Xephyr window with Marco and "effects" off).
The opposite is true: it does NOT occur in a Xephyr window, as I said previously (oops).
https://bugs.winehq.org/show_bug.cgi?id=56429
--- Comment #15 from Ken Sharp imwellcushtymelike@gmail.com --- Created attachment 76402 --> https://bugs.winehq.org/attachment.cgi?id=76402 Console output
https://bugs.winehq.org/show_bug.cgi?id=56429
--- Comment #16 from Rémi Bernon rbernon@codeweavers.com --- I believe I found the culprit change. https://gitlab.winehq.org/wine/wine/-/merge_requests/5575 should hopefully fix the crash.
https://bugs.winehq.org/show_bug.cgi?id=56429
--- Comment #17 from random-nick@mail.com --- (In reply to Rémi Bernon from comment #16)
https://gitlab.winehq.org/wine/wine/-/merge_requests/5575 should hopefully fix the crash.
That fixes it for me (I haven't tested other DEs, only my main setup)
https://bugs.winehq.org/show_bug.cgi?id=56429
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |749574a298b43584e0a79557791 | |58aa3ab767a08 Status|NEW |RESOLVED
--- Comment #18 from Ken Sharp imwellcushtymelike@gmail.com --- Looks good here too. Lovely.
https://bugs.winehq.org/show_bug.cgi?id=56429
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #19 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 9.9.