[Bug 15694] New: LEGO Star Wars sounds not playing

http://bugs.winehq.org/show_bug.cgi?id=15694

Summary: LEGO Star Wars sounds not playing
           Product: Wine
           Version: 1.1.6
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: directx-dsound
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

There's a regression in wine 1.1.6 (from 1.1.5 where everything works) which
causes sound effects (footsteps, lasers, collecting stuff) in the games "LEGO
Star Wars" and "LEGO Star Wars II" not to play. Music etc still works fine.

[Bug 15694] LEGO Star Wars sounds not playing

http://bugs.winehq.org/show_bug.cgi?id=15694

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #1 from Austin English   2008-10-20 14:18:57 ---
Probably a dupe of bug 15559.

[Bug 15694] LEGO Star Wars sounds not playing

http://bugs.winehq.org/show_bug.cgi?id=15694

Andy Wettstein  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #2 from Andy Wettstein   2008-10-20 20:16:01 ---
Did a regression test and got this:

5d24cb456565e4a00429248cf5f70453687b8f16 is first bad commit
commit 5d24cb456565e4a00429248cf5f70453687b8f16
Author: Dmitry Timoshkov 
Date:   Fri Oct 10 12:27:45 2008 +0900

winmm: The buffer provided by an application is valid only in the
mmioOpen(FOURCC_MEM) case.

:040000 040000 9435571cdecb720912b87ad9846c64170f474458
c8480496db02163e24a2e4b0bc2e2f92b0e1548a M dlls

I don't that is a dupe of 15559.

[Bug 15694] LEGO Star Wars sounds not playing

http://bugs.winehq.org/show_bug.cgi?id=15694

--- Comment #3 from Austin English   2008-10-20 20:50:26 ---
A +winmm,+mmio trace would be useful.

[Bug 15694] LEGO Star Wars sounds not playing

http://bugs.winehq.org/show_bug.cgi?id=15694

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-dsound              |winmm&mci

--- Comment #4 from Dmitry Timoshkov   2008-10-20 20:56:23 ---
Is there a demo of this application available?

[Bug 15694] LEGO Star Wars sounds not playing

http://bugs.winehq.org/show_bug.cgi?id=15694

--- Comment #5 from Andy Wettstein   2008-10-20 21:33:15 ---
(In reply to comment #4)
> Is there a demo of this application available?

There is a demo for Lego Star Wars II, but I think at one point in time the
demo had sound working while the full version didn't.  So there may or may not
be a problem with the demo.

I'll try and get the traces done.

[Bug 15694] LEGO Star Wars sounds not playing

http://bugs.winehq.org/show_bug.cgi?id=15694

--- Comment #6 from Andy Wettstein   2008-10-20 21:42:41 ---
Created an attachment (id=16766)
 --> (http://bugs.winehq.org/attachment.cgi?id=16766)
+winmm,+mmio trace

Here is the trace requested.

[Bug 15694] LEGO Star Wars sounds not playing

http://bugs.winehq.org/show_bug.cgi?id=15694

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #7 from Dmitry Timoshkov   2008-10-20 21:50:58 ---
Could you please generate the same log with the offending patch reverted?

[Bug 15694] LEGO Star Wars sounds not playing

http://bugs.winehq.org/show_bug.cgi?id=15694

--- Comment #8 from Dmitry Timoshkov   2008-10-20 22:23:24 ---
Created an attachment (id=16767)
 --> (http://bugs.winehq.org/attachment.cgi?id=16767)
MMIO_ALLOCBUF should be ignored in the case of FOURCC_MEM

Does the attached patch help?

[Bug 15694] LEGO Star Wars sounds not playing

http://bugs.winehq.org/show_bug.cgi?id=15694

--- Comment #9 from Andy Wettstein   2008-10-20 22:26:08 ---
Created an attachment (id=16768)
 --> (http://bugs.winehq.org/attachment.cgi?id=16768)
working +winmm,+mmio trace

reverted that patch on release version of 1.1.6.  Sound effects are working
fine.

[Bug 15694] LEGO Star Wars sounds not playing

http://bugs.winehq.org/show_bug.cgi?id=15694

--- Comment #10 from Andy Wettstein   2008-10-20 22:41:37 ---
(In reply to comment #8)
> Created an attachment (id=16767)

--> (http://bugs.winehq.org/attachment.cgi?id=16767) [details]
> MMIO_ALLOCBUF should be ignored in the case of FOURCC_MEM
>
> Does the attached patch help?

Yes, that patch seems to get sound effects working ok for me on 1.1.6.

[Bug 15694] LEGO Star Wars sounds not playing

http://bugs.winehq.org/show_bug.cgi?id=15694

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 15694] LEGO Star Wars sounds not playing

http://bugs.winehq.org/show_bug.cgi?id=15694

--- Comment #11 from Dmitry Timoshkov   2008-10-21 05:29:55 ---
After more testing I sent slightly different patch:
http://www.winehq.org/pipermail/wine-patches/2008-October/063565.html

[Bug 15694] LEGO Star Wars sounds not playing

http://bugs.winehq.org/show_bug.cgi?id=15694

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Dmitry Timoshkov   2008-10-21 08:16:37 ---
The patch has been committed.

[Bug 15694] LEGO Star Wars sounds not playing

http://bugs.winehq.org/show_bug.cgi?id=15694

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard   2008-10-24 11:14:16 ---
Closing bugs fixed in 1.1.7.