[Bug 46549] New: PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

Bug ID: 46549
           Summary: PUBG Lite Launcher crash
           Product: Wine-staging
           Version: 4.0
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail]
      Distribution: ---

Created attachment 63418
  --> https://bugs.winehq.org/attachment.cgi?id=63418
PUBG Lite Log with vcrun2017 installed with winetricks

PUBG Lite launcher causes some errors when it runs, the prefix is 64-bit,
Windows 7, and I installed the .NET Framework 4.7.1 with Winetricks, when I run
the launcher without vcrun2017 the launcher opens but an error message appears
(Visual C++ Runtime error), then with vcrun2017 (installed with Winetricks) the
wine closes with an error message. Its possible easily reproduce this error by
using the PUBG Lite installer in Lutris created by me.

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #1 from Esdras Tarsis  ---
Created attachment 63419
  --> https://bugs.winehq.org/attachment.cgi?id=63419
PUBG Lite Log without vcrun2017

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |-unknown
            Product|Wine-staging                |Wine

--- Comment #2 from Alistair Leslie-Hughes  ---
Moving to wine, as wine-staging doesn't have any patches in this area.

At a guess the cause is
0063:fixme:combase:RoGetActivationFactory
(L"Windows.Foundation.Diagnostics.AsyncCausalityTracer",
{50850b26-267e-451b-a890-ab6a370245ee}, 0x53dd58): semi-stub
0063:err:combase:RoGetActivationFactory Failed to find library for
L"Windows.Foundation.Diagnostics.AsyncCausalityTracer".

Does installing .NET help?

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #3 from Zebediah Figura  ---
Interesting. I guess the difference is attributable to our missing
implementation of __CxxExceptionFilter on x86_64, so maybe the crash is due to
code after that that should not run.

The most interesting thing that happens in the log before the exception is
thrown seems to be a call to HttpCreateServerSession(), which is unimplemented
in Wine. It may be worth trying to return success and see if that helps, though
it may take extended debugging as other parts of httpapi are used.

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #4 from Esdras Tarsis  ---
(In reply to Zebediah Figura from comment #3)
> Interesting. I guess the difference is attributable to our missing
> implementation of __CxxExceptionFilter on x86_64, so maybe the crash is due
> to code after that that should not run.
>
> The most interesting thing that happens in the log before the exception is
> thrown seems to be a call to HttpCreateServerSession(), which is
> unimplemented in Wine. It may be worth trying to return success and see if
> that helps, though it may take extended debugging as other parts of httpapi
> are used.

Is there any chance of fixing this by releasing a wine-staging patch?

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #5 from Esdras Tarsis  ---
(In reply to Alistair Leslie-Hughes from comment #2)
> Moving to wine, as wine-staging doesn't have any patches in this area.
>
> At a guess the cause is
> 0063:fixme:combase:RoGetActivationFactory
> (L"Windows.Foundation.Diagnostics.AsyncCausalityTracer",
> {50850b26-267e-451b-a890-ab6a370245ee}, 0x53dd58): semi-stub
> 0063:err:combase:RoGetActivationFactory Failed to find library for
> L"Windows.Foundation.Diagnostics.AsyncCausalityTracer".
>
> Does installing .NET help?

I installed dotnet452, dotnet471, dotnet472 with Winetricks and had the same
error.

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #6 from Alistair Leslie-Hughes  ---
I've added a patch to wine-staging to return success from
HttpCreateServerSession which might fix the issue.

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

pattietreutel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #7 from Esdras Tarsis  ---
(In reply to Alistair Leslie-Hughes from comment #6)
> I've added a patch to wine-staging to return success from
> HttpCreateServerSession which might fix the issue.

It seems not to have solved, this is the return of HttpCreateServerSession()
with the patch: 0009: fixme: httpapi: HttpCreateServerSession ({2,0}, 0x22d2c8,
0): stub!

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #8 from Zebediah Figura  ---
(In reply to Esdras Tarsis from comment #7)
> (In reply to Alistair Leslie-Hughes from comment #6)
> > I've added a patch to wine-staging to return success from
> > HttpCreateServerSession which might fix the issue.
>
> It seems not to have solved, this is the return of HttpCreateServerSession()
> with the patch: 0009: fixme: httpapi: HttpCreateServerSession ({2,0},
> 0x22d2c8, 0): stub!

Can you please attach the whole terminal output with the patch?

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #9 from Esdras Tarsis  ---
(In reply to Zebediah Figura from comment #8)
> (In reply to Esdras Tarsis from comment #7)
> > (In reply to Alistair Leslie-Hughes from comment #6)
> > > I've added a patch to wine-staging to return success from
> > > HttpCreateServerSession which might fix the issue.
> >
> > It seems not to have solved, this is the return of HttpCreateServerSession()
> > with the patch: 0009: fixme: httpapi: HttpCreateServerSession ({2,0},
> > 0x22d2c8, 0): stub!
>
> Can you please attach the whole terminal output with the patch?

Same error

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |httpapi

--- Comment #10 from Zebediah Figura  ---
It subsequently tries to pass the request queue handle to
CreateIoCompletionPort().

I think this is going to need a proper implementation of httpapi.

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |https://lite.pubg.com/en/

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Louis Lenders  ---
The httpapi spec file seems quite outdated. 
After the staging patch faking success for CreateServerSession it seems to look
for other functions (something like "could not find entrypoint" in a debuglog)
, I updated the spec file.

Then:
0041:fixme:seh:RtlCaptureStackBackTrace (1, 3, 0x1b4f07a0, (nil)) stub!
0041:fixme:httpapi:HttpInitialize ({2,0}, 0x5, (nil)): stub!
0041:fixme:httpapi:HttpCreateServerSession ({2,0}, 0x22d1e8, 0): stub!
wine: Call from 0x7b497f56 to unimplemented function
httpapi.dll.HttpCreateUrlGroup, aborting
0041:fixme:httpapi:HttpCloseServerSession (abcdefff): stub!
wine: Call from 0x7b497f56 to unimplemented function
httpapi.dll.HttpCreateUrlGroup, aborting
0041:fixme:seh:call_stack_handlers nested exception
winedbg --auto 64 128

I added stubs for two unimplemented functions it runs into, now arrived at:

wine: Call from 0x7b497f56 to unimplemented function
httpapi.dll.HttpCloseUrlGroup, aborting

Will continue tomorrow (tired)to add stubs, see how far i can get...

Attach hereafter the patches up to now.

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #12 from Louis Lenders  ---
Created attachment 63998
  --> https://bugs.winehq.org/attachment.cgi?id=63998
1

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #13 from Louis Lenders  ---
Created attachment 63999
  --> https://bugs.winehq.org/attachment.cgi?id=63999
2

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #14 from Louis Lenders  ---
Created attachment 64000
  --> https://bugs.winehq.org/attachment.cgi?id=64000
3

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #15 from Esdras Tarsis  ---
(In reply to Louis Lenders from comment #11)
> The httpapi spec file seems quite outdated. 
> After the staging patch faking success for CreateServerSession it seems to
> look for other functions (something like "could not find entrypoint" in a
> debuglog) , I updated the spec file.
>
> Then:
> 0041:fixme:seh:RtlCaptureStackBackTrace (1, 3, 0x1b4f07a0, (nil)) stub!
> 0041:fixme:httpapi:HttpInitialize ({2,0}, 0x5, (nil)): stub!
> 0041:fixme:httpapi:HttpCreateServerSession ({2,0}, 0x22d1e8, 0): stub!
> wine: Call from 0x7b497f56 to unimplemented function
> httpapi.dll.HttpCreateUrlGroup, aborting
> 0041:fixme:httpapi:HttpCloseServerSession (abcdefff): stub!
> wine: Call from 0x7b497f56 to unimplemented function
> httpapi.dll.HttpCreateUrlGroup, aborting
> 0041:fixme:seh:call_stack_handlers nested exception
> winedbg --auto 64 128
>
> I added stubs for two unimplemented functions it runs into, now arrived at:
>
> wine: Call from 0x7b497f56 to unimplemented function
> httpapi.dll.HttpCloseUrlGroup, aborting
>
> Will continue tomorrow (tired)to add stubs, see how far i can get...
>
> Attach hereafter the patches up to now.

I made the stdcalls for the httpapi that the Launcher needs, here in this link
in Github:
https://github.com/EsdrasTarsis/wine-pubglite/tree/wine-pubglite-4.4/dlls/ht...

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #16 from Louis Lenders  ---
> > Attach hereafter the patches up to now.
>
> I made the stdcalls for the httpapi that the Launcher needs, here in this
> link in Github:
> https://github.com/EsdrasTarsis/wine-pubglite/tree/wine-pubglite-4.4/dlls/
> httpapi

Ah ok, didn`t know that, and how far do you get with these?

And what about sending them to the patches list?

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #17 from Esdras Tarsis  ---
(In reply to Louis Lenders from comment #16)
> > > Attach hereafter the patches up to now.
> >
> > I made the stdcalls for the httpapi that the Launcher needs, here in this
> > link in Github:
> > https://github.com/EsdrasTarsis/wine-pubglite/tree/wine-pubglite-4.4/dlls/
> > httpapi
>
> Ah ok, didn`t know that, and how far do you get with these?
>
> And what about sending them to the patches list?

I plan to publish these patches soon, as Zebediah said, you need a more
complete implementation of httpapi, because even with the stdcalls, the
launcher can not open because of the handle problem

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #18 from Louis Lenders  ---
> I plan to publish these patches soon, as Zebediah said, you need a more
> complete implementation of httpapi, because even with the stdcalls, the
> launcher can not open because of the handle problem

Ok, please do so.

I found another app reported on the forum that needs this
(https://support.seesnake.com/hq-for-pcs/   /
https://forum.winehq.org/viewtopic.php?f=8&t=32177 )

The patches are enough to make the installer succeed, so even if they are not
enough to get this PUBG Lite app running, they will help other apps apparently.

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #19 from Esdras Tarsis  ---
(In reply to Louis Lenders from comment #18)
> > I plan to publish these patches soon, as Zebediah said, you need a more
> > complete implementation of httpapi, because even with the stdcalls, the
> > launcher can not open because of the handle problem
>
> Ok, please do so.
>
> I found another app reported on the forum that needs this
> (https://support.seesnake.com/hq-for-pcs/   /
> https://forum.winehq.org/viewtopic.php?f=8&t=32177 )
>
> The patches are enough to make the installer succeed, so even if they are
> not enough to get this PUBG Lite app running, they will help other apps
> apparently.

Exactly, there are many programs that need the Windows Http API to work, I'm
willing to help in implementing the embedded httpapi of Wine, but I do not know
where to start. :c

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #20 from Zebediah Figura  ---
Version 1 request queues created with HttpCreateHttpHandle() are to be closed
with CloseHandle(), which complicates this somewhat. It'll probably need
implementation in a pseudo-kernel driver. On Windows this seems to be http.sys.

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #21 from Esdras Tarsis  ---
Created attachment 64050
  --> https://bugs.winehq.org/attachment.cgi?id=64050
HttpCreateUrlGroup Patch

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #22 from Esdras Tarsis  ---
Created attachment 64051
  --> https://bugs.winehq.org/attachment.cgi?id=64051
HttpCloseUrlGroup Patch

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #23 from Esdras Tarsis  ---
Created attachment 64052
  --> https://bugs.winehq.org/attachment.cgi?id=64052
HttpCreateRequestQueue Patch

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #24 from Esdras Tarsis  ---
Created attachment 64053
  --> https://bugs.winehq.org/attachment.cgi?id=64053
HttpSetUrlGroupProperty Patch

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #25 from Esdras Tarsis  ---
Created attachment 64054
  --> https://bugs.winehq.org/attachment.cgi?id=64054
HttpAddUrlToUrlGroup Patch

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #26 from Esdras Tarsis  ---
Created attachment 64055
  --> https://bugs.winehq.org/attachment.cgi?id=64055
Wine Log with patches

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #27 from Esdras Tarsis  ---
Created attachment 64056
  --> https://bugs.winehq.org/attachment.cgi?id=64056
Launcher log running with patched Wine

[Bug 46549] PUBG Lite Launcher crash

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #28 from Esdras Tarsis  ---
I was able to get interesting results with these patches that I made, they
should work alongside the patch that is in Wine Staging
(0001-httpapi-Fake-success-from-HttpCreateServerSession.patch)

[Bug 46549] Multiple .NET 4.x applications and games using ' System.Net.HttpListener' class crash due incomplete httpapi implementation (PUBG Lite Launcher, SeeSnake HQ)

https://bugs.winehq.org/show_bug.cgi?id=46549

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|PUBG Lite Launcher crash    |Multiple .NET 4.x
                   |                            |applications and games
                   |                            |using
                   |                            |'System.Net.HttpListener'
                   |                            |class crash due incomplete
                   |                            |httpapi implementation
                   |                            |(PUBG Lite Launcher,
                   |                            |SeeSnake HQ)
                URL|https://lite.pubg.com/en/   |https://web.archive.org/web
                   |                            |/20190331111653/https://lpc
                   |                            |-dl.playbattlegrounds.com/i
                   |                            |nstaller/PUBG-Lite-Setup.ex
                   |                            |e

--- Comment #29 from Anastasius Focht  ---
Hello folks,

refining summary, although I don't recommend component meta-bugs. They tend to
be messy in the end. People will chime in with other apps/games, requiring
different API implementation sets (helps one app, doesn't help/harms the other,
comments "still not fixed for <insert other app>" etc., preventing closure).

Be aware this is not a simple thing a la "cheat with some semi-stubs". To put
into perspective what is required have a look how 'httpapi' is used:

MS .NET Framework 4.7.2 Reference Source: 'System.Net.HttpListener' class which
uses 'httpapi':

https://github.com/Microsoft/referencesource/blob/master/System/net/System/N...

The CoreFx implementation (a bit different on internals due to cross-platform
constraints):

https://github.com/dotnet/corefx/blob/master/src/System.Net.HttpListener/src...

---

I've created a stable snapshot of the installer via Internet Archive in case
they change their mind and use different API.

https://web.archive.org/web/20190331111653/https://lpc-dl.playbattlegrounds....

Regards

[Bug 46549] Multiple .NET 4.x applications and games using ' System.Net.HttpListener' class crash due incomplete httpapi implementation (PUBG Lite Launcher, SeeSnake HQ)

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #30 from Zebediah Figura  ---
(In reply to Anastasius Focht from comment #29)
> refining summary, although I don't recommend component meta-bugs. They tend
> to be messy in the end. People will chime in with other apps/games,
> requiring different API implementation sets (helps one app, doesn't
> help/harms the other, comments "still not fixed for <insert other app>"
> etc., preventing closure).

Sure, so perhaps it's best to limit this to the PUBG launcher.

[Bug 46549] Multiple .NET 4.x applications and games using ' System.Net.HttpListener' class crash due incomplete httpapi implementation (PUBG Lite Launcher, SeeSnake HQ)

https://bugs.winehq.org/show_bug.cgi?id=46549

Erikas  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 46549] Multiple .NET 4.x applications and games using ' System.Net.HttpListener' class crash due incomplete httpapi implementation (PUBG Lite Launcher, SeeSnake HQ)

https://bugs.winehq.org/show_bug.cgi?id=46549

Suson Waiba  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #31 from Suson Waiba  ---
Will game run if patched
(https://github.com/wine-staging/wine-staging/tree/master/patches/httpapi-Htt...)
are installed for wine-staging ??

[Bug 46549] Multiple .NET 4.x applications and games using ' System.Net.HttpListener' class crash due incomplete httpapi implementation (PUBG Lite Launcher, SeeSnake HQ)

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #32 from Zebediah Figura  ---
(In reply to Suson Waiba from comment #31)
> Will game run if patched
> (https://github.com/wine-staging/wine-staging/tree/master/patches/httpapi-
> HttpCreateServerSession) are installed for wine-staging ??

No, the game will not run with the linked wine-staging patch.

[Bug 46549] Multiple .NET 4.x applications and games using ' System.Net.HttpListener' class crash due incomplete httpapi implementation (PUBG Lite Launcher, SeeSnake HQ)

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #33 from Esdras Tarsis  ---
I would like to give feedback on this new patchset with the implementation of
httpapi version 2 (by Zebediah Figura), the launcher works perfectly now, but
the game does not open.

[Bug 46549] Multiple .NET 4.x applications and games using ' System.Net.HttpListener' class crash due incomplete httpapi implementation (PUBG Lite Launcher, SeeSnake HQ)

https://bugs.winehq.org/show_bug.cgi?id=46549

Esdras Tarsis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63418|0                           |1
        is obsolete|                            |
  Attachment #63419|0                           |1
        is obsolete|                            |
  Attachment #64055|0                           |1
        is obsolete|                            |
  Attachment #64056|0                           |1
        is obsolete|                            |

--- Comment #34 from Esdras Tarsis  ---
Created attachment 65165
  --> https://bugs.winehq.org/attachment.cgi?id=65165
Wine Log with ZF httpapi implementation

[Bug 46549] Multiple .NET 4.x applications and games using ' System.Net.HttpListener' class crash due incomplete httpapi implementation (PUBG Lite Launcher, SeeSnake HQ)

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #35 from Zebediah Figura  ---
(In reply to Esdras Tarsis from comment #33)
> I would like to give feedback on this new patchset with the implementation
> of httpapi version 2 (by Zebediah Figura), the launcher works perfectly now,
> but the game does not open.

Could you please file a new bug for this, and attach a trace with
warn+all,+seh,+pid,+loaddll,+debugstr?

[Bug 46549] Multiple .NET 4.x applications and games using ' System.Net.HttpListener' class crash due incomplete httpapi implementation (PUBG Lite Launcher, SeeSnake HQ)

https://bugs.winehq.org/show_bug.cgi?id=46549

--- Comment #36 from Esdras Tarsis  ---
(In reply to Zebediah Figura from comment #35)
> (In reply to Esdras Tarsis from comment #33)
> > I would like to give feedback on this new patchset with the implementation
> > of httpapi version 2 (by Zebediah Figura), the launcher works perfectly now,
> > but the game does not open.
>
> Could you please file a new bug for this, and attach a trace with
> warn+all,+seh,+pid,+loaddll,+debugstr?

Sure.

[Bug 46549] Multiple .NET 4.x applications and games using ' System.Net.HttpListener' class crash due incomplete httpapi implementation (PUBG Lite Launcher, SeeSnake HQ)

https://bugs.winehq.org/show_bug.cgi?id=46549

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |b19f4488f6d73e5c4ebdeee4484
                   |                            |5c54832477ecb

--- Comment #37 from Zebediah Figura  ---
Closing this bug then as basic httpapi functionality is implemented. Please
open new reports for further bugs in httpapi or in the applications mentioned
here.

[Bug 46549] Multiple .NET 4.x applications and games using 'System.Net.HttpListener' class crash due incomplete httpapi implementation (PUBG Lite Launcher, SeeSnake HQ)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46549

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #38 from Alexandre Julliard  ---
Closing bugs fixed in 4.16.