http://bugs.winehq.org/show_bug.cgi?id=26556
Summary: StarCraft2 Editor: Icons in treeview are transparent Product: Wine Version: 1.3.16 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: chris.kde@gmail.com
Created an attachment (id=33817) --> (http://bugs.winehq.org/attachment.cgi?id=33817) screenshot
Icons in treeview are not painted or are transparents. It looks like they are loaded from an ImageList.
At application start up, icons are painted normally, I load a map, icons are painted normally too, but from this moment, icons will be transparents if they need to be repainted (if I scroll for example).
Bug video: http://www.youtube.com/watch?v=_BimUwJoMXg and screenshot as attachment.
http://bugs.winehq.org/show_bug.cgi?id=26556
Chris chris.kde@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|StarCraft2 Editor: Icons in |StarCraft2 Editor: Icons in |treeview are transparent |treeview are transparents
http://bugs.winehq.org/show_bug.cgi?id=26556
Chris chris.kde@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #1 from Chris chris.kde@gmail.com 2011-07-22 17:28:22 CDT --- fixed in 1.3.24
http://bugs.winehq.org/show_bug.cgi?id=26556
Florian florian@fkoeberle.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |florian@fkoeberle.de
--- Comment #2 from Florian florian@fkoeberle.de 2011-07-23 03:27:02 CDT --- It's not fixed for me in neither 1.3.24 nor 1.3.25. For me the icons stop getting painted once I add for example an action to the tree of a trigger.
I also noticed that the icons of the Data Editor Tabs don't get redrawn after a certain point as well.
http://bugs.winehq.org/show_bug.cgi?id=26556
Chris chris.kde@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED |
--- Comment #3 from Chris chris.kde@gmail.com 2011-07-31 16:11:25 CDT --- You are right. Steps to reproduce the bug have changed, my video is now useless but I can do another one if need.
Now icons are painted normally even if we scroll. If we add or delete an item in the triggers treeview everything still ok. To reproduce the bug, a trigger must be edited by adding an item to his treeview. By doing this, icons for all treeviews become transparent.
http://bugs.winehq.org/show_bug.cgi?id=26556
Chris chris.kde@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|1.3.16 |1.3.25
http://bugs.winehq.org/show_bug.cgi?id=26556
Chris chris.kde@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #4 from Chris chris.kde@gmail.com 2011-07-31 16:14:04 CDT --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=26556
--- Comment #5 from Nikolay Sivov bunglehead@gmail.com 2011-07-31 16:17:25 CDT --- Did you ever try native comctl32? Can I get this application legally and for free somewhere?
http://bugs.winehq.org/show_bug.cgi?id=26556
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|1.3.25 |1.3.24
http://bugs.winehq.org/show_bug.cgi?id=26556
--- Comment #6 from Chris chris.kde@gmail.com 2011-07-31 17:04:29 CDT --- Created an attachment (id=35762) --> (http://bugs.winehq.org/attachment.cgi?id=35762) with native comctl32
With native comctl32 it's better, icons don't become transparent, thanks for the advice.
But the black color for some icons is transparent (see attachement and here http://img405.imageshack.us/img405/1691/maink.jpg to compare, in particular "Local Variables"). Anyway, at this state the black color will be a comfort. It's less critical because now we can distinguish icons type and it's very important to be able to do that.
You can get the game for free with a trial key, but I don't know if the editor is also available. If this is the case, I am sure we will be able to find a trial key for you. I will try to get more information on that.
http://bugs.winehq.org/show_bug.cgi?id=26556
--- Comment #7 from Nikolay Sivov bunglehead@gmail.com 2011-08-01 06:42:56 CDT --- (In reply to comment #6)
But the black color for some icons is transparent (see attachement and here http://img405.imageshack.us/img405/1691/maink.jpg to compare, in particular "Local Variables"). Anyway, at this state the black color will be a comfort. It's less critical because now we can distinguish icons type and it's very important to be able to do that.
It's a know problem with native comctl32. Masks or something is getting wrong with, it's ok.
http://bugs.winehq.org/show_bug.cgi?id=26556
--- Comment #8 from Florian florian@fkoeberle.de 2011-08-03 05:02:08 CDT --- I analysed the bug a bit more and found out, that: 1.) It's enough to close the dialog which could be used for adding actions, to make all icons vanish. It doesn't matter if you add an action or not. 2.) Closing the dialog for adding conditions to a trigger makes all icons vanish too. 3.) Adding local variables to a trigger works (it's a node too) without triggering the icon bug. It's propably because no dialog opens when you add a variable. 4.) If icons vanish, they vanish for all editor windows and not just for tree views, but the tabs of the data editor loose their icon then too. 5.) If icons vanish they do so for other windows not instantly, but only when the window needs to redraw itself. 6.) If you close in the data editor a dialog for adding and removing validators, then the icons vanish too. Like with the action add dialog it doesn't matter if you actually add or remove validators. 7.) It's the closing and not the opening of the dialogs which makes the icons vanish: I opened the validator add/remove dialog and then switched to the trigger window and the icons got there properly redrawn until I closed the validator add/remove dialog.
The dialogs for adding actions, conditions and validators have in common they contain one or more listviews. Even if none of the listviews shows actually icons(at least with wine).
So my current guess is that somehow the listview releases the icon list when it gets destroyed while it gets still used by other dialogs. This evening I want to do some traces to find out if my guess is right.
http://bugs.winehq.org/show_bug.cgi?id=26556
--- Comment #9 from Florian florian@fkoeberle.de 2011-08-03 17:05:58 CDT --- I send a test and patch to wine-patches: http://source.winehq.org/patches/data/77332 http://source.winehq.org/patches/data/77333
Maybe someone can add the keywords "patch" and "testcase" and change the component to comctl32.
A free demo of Starcraft 2 can be downloaded at: https://us.battle.net/account/sc2/starter-edition/
I think it also contains the editor but I am not 100% sure.
Now the main bug of the editor is the really bad performance of tree and listviews. I filled in bug 27973 about it.
http://bugs.winehq.org/show_bug.cgi?id=26556
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch Component|-unknown |comctl32
--- Comment #10 from Nikolay Sivov bunglehead@gmail.com 2011-08-03 17:21:12 CDT --- Patches look fine, thanks.
http://bugs.winehq.org/show_bug.cgi?id=26556
--- Comment #11 from Florian florian@fkoeberle.de 2011-08-04 15:29:17 CDT --- The patches got accepted: http://source.winehq.org/git/wine.git/commit/e68b9f9fc9ccfc59f4972582b067d87...
http://bugs.winehq.org/show_bug.cgi?id=26556
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #12 from Austin English austinenglish@gmail.com 2011-08-04 16:46:41 CDT --- (In reply to comment #11)
The patches got accepted: http://source.winehq.org/git/wine.git/commit/e68b9f9fc9ccfc59f4972582b067d87...
Fixed.
http://bugs.winehq.org/show_bug.cgi?id=26556
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #13 from Alexandre Julliard julliard@winehq.org 2011-08-05 12:38:55 CDT --- Closing bugs fixed in 1.3.26.
http://bugs.winehq.org/show_bug.cgi?id=26556
--- Comment #14 from Florian florian@fkoeberle.de 2011-11-01 08:19:08 CDT --- Chris or someone with the permission: Can you set "Fixed by SHA1" to e68b9f9fc9ccfc59f4972582b067d87e509c12de ?
http://bugs.winehq.org/show_bug.cgi?id=26556
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |e68b9f9fc9ccfc59f4972582b06 | |7d87e509c12de CC| |00cpxxx@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=26556
--- Comment #15 from Florian florian@fkoeberle.de 2011-11-01 08:53:16 CDT --- Thanks
-
wine-bugs＠winehq.org