[Bug 33550] New: Can't select there's only one item in TreeView if canceled TVN_BEGINLABELEDIT.

http://bugs.winehq.org/show_bug.cgi?id=33550

Bug #: 33550
           Summary: Can't select there's only one item in TreeView if
                    canceled TVN_BEGINLABELEDIT.
           Product: Wine
           Version: 1.5.29
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 44406
  --> http://bugs.winehq.org/attachment.cgi?id=44406
WINEDEBUG=+message wine ~/.wine/drive_c/Program\ Files/PremiumSoft/Navicat\
for\ SQL\ Server/navicat.exe 2>&1 | grep -E WM_NOTIFY|TVN_ > out.txt

In a TreeView control, if the following conditions holds:
1. There's only one item in the tree.
2. The control has bit TVS_EDITLABELS (=0x0008) set in dwExStyle.
3. Returned TRUE when receiving TVN_BEGINLABELEDIT.
The item will never be selected, at least never drawn as selected.

This happens in a database tool Navicat. Try this to reproduce the bug:
1. Download and install Navicat for Sql Server 10.0.0.3 Trail at
http://www.download3k.com/Install-Navicat-The-World-s-best-SQL-Server-GUI-to...
2. Open Navicat, create the only one connection, fill anything in config
dialog, no need to be a real sql server.
3. Try do label-editing on item in the TreeView, by click twice (seperated, not
double-click) on the item. In fact there will be no label-editing, doing this
is to trigger a TVN_BEGINLABELEDIT message.
4. The item will lose selection and will never be selected again.
vim o
hvs@hvsgentoo ~/Desktop $ sha1sum ~/Downloads/navicat100_sqlserver_en.exe 
6236f7a402985aeb3d94fa6f86805af8976c2ee8

Return value on TVN_BEGINLABELEDIT is descripted here
http://msdn.microsoft.com/en-us/library/windows/desktop/bb773506(v=vs.85).as...

[Bug 33550] Can't select there's only one item in TreeView if canceled TVN_BEGINLABELEDIT.

http://bugs.winehq.org/show_bug.cgi?id=33550

--- Comment #1 from Guo Jian  2013-05-09 07:51:36 CDT ---
Created attachment 44407
  --> http://bugs.winehq.org/attachment.cgi?id=44407
A demo with a TreeView like that in navicat10.0 that reflects the problem.

[Bug 33550] Can't select there's only one item in TreeView if canceled TVN_BEGINLABELEDIT.

http://bugs.winehq.org/show_bug.cgi?id=33550

--- Comment #2 from Nikolay Sivov  2013-05-09 09:38:56 CDT ---
Could you attach sources too?

[Bug 33550] Can't select there's only one item in TreeView if canceled TVN_BEGINLABELEDIT.

http://bugs.winehq.org/show_bug.cgi?id=33550

--- Comment #3 from Guo Jian  2013-05-09 11:03:29 CDT ---
Created attachment 44411
  --> http://bugs.winehq.org/attachment.cgi?id=44411
source for the demo.

(In reply to comment #2)
> Could you attach sources too?

Sorry, I forgot that. I wrote it to compile with vc6, do you think it necessary
that I convert it to wine's tests in comctl32? It may be just a small bug in
drawing.

[Bug 33550] Can't select there's only one item in TreeView if canceled TVN_BEGINLABELEDIT.

http://bugs.winehq.org/show_bug.cgi?id=33550

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Severity|normal                      |minor

--- Comment #4 from Nikolay Sivov  2013-05-09 11:13:14 CDT ---
No, no need for automated test for that, I'm testing it right now and it seems
to me that it's only a visual problem, item state is still TVIS_SELECTED as it
supposed to be. The problem is that infoPtr->focusedItem is not reset, this
blocks drawing code path to select correct colors. I'm working on a fix, and
confirming.

[Bug 33550] Treeview: redrawing problem when selected item is also focused (TVS_EDITLABELS with blocked edits affected the most)

http://bugs.winehq.org/show_bug.cgi?id=33550

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Can't select there's only   |Treeview: redrawing problem
                   |one item in TreeView if     |when selected item is also
                   |canceled                    |focused (TVS_EDITLABELS
                   |TVN_BEGINLABELEDIT.         |with blocked edits affected
                   |                            |the most)

[Bug 33550] Treeview: redrawing problem when selected item is also focused (TVS_EDITLABELS with blocked edits affected the most)

http://bugs.winehq.org/show_bug.cgi?id=33550

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source
                URL|                            |
                   |                            |http://www.download3k.com/I
                   |                            |nstall-Navicat-The-World-s-
                   |                            |best-SQL-Server-GUI-tool-MS
                   |                            |-SQL-management.html

[Bug 33550] Treeview: redrawing problem when selected item is also focused (TVS_EDITLABELS with blocked edits affected the most)

http://bugs.winehq.org/show_bug.cgi?id=33550

--- Comment #5 from Bruno Jesus  2013-05-09 15:14:55 CDT ---
Patch commited:
http://source.winehq.org/git/wine.git/?a=commit;h=6f15ca3e4714bafc2578fcb5f8...

[Bug 33550] Treeview: redrawing problem when selected item is also focused (TVS_EDITLABELS with blocked edits affected the most)

http://bugs.winehq.org/show_bug.cgi?id=33550

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |6f15ca3e4714bafc2578fcb5f8b
                   |                            |7b692a2e7f4f8
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Nikolay Sivov  2013-05-13 05:35:39 CDT ---
Yes, test application works fine, so I think it's fixed. Guo Jian (sorry I
don't know which one is your first name), please reopen if it's still broken
for you.

[Bug 33550] Treeview: redrawing problem when selected item is also focused (TVS_EDITLABELS with blocked edits affected the most)

http://bugs.winehq.org/show_bug.cgi?id=33550

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  2013-05-24 13:33:21 CDT ---
Closing bugs fixed in 1.5.31.

[Bug 33550] Treeview: redrawing problem when selected item is also focused (TVS_EDITLABELS with blocked edits affected the most)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=33550

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                URL|                            |https://web.archive.org/web
                   |http://www.download3k.com/I |/20120512110845/http://down
                   |nstall-Navicat-The-World-s- |load2.navicat.com/download/
                   |best-SQL-Server-GUI-tool-MS |navicat100_sqlserver_en.exe
                   |-SQL-management.html        |