https://bugs.winehq.org/show_bug.cgi?id=56607
Bug ID: 56607 Summary: steam: no tray icon starting with wine 9.2 Product: Wine Version: 9.7 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: idarktemplar@mail.ru Distribution: ---
Tray icon for steam is missing in wine 9.7.
I did bisecting and found that it's started with following commit:
b5c57b9a62c396068d18237bd6e82b37c169fdc5 is the first bad commit commit b5c57b9a62c396068d18237bd6e82b37c169fdc5 Author: Gabriel Ivăncescu gabrielopcode@gmail.com Date: Tue Feb 6 16:51:21 2024 +0200
explorer: Set layered style on systray icons only when it's actually layered.
Fixes a regression introduced by 229b4561d9a8f10cbb49342dff0b6a3472d81c68, which caused the icons to not be visible initially in the virtual desktop systray.
Signed-off-by: Gabriel Ivăncescu gabrielopcode@gmail.com
programs/explorer/systray.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
But unlike battle.net in https://bugs.winehq.org/show_bug.cgi?id=56337, for steam tray icon doesn't reappear in wine 9.3 or 9.7
Reproduction: 1. install steam for windows (https://store.steampowered.com/about/) 2. run steam 3. log into steam account
Expected result: steam tray icon in system tray
Actual result: no steam tray icon is present in system tray
Environment: Linux 6.6.21-gentoo KDE/Plasma 5.27.11 X11
https://bugs.winehq.org/show_bug.cgi?id=56607
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |b5c57b9a62c396068d18237bd6e | |82b37c169fdc5 Keywords| |download, regression CC| |gabrielopcode@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=56607
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |programs URL| |https://cdn.cloudflare.stea | |mstatic.com/client/installe | |r/SteamSetup.exe
https://bugs.winehq.org/show_bug.cgi?id=56607
--- Comment #1 from Gabriel Ivăncescu gabrielopcode@gmail.com --- Sorry for delay. This commit is known to have broken it, but it was supposed to be fixed by 8a71a4a30495635bdc905af41869d8ed9e43009f and b1a61e74a383a7dafc025950803255d723df828f
Can you confirm if this happens at b1a61e74a383a7dafc025950803255d723df828f? If it does, try 8a71a4a30495635bdc905af41869d8ed9e43009f. Is it still broken at those commits?
If it's not broken, then please restart the bisect from b1a61e74a383a7dafc025950803255d723df828f as good starting point, because it means something else must have also broken it later, and you arrived at this by bad luck.
https://bugs.winehq.org/show_bug.cgi?id=56607
i.Dark_Templar idarktemplar@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Distribution|--- |Gentoo Regression SHA1|b5c57b9a62c396068d18237bd6e |0f1322d2df4c5238c601a2865b6 |82b37c169fdc5 |e65ad14bfa26a
--- Comment #2 from i.Dark_Templar idarktemplar@mail.ru --- Thanks for tips.
I did additional checks.
8a71a4a30495635bdc905af41869d8ed9e43009f = tray icon is present b1a61e74a383a7dafc025950803255d723df828f = no tray icon
After that I did one more bisect session, result is:
0f1322d2df4c5238c601a2865b6e65ad14bfa26a is the first bad commit commit 0f1322d2df4c5238c601a2865b6e65ad14bfa26a Author: Rémi Bernon rbernon@codeweavers.com Date: Mon Feb 12 10:01:33 2024 +0100
winex11: Support XInput2 events on individual windows.
dlls/winex11.drv/desktop.c | 2 ++ dlls/winex11.drv/mouse.c | 56 +++++++++++++++++++++++++++++----------------- dlls/winex11.drv/window.c | 9 +++++++- dlls/winex11.drv/x11drv.h | 2 ++ 4 files changed, 48 insertions(+), 21 deletions(-)
I've also noticed that sometimes steam tray icons appears for a moment and quickly disappears.
https://bugs.winehq.org/show_bug.cgi?id=56607
Gabriel Ivăncescu gabrielopcode@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rbernon@codeweavers.com
https://bugs.winehq.org/show_bug.cgi?id=56607
--- Comment #3 from Gabriel Ivăncescu gabrielopcode@gmail.com --- Rémi could you take a look please?
https://bugs.winehq.org/show_bug.cgi?id=56607
--- Comment #4 from Rémi Bernon rbernon@codeweavers.com --- Likely a duplicate of bug 56429. I've attached a possible fix there if you want to try it, although I've not been able to reproduce the issue so far.
https://bugs.winehq.org/show_bug.cgi?id=56607
--- Comment #5 from i.Dark_Templar idarktemplar@mail.ru --- https://bugs.winehq.org/show_bug.cgi?id=56429#c12
This fix did not help me. I still miss steam tray icon, and helldivers game crashes at startup.
Not sure why it doesn't reproduce for you. For me it reproduces every time with KDE/Plasma 5 X11.Not sure if there is anything else special about my setup. When I'm starting steam I also get at least 2 windows, sometimes 3: main window, friends window, sometimes sales/news window.
https://bugs.winehq.org/show_bug.cgi?id=56607
--- Comment #6 from Gabriel Ivăncescu gabrielopcode@gmail.com --- For me the "Bad X Window" error is easier to reproduce with this AutoHotkey script:
#NoEnv Sleep 3000 Reload
It gives the error on reload and explorer dies.
https://bugs.winehq.org/show_bug.cgi?id=56607
--- Comment #7 from Rémi Bernon rbernon@codeweavers.com --- Does https://gitlab.winehq.org/wine/wine/-/merge_requests/5575 help here as well?
https://bugs.winehq.org/show_bug.cgi?id=56607
--- Comment #8 from Gabriel Ivăncescu gabrielopcode@gmail.com --- Yeah, that fixes it for me.
https://bugs.winehq.org/show_bug.cgi?id=56607
--- Comment #9 from i.Dark_Templar idarktemplar@mail.ru --- (In reply to Rémi Bernon from comment #7)
Does https://gitlab.winehq.org/wine/wine/-/merge_requests/5575 help here as well?
Yes, it fixed both issues for me.
https://bugs.winehq.org/show_bug.cgi?id=56607
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |749574a298b43584e0a79557791 | |58aa3ab767a08 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED
--- Comment #10 from Ken Sharp imwellcushtymelike@gmail.com --- Fixed.
https://bugs.winehq.org/show_bug.cgi?id=56607
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #11 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 9.9.