[Bug 13274] New: :bitmap:X11DRV_DIB_GetColorCount called with >256 colors!

http://bugs.winehq.org/show_bug.cgi?id=13274

Summary: :bitmap:X11DRV_DIB_GetColorCount called with >256
                    colors!
           Product: Wine
           Version: 1.0-rc1
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

With an install of Microsoft Trip Planner 5, attempting to use the program
fails with

err:bitmap:X11DRV_DIB_GetColorCount called with >256 colors!

(the screen is in 24 bit true color mode).

[Bug 13274] :bitmap:X11DRV_DIB_GetColorCount called with >256 colors!

http://bugs.winehq.org/show_bug.cgi?id=13274

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|gdi32                       |-unknown

--- Comment #1 from Dmitry Timoshkov   2008-05-18 05:07:35 ---
Is there any real problem besides the harmless message?

[Bug 13274] :bitmap:X11DRV_DIB_GetColorCount called with >256 colors!

http://bugs.winehq.org/show_bug.cgi?id=13274

--- Comment #2 from David Hagood   2008-05-18 10:06:04 ---
Yes, the program dies.

[Bug 13274] :bitmap:X11DRV_DIB_GetColorCount called with >256 colors!

http://bugs.winehq.org/show_bug.cgi?id=13274

--- Comment #3 from Austin English   2008-11-16 18:16:20 ---
Is this still an issue in current (1.1.8 or newer) wine?

[Bug 13274] :bitmap:X11DRV_DIB_GetColorCount called with >256 colors!

http://bugs.winehq.org/show_bug.cgi?id=13274

--- Comment #4 from David Hagood   2008-11-17 17:54:54 ---
Pulled the latest and built: same problem.

wine-1.1.8-183-g70088c4

[Bug 13274] :bitmap:X11DRV_DIB_GetColorCount called with >256 colors!

http://bugs.winehq.org/show_bug.cgi?id=13274

--- Comment #5 from Austin English   2008-11-17 20:10:25 ---
Is there a download/demo available? Please attach full terminal output.

[Bug 13274] :bitmap:X11DRV_DIB_GetColorCount called with >256 colors!

http://bugs.winehq.org/show_bug.cgi?id=13274

--- Comment #6 from David Hagood   2008-11-18 06:22:51 ---
Created an attachment (id=17344)
 --> (http://bugs.winehq.org/attachment.cgi?id=17344)
standard out & error from program run

This is the requested output.

The program runs right up until you select "Plan a trip", then the error
happens and the program displays an "Caught unhandled exception (RefMessage)"
error dialog. Selecting "Ok" then terminates the program.

I had instrumented this long ago, and determined that due to the function
failing and returning NULL, the program then immediately crashed derefing the
NULL (as in the program didn't expect that function to every fail).

[Bug 13274] :bitmap:X11DRV_DIB_GetColorCount called with >256 colors!

http://bugs.winehq.org/show_bug.cgi?id=13274

--- Comment #7 from Austin English   2008-11-18 10:36:39 ---
(In reply to comment #6)
> Created an attachment (id=17344)

--> (http://bugs.winehq.org/attachment.cgi?id=17344) [details]
> standard out & error from program run
>
> This is the requested output.
>
> The program runs right up until you select "Plan a trip", then the error
> happens and the program displays an "Caught unhandled exception (RefMessage)"
> error dialog. Selecting "Ok" then terminates the program.
>
> I had instrumented this long ago, and determined that due to the function
> failing and returning NULL, the program then immediately crashed derefing the
> NULL (as in the program didn't expect that function to every fail).

Can you attach a +bitmap log?

[Bug 13274] :bitmap:X11DRV_DIB_GetColorCount called with >256 colors!

http://bugs.winehq.org/show_bug.cgi?id=13274

--- Comment #8 from Austin English   2008-11-18 10:43:55 ---
(In reply to comment #6)
> > I had instrumented this long ago, and determined that due to the function
> > failing and returning NULL, the program then immediately crashed derefing the
> > NULL (as in the program didn't expect that function to every fail).
>
> Can you attach a +bitmap log?

Try this patch:
diff --git a/dlls/gdi32/dib.c b/dlls/gdi32/dib.c
index 7782c51..1f3a6f9 100644
--- a/dlls/gdi32/dib.c
+++ b/dlls/gdi32/dib.c
@@ -1208,7 +1208,8 @@ static void DIB_CopyColorTable( DC *dc, BITMAPOBJ *bmp,
WORD coloruse, const BIT

if (colors > 256) {
         ERR("called with >256 colors!\n");
-        return;
+        colors = 0;
+        return colors;
     }

if (!(colorTable = HeapAlloc(GetProcessHeap(), 0, colors * sizeof(RGBQUAD)
))) return;

[Bug 13274] :bitmap:X11DRV_DIB_GetColorCount called with >256 colors!

http://bugs.winehq.org/show_bug.cgi?id=13274

--- Comment #9 from David Hagood   2008-11-19 07:02:08 ---
Created an attachment (id=17357)
 --> (http://bugs.winehq.org/attachment.cgi?id=17357)
Log of failed run, with WINEDEBUG=+bitmap,+seh

Here's a run with debugging on, capturing the exception.

[Bug 13274] :bitmap:X11DRV_DIB_GetColorCount called with >256 colors!

http://bugs.winehq.org/show_bug.cgi?id=13274

David Hagood  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17357|application/octet-stream    |text/plain
          mime type|                            |

--- Comment #10 from David Hagood   2008-11-19 07:02:58 ---
(From update of attachment 17357)
(corrected incorrectly detected MIME type)

[Bug 13274] :bitmap:X11DRV_DIB_GetColorCount called with >256 colors!

http://bugs.winehq.org/show_bug.cgi?id=13274

--- Comment #11 from Austin English   2009-05-29 12:17:34 ---
Is this still an issue in current (1.1.22 or newer) wine?

[Bug 13274] :bitmap:X11DRV_DIB_GetColorCount called with >256 colors!

http://bugs.winehq.org/show_bug.cgi?id=13274

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |ABANDONED

--- Comment #12 from Austin English   2010-03-11 17:24:44 ---
No response in 8 months, marking abandoned. If you still have an issue in
current (1.1.40 or newer) wine, and can provide the needed information, feel
free to reopen.

[Bug 13274] :bitmap:X11DRV_DIB_GetColorCount called with >256 colors!

http://bugs.winehq.org/show_bug.cgi?id=13274

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Austin English   2010-03-11 17:26:01 ---
Closing.