[Bug 25207] New: SHFileOperation does not create new directory on FO_MOVE

http://msdn.microsoft.com/en-us/library/bb759795.aspx

Summary: SHFileOperation does not create new directory on FO_MOVE Product: Wine Version: 1.3.6 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: major Priority: P2 Component: shell32 AssignedTo: wine-bugs@winehq.org ReportedBy: richard@rtrussell.co.uk

Created an attachment (id=32007) --> (http://bugs.winehq.org/attachment.cgi?id=32007) C program to demonstrate the problem

SHFileOperation should create the destination directory on an FO_MOVE operation, if it does not already exist, but fails to do so. See:

"Copy and Move operations can specify destination directories that do not exist. In those cases, the system attempts to create them and normally displays a dialog box to ask the user if they want to create the new directory. To suppress this dialog box and have the directories created silently, set the FOF_NOCONFIRMMKDIR flag in fFlags".

-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

Show replies by date

wine-bugs＠winehq.org

17 Nov 17 Nov

11:37 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

--- Comment #1 from Richard Russell richard@rtrussell.co.uk 2010-11-17 17:37:24 CST --- Created an attachment (id=32008) --> (http://bugs.winehq.org/attachment.cgi?id=32008) Executable to demonstrate the problem

Program should display 'Tests completed successfully' but under Wine 1.3.6 it displays 'SHFileOperation (FO_MOVE) failed with return value 1223'.

wine-bugs＠winehq.org

11:40 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

Jeff Zaroyko jeffz@jeffz.name changed:

--- Comment #2 from Jeff Zaroyko jeffz@jeffz.name 2010-11-17 17:40:31 CST --- not major: http://bugs.winehq.org/page.cgi?id=fields.html#bug_severity (unless you can list several applications which rely on this behavior)

Confirming the testcase passes on Windows Vista SP2 32bit.

wine-bugs＠winehq.org

19 Nov 19 Nov

7:23 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

Austin English austinenglish@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download

wine-bugs＠winehq.org

1:03 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

--- Comment #3 from Richard Russell richard@rtrussell.co.uk 2011-11-19 07:03:37 CST --- "unless you can list several applications which rely on this behavior"

The majority of applications compiled using 'BBC BASIC for Windows' will fail to run because of this bug. The total number is likely to be in the hundreds, although that would be difficult to confirm.

Here are just a few of the applications affected:

QBASIC to BBC BASIC translator: http://www.bbcbasic.co.uk/qb2bbc/QB2BBC.exe LB Booster: http://www.lbbooster.com/LBB.exe Test Card Generator: http://www.rtrussell.co.uk/tccgen/tcsetup.exe FIR Filter Design: http://www.rtr.myzen.co.uk/firbbc.exe BBC Free-D Camera Tracking: http://www.rtr.myzen.co.uk/fdsetup.exe Colour Recovery: http://www.rtr.myzen.co.uk/crexe128.zip Alien Eliminator: http://www.bb4wgames.com/progs/zip/alieneliminator.zip Vapiki: http://www.jeroengroenendaal.com/games/vapiki.exe Unnamed Shooter: http://81red.dk/UnnamedShooter.zip

wine-bugs＠winehq.org

6:09 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

Jerome Leclanche adys.wh@gmail.com changed:

--- Comment #4 from Jerome Leclanche adys.wh@gmail.com 2011-11-19 12:09:50 CST --- Major.

wine-bugs＠winehq.org

20 Nov 20 Nov

4:50 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

Erik Siers eriksiers@bmi.net changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |eriksiers@bmi.net

wine-bugs＠winehq.org

21 Nov 21 Nov

5:01 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

Grahame Pratt softappstudio@comcast.net changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |softappstudio@comcast.net

--- Comment #5 from Grahame Pratt softappstudio@comcast.net 2011-11-20 23:01:36 CST --- I have four of my own BB4W applications which I would have to seriously rewrite to run under wine as long as this limitation applies. I suspect that there are hundreds of other BB4W users in the same boat. At the moment I am using Virtual-Win98SE machines to run them, terrible kluge!

wine-bugs＠winehq.org

12 Jan 12 Jan

8:23 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

net201416 net201416@yahoo.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |net201416@yahoo.com

--- Comment #6 from net201416 net201416@yahoo.com --- Same problem x86 Wine 1.4.1

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

29 Jan 29 Jan

3:59 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

lizhenbo litimetal@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |litimetal@gmail.com

--- Comment #7 from lizhenbo litimetal@gmail.com --- Same problem on wine-1.7.11

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

5:37 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

lizhenbo litimetal@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |Paul.Vriens.Wine@gmail.com

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

5:44 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

--- Comment #8 from lizhenbo litimetal@gmail.com --- This is first detected by Paul Vriens in dlls/shell32/tests/shlfileop.c

--old code-- retval = SHFileOperationA(&shfo2); if (dir_exists("test6.txt")) { /* Vista and W2K8 (broken or new behavior ?) */ ok(retval == ERROR_NO_VOLUME_LABEL, "Expected ERROR_NO_VOLUME_LABEL, got %d\n", retval); ok(DeleteFileA("test6.txt\test1.txt"), "The file is not moved\n"); RemoveDirectoryA("test6.txt"); ok(DeleteFileA("test7.txt\test2.txt"), "The file is not moved\n"); RemoveDirectoryA("test7.txt"); } else { ok(retval == ERROR_CANCELLED, "Expected ERROR_CANCELLED, got %d\n", retval); ok(!file_exists("test6.txt"), "The file is not moved - many files are " "specified as a target\n"); } ------------

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

3 Feb 3 Feb

9:56 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

--- Comment #9 from lizhenbo litimetal@gmail.com --- Created attachment 47382 --> http://bugs.winehq.org/attachment.cgi?id=47382 0001-shell32-tests-SHFileOperation-should-create-new-direct.txt

Patch for wine testcase

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

9:57 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

--- Comment #10 from lizhenbo litimetal@gmail.com --- Created attachment 47383 --> http://bugs.winehq.org/attachment.cgi?id=47383 0002-shell32-SHFileOperation-should-create-new-directory-on.txt

Patch for this problem

I'm looking forward to your feedbacks, thank you.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

10:44 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

--- Comment #11 from Richard Russell richard@rtrussell.co.uk --- The destination directory requiring to be created may be of the form '....\dir1\dir2\dir3' (where neither dir1 nor dir2 exist), in other words it may require iteratively creating new subdirectories until the required 'level' is reached.

The proposed patch appears only to call CreateDirectoryW which, unless I am mistaken, will not achieve that.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

11:05 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

--- Comment #12 from lizhenbo litimetal@gmail.com --- (In reply to comment #11)

The destination directory requiring to be created may be of the form '....\dir1\dir2\dir3' (where neither dir1 nor dir2 exist), in other words it may require iteratively creating new subdirectories until the required 'level' is reached.

The proposed patch appears only to call CreateDirectoryW which, unless I am mistaken, will not achieve that.

Thank you for checking that. You're right, I made a mistake.

Could I use SHCreateDirectory ?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

11:07 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

--- Comment #13 from lizhenbo litimetal@gmail.com --- Created attachment 47384 --> http://bugs.winehq.org/attachment.cgi?id=47384 C program to demonstrate the problem(v2).c

It shows a behavior: CreateDirectory function will only create the final directory in the path.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

11:57 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

--- Comment #14 from Richard Russell richard@rtrussell.co.uk --- (In reply to comment #12)

Could I use SHCreateDirectory ?

Probably yes, although in Windows Vista and later, SHCreateDirectory has been replaced by SHCreateDirectoryEx; I don't know what the situation is in Wine.

My only concern would be what to supply as the 'hwnd' parameter. Maybe you should pass NULL when the FOF_SILENT flag is set and lpFileOp->hwnd if not?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

2:01 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

--- Comment #15 from lizhenbo litimetal@gmail.com --- (In reply to comment #14)

(In reply to comment #12)

...
Could I use SHCreateDirectory ?

Probably yes, although in Windows Vista and later, SHCreateDirectory has been replaced by SHCreateDirectoryEx; I don't know what the situation is in Wine.

My only concern would be what to supply as the 'hwnd' parameter. Maybe you should pass NULL when the FOF_SILENT flag is set and lpFileOp->hwnd if not?

Thank you. I checked wine's code, and I found SHCreateDirectoryEx has been implemented. As test_sh_create_dir() shows, SHCreateDirectoryEx should work in most situations (but may lack of tests for exceptions)

Besides of it, I worry about dependencies. Luckily, SHCreateDirectoryExW and SHFileOperationW is in the same file, but I don't know if it is guaranteed.

Thanks for mentioning 'hwnd'. I think we should do more tests, instead of only studying MSDN(although it's a good reference) IMHO.

Sorry for my humble expressions.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

6 Nov 6 Nov

1:43 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

Murray Colpman muzerakascooby@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |muzerakascooby@gmail.com

--- Comment #16 from Murray Colpman muzerakascooby@gmail.com --- I believe Block Post Software's simulators are affected by this bug (it could be another bug; I don't know exactly what it's calling, but it seems likely to be this issue given the error is about failure to create a file in a directory that actually doesn't exist). Demonstration versions are available.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

7:41 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

Sebastian Lackner sebastian@fds-team.de changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian@fds-team.de

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

14 Aug 14 Aug

1:29 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

--- Comment #17 from lizhenbo litimetal@gmail.com --- I've sent a patch: http://source.winehq.org/patches/data/113646

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

5 Sep 5 Sep

2:38 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

lizhenbo litimetal@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |aric@codeweavers.com

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

2:48 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

lizhenbo litimetal@gmail.com changed:

--- Comment #18 from lizhenbo litimetal@gmail.com --- Created attachment 52274 --> https://bugs.winehq.org/attachment.cgi?id=52274 patch v2.txt

This is my second version of patch. However, I don't think this patch can be accepted to wine soon.

If your application is blocked, maybe you can try wine-staging? See: https://bugs.wine-staging.com/show_bug.cgi?id=541

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

28 Sep 28 Sep

11:59 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

Michael Müller michael@fds-team.de changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

16 Dec 16 Dec

4:54 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

Austin English austinenglish@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

1 Jun 1 Jun

4:39 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

André H. nerv@dawncrow.de changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

19 Feb 19 Feb

4:51 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

joaopa jeremielapuree@yahoo.fr changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree@yahoo.fr

--- Comment #19 from joaopa jeremielapuree@yahoo.fr --- Bug still occurs with wine-5.2:

SHFileOperation (FO_MOVE) failed with return value 1223

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

27 Dec 27 Dec

12:14 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

Bruno Santos brunomanuelsantos@tecnico.ulisboa.pt changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

28 Jan 28 Jan

1:20 a.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

nekoNexus@protonmail.ch changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |nekoNexus@protonmail.ch

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

17 Mar 17 Mar

8:45 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

Zeb Figura z.figura12@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com

--- Comment #20 from Zeb Figura z.figura12@gmail.com --- (In reply to Murray Colpman from comment #16)

I believe Block Post Software's simulators are affected by this bug (it could be another bug; I don't know exactly what it's calling, but it seems likely to be this issue given the error is about failure to create a file in a directory that actually doesn't exist). Demonstration versions are available.

I can confirm that this application is fixed by the relevant patch.

All of the other applications in comment 3 are either no longer accessible, or it's not clear to me how to trigger the failure, assuming it was ever actually related.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

8:45 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

Zeb Figura z.figura12@gmail.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

18 Mar 18 Mar

2:39 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

--- Comment #21 from lizhenbo litimetal@gmail.com --- (In reply to Zeb Figura from comment #20)

[1]: https://github.com/wine-staging/wine-staging/tree/master/patches/shell32-SHF...

I can confirm that this application is fixed by the relevant patch.

All of the other applications in comment 3 are either no longer accessible, or it's not clear to me how to trigger the failure, assuming it was ever actually related.

I tried my test code https://bugs.winehq.org/attachment.cgi?id=47384

With wine-9.4, it still shows Creating file C:\users\lizhenbo\Temp\shfotest.tmp Moving file to C:\users\lizhenbo\Temp\newsubdir\dir2\dir3\dir4\shfotest.tmp SHFileOperation (FO_MOVE) failed with return value 1223

I'm sorry for dropping my patch to wine-staging for years[1]. I'd like to pick up my staging patch and let it be accepted by wine-get

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

5:37 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

--- Comment #22 from Zeb Figura z.figura12@gmail.com --- (In reply to lizhenbo from comment #21)

With wine-9.4, it still shows Creating file C:\users\lizhenbo\Temp\shfotest.tmp Moving file to C:\users\lizhenbo\Temp\newsubdir\dir2\dir3\dir4\shfotest.tmp SHFileOperation (FO_MOVE) failed with return value 1223

It's not upstream yet. I submitted it as 5335.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

19 Mar 19 Mar

10:23 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

Vijay Kamuju infyquest@gmail.com changed:

--- Comment #23 from Vijay Kamuju infyquest@gmail.com --- Patch upstreamed - https://source.winehq.org/git/wine.git/commit/b4a5775ffb2e5c27ff85399f89f6b3...

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

22 Mar 22 Mar

9:36 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE

Alexandre Julliard julliard@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #24 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 9.5.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

15 Nov 15 Nov

10:16 p.m.

New subject: [Bug 25207] SHFileOperation does not create new directory on FO_MOVE