[Bug 43699] New: Blackscreen in visual novel Hanahira

https://bugs.winehq.org/show_bug.cgi?id=43699

Bug ID: 43699
           Summary: Blackscreen in visual novel Hanahira
           Product: Wine
           Version: 2.16
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 1a7ddf8dd96f9982c42ac7b8ed8cbfbacf07288c
      Distribution: ---

Since wine 2.2 the game only shows a blackscreen.
Bisected to:
commit 1a7ddf8dd96f9982c42ac7b8ed8cbfbacf07288c
Author: Nikolay Sivov 
Date:   Thu Feb 9 07:51:56 2017 +0300

dxgi: Added support for DXGI_SWAP_CHAIN_FLAG_GDI_COMPATIBLE.

Signed-off-by: Nikolay Sivov 
    Signed-off-by: Henri Verbeet 
    Signed-off-by: Alexandre Julliard

Reverting fixes the issue.

Console output is empty, if you need logs I'm happy to provide them.

[Bug 43699] Blackscreen in visual novel Hanahira

https://bugs.winehq.org/show_bug.cgi?id=43699

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]        |

[Bug 43699] Blackscreen in visual novel Hanahira

https://bugs.winehq.org/show_bug.cgi?id=43699

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |directx-d3d

[Bug 43699] Blackscreen in visual novel Hanahira

https://bugs.winehq.org/show_bug.cgi?id=43699

--- Comment #1 from Nikolay Sivov  ---
I'm guessing this one does not have a demo? Please attach
+d3d,+tid,+d3d11,+d3d9,+dxgi log.

[Bug 43699] Blackscreen in visual novel Hanahira

https://bugs.winehq.org/show_bug.cgi?id=43699

--- Comment #2 from Fabian Maurer  ---
Created attachment 59162
  --> https://bugs.winehq.org/attachment.cgi?id=59162
+d3d,+tid,+d3d11,+d3d9,+dxgi logs

You're right, there is no demo.
I attached two logs with latest git tree wine, one where it shows a blackscreen
(broken.log) and one for the working version when reverting the linked commit
(working.log).

I tried making an apitrace, and it seems to rely on gdi for drawing only. Every
frame shows:
> IDirect3DDevice9::BeginScene
> IDirect3DDevice9::Clear
> IDirect3DSurface9::GetDC
> IDirect3DSurface9::ReleaseDC
> IDirect3DDevice9::EndScene
> IDirect3DDevice9::Present

[Bug 43699] Blackscreen in visual novel Hanahira

https://bugs.winehq.org/show_bug.cgi?id=43699

--- Comment #3 from Nikolay Sivov  ---
Created attachment 59166
  --> https://bugs.winehq.org/attachment.cgi?id=59166
trace patch

The only way this could happen I think is if buffer format does not qualify as
gdi compatible. Please attach another log (bad one) with this patch.

[Bug 43699] Blackscreen in visual novel Hanahira

https://bugs.winehq.org/show_bug.cgi?id=43699

--- Comment #4 from Fabian Maurer  ---
Created attachment 59167
  --> https://bugs.winehq.org/attachment.cgi?id=59167
Log with patch applied

Attached log, but only appearance of your trace is
> 0009:trace:d3d9:device_init 0: backbuffer format 0

[Bug 43699] Blackscreen in visual novel Hanahira

https://bugs.winehq.org/show_bug.cgi?id=43699

--- Comment #5 from Nikolay Sivov  ---
Created attachment 59168
  --> https://bugs.winehq.org/attachment.cgi?id=59168
patch

Thanks. Does this work?

[Bug 43699] Blackscreen in visual novel Hanahira

https://bugs.winehq.org/show_bug.cgi?id=43699

--- Comment #6 from Fabian Maurer  ---
Indeed, it makes the game fully work again!

[Bug 43699] Blackscreen in visual novel Hanahira

https://bugs.winehq.org/show_bug.cgi?id=43699

--- Comment #7 from Nikolay Sivov  ---
Created attachment 59169
  --> https://bugs.winehq.org/attachment.cgi?id=59169
patch 2

Could you verify that this one works too as a replacement?

[Bug 43699] Blackscreen in visual novel Hanahira

https://bugs.winehq.org/show_bug.cgi?id=43699

--- Comment #8 from Fabian Maurer  ---
This patch applied on a clean master works too.

[Bug 43699] Blackscreen in visual novel Hanahira

https://bugs.winehq.org/show_bug.cgi?id=43699

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |67689049e2608e46761765eb841
                   |                            |2e6ec423670c5
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Nikolay Sivov  ---
Assuming fixed, 67689049e2608e46761765eb8412e6ec423670c5. Please test.

[Bug 43699] Blackscreen in visual novel Hanahira

https://bugs.winehq.org/show_bug.cgi?id=43699

--- Comment #10 from Fabian Maurer  ---
Confirming fixed.

[Bug 43699] Blackscreen in visual novel Hanahira

https://bugs.winehq.org/show_bug.cgi?id=43699

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard  ---
Closing bugs fixed in 2.18.