[Bug 24017] New: reg /query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

Summary: reg /query not implemented
           Product: Wine
           Version: 0.9
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Keywords: download, Installer, patch
          Severity: normal
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

(Broken out from catchall bug 19533.)

reg /query doesn't work in wine.  This breaks several apps, including pando
downloader.

Shuyin Lu wrote an implementation of reg /query in March 2010, and
intended to submit it to wine-patches, but ran out of time.
I'm attaching it here.

[Bug 24017] reg /query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

--- Comment #1 from Dan Kegel   2010-08-15 12:34:29 ---
Also, David Cournapeau did an implementation; it's at
http://github.com/cournape/wine/commits/_reg_query/programs/reg/reg.c

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|reg /query not implemented  |reg query not implemented

--- Comment #2 from Dan Kegel   2010-08-15 12:35:35 ---
grr, it's reg query, not reg /query.

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

--- Comment #3 from Dan Kegel   2010-08-15 13:11:55 ---
Created an attachment (id=30169)
 --> (http://bugs.winehq.org/attachment.cgi?id=30169)
Shuyin's draft patch, attached with permission from the author

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.9                         |1.3.0

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

--- Comment #4 from Dan Kegel   2010-08-16 08:43:06 ---
Correction: pando downloader runs into this, and crashes shortly thereafter,
but the crash isn't related.

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

Myk Taylor  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Austin English  2010-09-27 13:46:29 CDT ---
This would also be useful for winetricks, to know if the .Net installroot keys
need to be deleted or not (reg delete fails if the key doesn't exist).

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

Anton Romanov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

Amos Wenger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Amos Wenger  2011-04-10 07:45:07 CDT ---
Is this still relevant? From my experience in Wine 1.3.17 vanilla, Pando
Downloader runs perfectly.

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

--- Comment #7 from Dan Kegel  2011-04-10 09:51:17 CDT ---
Yes, users need it, if nothing else.  And it'd simplify winetricks.

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

--- Comment #8 from Amos Wenger  2011-04-10 09:53:30 CDT ---
Alrighty then, what's wrong with the patch? It looks good to me (except maybe
convert_data_to_wchar could be made reusable, it's probably already coded in
other areas of Wine.. I suppose?). Why hasn't it been merged yet?

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

--- Comment #9 from Dan Kegel  2011-04-10 10:11:32 CDT ---
The author has to keep resubmitting the patch and addressing feedback
until it's accepted.  I will ping David and Shuyin to see if either is
willing to pick it up again.

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

Sylvain Petreolle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

achipa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

Guo Jian  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

lizhenbo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from lizhenbo  2013-06-24 02:13:55 CDT ---
Does this problem exists in wine 1.6-rc3 now?
Also, is this bug blocking bug 25015?

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

--- Comment #11 from Myk Taylor  2013-06-24 11:33:54 CDT ---
(In reply to comment #10)
> Does this problem exists in wine 1.6-rc3 now?
> Also, is this bug blocking bug 25015?

reg query is a stub implementation now.  It will always return:
  STUB QUERY - <key that you are querying> (null) 0 0
regardless of the contents of the key

so I would say that it is not yet implemented.  I do not know whether this
still affects bug 25015.

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

Hugh McMaster  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

--- Comment #12 from Hugh McMaster  2013-08-24 06:17:43 CDT ---
Created attachment 45714
  --> http://bugs.winehq.org/attachment.cgi?id=45714
Hugh McMaster's patch

I don't know if anyone is still interested in this functionality, but I've put
together a draft patch that implements 'reg.exe query <key> </v> </s>'.

The patch was created against wine 1.7.0.

[Bug 24017] reg query not implemented

http://bugs.winehq.org/show_bug.cgi?id=24017

--- Comment #13 from achipa  2013-08-25 03:53:57 CDT ---
There is (still) interest - I'm using a custom built reg.exe myself based on
this patch as the Nokia Asha tools
(http://developer.nokia.com/Develop/asha/java/tools.xhtml) use "reg query" to
detect the various installed SDKs.

[Bug 24017] Multiple applications need 'reg.exe' 'query' operation implementation

http://bugs.winehq.org/show_bug.cgi?id=24017

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|reg query not implemented   |Multiple applications need
                   |                            |'reg.exe' 'query' operation
                   |                            |implementation

--- Comment #14 from Anastasius Focht  ---
Hello folks,

obviously still present.

Source:
http://source.winehq.org/git/wine.git/blob/f9c2e21fb1a1425652d3a2b256380be9c...

--- snip ---
359 static int reg_query(WCHAR *key_name, WCHAR *value_name, BOOL value_empty,
360        BOOL subkey)
361 {
362     static const WCHAR stubW[] = {'S','T','U','B',' ','Q','U','E','R','Y','
',
363            '-',' ','%','s',' ','%','s',' ','%','d',' ','%','d','\n',0};
364     reg_printfW(stubW, key_name, value_name, value_empty, subkey);
365
366     return 1;
367 }
--- snip ---

$wine --version
wine-1.7.9-286-g8f53710

Regards

[Bug 24017] Multiple applications need 'reg.exe' 'query' operation implementation

https://bugs.winehq.org/show_bug.cgi?id=24017

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from [e-mail] ---
Still the same 1.7.24

[Bug 24017] Multiple applications need 'reg.exe' 'query' operation implementation

https://bugs.winehq.org/show_bug.cgi?id=24017

J V  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from J V  ---
Created attachment 49451
  --> https://bugs.winehq.org/attachment.cgi?id=49451
Updated Shuyin's patch

Tried making my own. I got a few types working but it was too much work and I
didn't have a windows machine to check my results against anyway.

Shuyin's patch doesn't apply against wine any more, but no matter, I applied it
to an old version and rebased it so this should be up to date.

Haven't eyeballed all the code but it certainly works.

[Bug 24017] Multiple applications need 'reg.exe' 'query' operation implementation

https://bugs.winehq.org/show_bug.cgi?id=24017

--- Comment #17 from J V  ---
One thing I noticed around enum_all_values_subkeys(), `reg query /s` is
supposed to "[...]query all subkeys and value names recursively." while this
function only does it on one level.

I'm not sure if this is a bug in the patch or yet another case of windows
implementation not living up to it's documentation, but either way I've written
a patch to get recursion working:
https://github.com/jnvsor/wine/commits/daf0e5e5cb5886a435b1db3c75ed3cab0c938...

And yes besides that it looks good, a damn sight better than the current source
code of reg anyway :)

[Bug 24017] Multiple applications need 'reg.exe' 'query' operation implementation

https://bugs.winehq.org/show_bug.cgi?id=24017

--- Comment #18 from J V  ---
Cleaned it up a lot, implemented some more missing features, fixed a few
crashes.

I wanted to submit it to the wine-patches mailing list but holy shit mailing
lists are a pain.

https://github.com/jnvsor/wine/compare/60de49770c0...b7e64971bcb2eab

[Bug 24017] Multiple applications need 'reg.exe' 'query' operation implementation

https://bugs.winehq.org/show_bug.cgi?id=24017

--- Comment #19 from [e-mail] ---
Patches aren't gathered from bug attachments. So you need to send it over...

[Bug 24017] Multiple applications need 'reg.exe' 'query' operation implementation

https://bugs.winehq.org/show_bug.cgi?id=24017

Hugh McMaster  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45714|0                           |1
        is obsolete|                            |

[Bug 24017] Multiple applications need 'reg.exe' 'query' operation implementation

https://bugs.winehq.org/show_bug.cgi?id=24017

Jeff D. Hanson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #20 from Jeff D. Hanson  ---
In Wine 1.8 the query still returning "STUB QUERY".

[Bug 24017] Multiple applications need 'reg.exe' 'query' operation implementation

https://bugs.winehq.org/show_bug.cgi?id=24017

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |erich.e.hoover@wine-staging
                   |                            |.com, [e-mail],
                   |                            |[e-mail]
             Status|NEW                         |STAGED
    Staged patchset|                            |https://github.com/wine-com
                   |                            |pholio/wine-staging/tree/ma
                   |                            |ster/patches/reg-Implement_
                   |                            |Query

[Bug 24017] Multiple applications need 'reg.exe' 'query' operation implementation

https://bugs.winehq.org/show_bug.cgi?id=24017

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #21 from [e-mail] ---
At least some work regarding this issue has merged into upstream.

[Bug 24017] Multiple applications need 'reg.exe' 'query' operation implementation

https://bugs.winehq.org/show_bug.cgi?id=24017

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|STAGED                      |NEW

--- Comment #22 from Sebastian Lackner  ---
@Hugh: Is there anything missing, or can we mark this bug as fixed? The basic
functionality is definitely present already. I would suggest to start a new bug
report if there are still remaining problems.

[Bug 24017] Multiple applications need 'reg.exe' 'query' operation implementation

https://bugs.winehq.org/show_bug.cgi?id=24017

--- Comment #23 from Hugh McMaster  ---
I've still got a few minor issues to address, but nothing that prevents us from
marking the bug as fixed.

[Bug 24017] Multiple applications need 'reg.exe' 'query' operation implementation

https://bugs.winehq.org/show_bug.cgi?id=24017

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |dd5da0ae640966be2ccc2ea84a6
                   |                            |fb1b638da0f5c

--- Comment #24 from Sebastian Lackner  ---
(In reply to Hugh McMaster from comment #23)
> I've still got a few minor issues to address, but nothing that prevents us
> from marking the bug as fixed.

Okay, marking as fixed then (with dd5da0ae640966be2ccc2ea84a6fb1b638da0f5c and
various previous patches). Thanks for all the effort.

[Bug 24017] Multiple applications need 'reg.exe' 'query' operation implementation

https://bugs.winehq.org/show_bug.cgi?id=24017

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #25 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.10.