[Bug 19249] New: Notepad++ default save dialog is 'Save', not 'Save as' (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19249

Summary: Notepad++ default save dialog is 'Save', not 'Save as'
                    (appinstall)
           Product: Wine
           Version: 1.1.25
          Platform: PC
               URL: http://sourceforge.net/project/showfiles.php?group_id=
                    95717&package_id=102072
        OS/Version: Linux
            Status: NEW
          Keywords: download, source
          Severity: minor
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=22288)
 --> (http://bugs.winehq.org/attachment.cgi?id=22288)
screenshot

This one is pretty tricky, and had me pulling my hair out.

Open notepad++ with no document, so it creates an empty one.
Type something 'Wine is awesome!'
Go to save 'CTRL+S'
You'll get the default save dialog.

However!
On windows:
Title = 'Save As'

On wine:
Title = 'Save'

[Bug 19249] Notepad++ default save dialog is 'Save', not 'Save as' (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19249

--- Comment #1 from Austin English   2009-07-09 01:08:04 ---
Wine's notepad has the same problem.

[Bug 19249] Notepad++ default save dialog is 'Save', not 'Save as' (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19249

Benjamin Debski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Benjamin Debski  2011-01-07 22:14:00 CST ---
Still present in Wine 1.3.10

[Bug 19249] Notepad++ default save dialog is 'Save', not 'Save as' (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19249

gat  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from gat  2011-05-17 13:42:29 CDT ---
(In reply to comment #0)
> Created an attachment (id=22288)

--> (http://bugs.winehq.org/attachment.cgi?id=22288) [details]
> screenshot
>
> This one is pretty tricky, and had me pulling my hair out.
>
> Open notepad++ with no document, so it creates an empty one.
> Type something 'Wine is awesome!'
> Go to save 'CTRL+S'
> You'll get the default save dialog.
>
> However!
> On windows:
> Title = 'Save As'
>
> On wine:
> Title = 'Save'

Does anybody know where in the source is the file that would contain 'Save As'.
I do not have Windows to test this. "ChangeLog" for Notepad++ is a string of
different web-pages and the on-line documentation doesn't have a screen shot
and fails to address the window's title-bar's name at
http://npp-community.tuxfamily.org/documentation/notepad-user-manual/file-ma....

[Bug 19249] Notepad++ default save dialog is 'Save', not 'Save as' (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19249

--- Comment #4 from gat  2011-05-17 13:46:07 CDT ---
Closest thing to a good changelog for the project that I can find:
http://www.softpedia.com/progChangelog/Notepad-plus-plus-Changelog-13216.htm...

[Bug 19249] Notepad++ default save dialog is 'Save', not 'Save as' (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19249

--- Comment #5 from gat  2011-05-17 14:54:08 CDT ---
Created an attachment (id=34754)
 --> (http://bugs.winehq.org/attachment.cgi?id=34754)
Open/Save-File Dialog Box

This is the FileDialotg.cpp file which I think probably defines the "Save As"
DialogBox. I have been searching thru the source to see if maybe the project
dropped the word ` as' from the Dialog's title. I figured that this would be
the file.

[Bug 19249] Notepad++ default save dialog is 'Save', not 'Save as' (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19249

--- Comment #6 from Alex Henrie  2011-12-05 15:39:48 CST ---
Created attachment 37814
  --> http://bugs.winehq.org/attachment.cgi?id=37814
Proposed patch

I made a patch which fixes the problem in both Notepad and Notepad++, but I'm
hesitant to submit it to wine-patches because I changed a translatable string
and I don't know how to update the .po files. What do you think?

[Bug 19249] Notepad++ default save dialog is 'Save', not 'Save as' (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19249

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from François Gouget  2011-12-07 13:00:41 CST ---
(In reply to comment #6)
> I made a patch which fixes the problem in both Notepad and Notepad++, but I'm
> hesitant to submit it to wine-patches because I changed a translatable string
> and I don't know how to update the .po files. What do you think?

PO files are part of the generated files so they don't need to be updated or
included in the patch you submit as per the patching policy.

http://wiki.winehq.org/SubmittingPatches

[Bug 19249] Notepad++ default save dialog is 'Save', not 'Save as' (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19249

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |b5b739d5f333961690a063e6cf9
                   |                            |56eaa4e3d011d
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Austin English  2011-12-09 15:33:21 CST ---
(In reply to comment #6)
> Created attachment 37814 [details]
> Proposed patch
>
> I made a patch which fixes the problem in both Notepad and Notepad++, but I'm
> hesitant to submit it to wine-patches because I changed a translatable string
> and I don't know how to update the .po files. What do you think?

http://source.winehq.org/git/wine.git/commitdiff/b5b739d5f333961690a063e6cf9...

Thanks!

[Bug 19249] Notepad++ default save dialog is 'Save', not 'Save as' (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19249

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  2011-12-16 13:29:29 CST ---
Closing bugs fixed in 1.3.35.

[Bug 19249] Notepad++ default save dialog is 'Save', not 'Save as' (appinstall)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=19249

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |comdlg32