http://bugs.winehq.org/show_bug.cgi?id=25229
Summary: rejected test cases never go back to queue Product: WineHQ Apps Database Version: unspecified Platform: All OS/Version: All Status: UNCONFIRMED Severity: major Priority: P2 Component: appdb-unknown AssignedTo: wine-bugs@winehq.org ReportedBy: virtuousfox@gmail.com
when test case is rejected instead of outright deleted it does not go back into queue to be reviewed even after being edited by submitter. this issue was discussed sometime year or two ago but apparently never was fixed.
example here: user have submitted result and it got rejected for better detailing, it was edited by submiter and mail notification was sent to me. "test result" is http://appdb.winehq.org/objectManager.php?sClass=version&iId=4976&iT... but it not anywhere in my queue list. i want to reject it second time anyway since submitter didn't bothered to read damn notes and howtos at app test page again or look at other, proper submits but i can't even do that now since it's not in queue and i can't do anything with it.
http://bugs.winehq.org/show_bug.cgi?id=25229
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal
http://bugs.winehq.org/show_bug.cgi?id=25229
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #1 from Ken Sharp kennybobs@o2.co.uk 2010-11-24 15:02:54 CST --- Very true. Confirming.
http://bugs.winehq.org/show_bug.cgi?id=25229
Jörg Höhle hoehle@users.sourceforge.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hoehle@users.sourceforge.ne | |t
--- Comment #2 from Jörg Höhle hoehle@users.sourceforge.net 2010-12-17 03:46:54 CST --- I'd like to suggest renaming "Reject" to "Suspend" or something similar. It was completely obscure to me prior to reading this issue that "Reject" could be used (in theory) to send an e-mail to a submitter *and* leave the submission in the queue, waiting for clarification or additional details. This is want I want to do with half the submissions that I process.
"Reject" sounds final in my mind = "Refuse and be done with it". "Delete" like "get rid of that spam" (which might be identical except no mail is sent).
Of course that supposes that either a) the submitter is still able to get to a page where s/he can refine the submitted data (instead of creating it anew), or b) I refine the data as a maintainer, based on the feedback I got per email from the submitter.
So what's open? - Does AppDB guarantee that a submission is still available for refinement after sending an answer like "We appreciate your submission but it needs to be more detailed before it will be most useful to other users of the Application Database. Please try to improve the entry and resubmit." Or will the user have to retype everything?
- If refinement is possible, how to send an e-mail? Is "Submit" the right button? Is "Reject" the right one?
http://bugs.winehq.org/show_bug.cgi?id=25229
--- Comment #3 from Rosanne DiMesio dimesio@earthlink.net 2010-12-17 09:44:21 CST --- (In reply to comment #2)
- If refinement is possible, how to send an e-mail? Is "Submit" the right button? Is "Reject" the right one?
Users get an email when a test report is rejected, and they are able to revise the original form. The problem is that after they have revised it, the revised report does not go back in the test report queue, but stays in the the rejected list. Maintainers don't have access the rejected list (admins do), so they have no way to accept the revised version.
http://bugs.winehq.org/show_bug.cgi?id=25229
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kennybobs@o2.co.uk
--- Comment #4 from Ken Sharp kennybobs@o2.co.uk 2011-10-11 17:58:55 CDT --- Still true today.
http://bugs.winehq.org/show_bug.cgi?id=25229
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Platform|All |Other OS/Version|All |other
--- Comment #5 from Austin English austinenglish@gmail.com 2012-02-23 15:19:55 CST --- Removing deprecated 'All' Platform/OS.
http://bugs.winehq.org/show_bug.cgi?id=25229
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alexsornes@gmail.com, | |nerv@dawncrow.de
--- Comment #6 from André H. nerv@dawncrow.de 2012-06-30 08:34:54 CDT --- Still present, very annoying for Submitter and Maintainer.
http://bugs.winehq.org/show_bug.cgi?id=25229
Joerg Schiermeier mywine@schiermeier-software.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mywine@schiermeier-software | |.de
--- Comment #7 from Joerg Schiermeier mywine@schiermeier-software.de 2012-12-31 21:40:31 CST --- And again - I run into this error like reported here: http://www.winehq.org/pipermail/wine-devel/2012-December/098280.html
So it is still present.
https://bugs.winehq.org/show_bug.cgi?id=25229
jre.winesim@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jre.winesim@gmail.com
--- Comment #8 from jre.winesim@gmail.com --- Still present.
Thanks Rosanne for explaining what goes wrong.
As long as this is not fixed, what is the recommended workaround?
Reject and, once a corrected test is resubmitted, file a bug here with a link to the not-appearing test result, so that an admin can accept it?
Or is there any way to PM the user (based on the test-result-submitted-mail) and ask to improve the test result?
https://bugs.winehq.org/show_bug.cgi?id=25229
--- Comment #9 from Rosanne DiMesio dimesio@earthlink.net --- The global admin queue has PM links for each test report submitted, but I don't know if maintainers have that in their queues. If you do, you can try PMing the submitter through that and leaving the test report in the queue until they respond. However, keep in mind that maintainers are automatically removed by the system if they don't process test reports within 7 days, so if a submitter doesn't respond quickly enough, the maintainer risks being removed.
IMO, the easiest way to deal with this would be for maintainers to delete rather than reject the report and ask the user to submit a new one with whatever changes the maintainer specifies.
https://bugs.winehq.org/show_bug.cgi?id=25229
--- Comment #10 from Jens Reyer jre.winesim@gmail.com --- OK, the maintainers can also PM the submitters based on the test results queue. (I had only the email at hand for my last comment, but nothing in the queue to check).
Thanks for the note about the 7 days.
I guess deleting a test result leaves a user without the original test result. So I'll only do this for quite simple test results.
However if a user clearly put some effort in a test report (but the test is still not acceptable) I'll reject it, with a note to submit a new one, giving the user a chance to copy and paste the good stuff from the last report.
https://bugs.winehq.org/show_bug.cgi?id=25229
Robert Walker bob.mt.wya@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bob.mt.wya@gmail.com
--- Comment #11 from Robert Walker bob.mt.wya@gmail.com --- (In reply to Rosanne DiMesio from comment #9)
The global admin queue has PM links for each test report submitted, but I don't know if maintainers have that in their queues.
The global admin queue??
I accidently rejected a test submission today - before I'd written a request for some additional information. Now I've got no easy way to contact the test submitter. I've tried quite hard to find one... Hence why I'm adding my $0.02 to this bug report...
IMO, the easiest way to deal with this would be for maintainers to delete rather than reject the report and ask the user to submit a new one with whatever changes the maintainer specifies.
That makes sense... But it's annoying for a user - if they've typed a lot of information. If all I need added - is say their graphics card/driver data - then they may not bother to re-post the submission.
Really this feels quite hostile to the kind of user base we have.
But how to fix it? I've a reasonable proposal...
Well I'd like to see a "limbo queue" for AppDB test submissions. This would be fully integrated with the existing one.
Entries in this limbo queue, of test submissions, would only be visible / accessible to: * AppDB maintainer (for the specific application) * the original submitter (WineHQ user)
Limbo entries would obviously not be included in any of the WineHQ statistics.
Then either party can do simple fixes - without the original test submission disappearing into "thin air".
https://bugs.winehq.org/show_bug.cgi?id=25229
--- Comment #12 from Rosanne DiMesio dimesio@earthlink.net --- I've been trying to reproduce this problem in my test environment, and I can't. Rejected entries that the user resubmits are requeued, and they do show up in the maintainer's queue again.
This bug is pretty old; has anyone recently encountered the problem that was originally reported?
(In reply to Robert Walker from comment #11)
I accidently rejected a test submission today - before I'd written a request for some additional information. Now I've got no easy way to contact the test submitter.
That's a separate issue.
https://bugs.winehq.org/show_bug.cgi?id=25229
--- Comment #13 from Ken Sharp imwellcushtymelike@gmail.com --- I'd noticed it seems to have started working. I assume there was a change.
https://bugs.winehq.org/show_bug.cgi?id=25229
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #14 from Rosanne DiMesio dimesio@earthlink.net --- Marking fixed.
https://bugs.winehq.org/show_bug.cgi?id=25229
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #15 from Rosanne DiMesio dimesio@earthlink.net --- Closing fixed AppDB bug.
https://bugs.winehq.org/show_bug.cgi?id=25229
--- Comment #16 from Jens Reyer jre.winesim@gmail.com --- This just hit me again, so this bug is probably not fixed.
I had rejected https://appdb.winehq.org/objectManager.php?sClass=version&iId=26175&...
The user updated the test as requested, and I got an email "Test Results modified for ..." containing the same link. Following that link I can see the updated test result.
But the test is neither in my queue, nor in the regular AppDB.
Greets jre
https://bugs.winehq.org/show_bug.cgi?id=25229
--- Comment #17 from Robert Walker bob.mt.wya@gmail.com ---
I would suggest this bug is reopened till root cause is identified. It's certainly affected multiple Test Submissions I've processed (prior to being made a site Admin).
It was really annoying when I was just a App Maintainer on AppDB... I would worry that end users would think I was just burying their Test Submissions!
Again the AppDB site could really do with a joint Maintainer / Admin mailing list to raise and discuss issues like this (as was decided at last years Wineconf).
https://bugs.winehq.org/show_bug.cgi?id=25229
Predatory QQmber virtuousfox@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED |---
--- Comment #18 from Predatory QQmber virtuousfox@gmail.com --- OK, let's give it another go. Personally, I don't even care anymore, haven't used wine for years because of the need in per-app hacks and unwillingness of developers to use Mesa state-trackers directly.
https://bugs.winehq.org/show_bug.cgi?id=25229
--- Comment #19 from Rosanne DiMesio dimesio@earthlink.net --- (In reply to Jens Reyer from comment #16)
This just hit me again, so this bug is probably not fixed.
I had rejected https://appdb.winehq.org/objectManager. php?sClass=version&iId=26175&iTestingId=103092
I found it in the rejected queue, but when I tried to accept it from there, the AppDB threw up an error message that said "Database Error: Table 'apidb.distribution' doesn't exist." The test report disappeared from the rejected queue but turned up back in the submitted queue, and I accepted it from there. So there's definitely a bug in processing reports from the rejected queue, but that's separate from what's reported here.
As for this bug, what I think has been happening is that some users have edited their reports but failed to resubmit them, so they were never moved out of the rejected queue, but maintainers have been interpreting the email notice about modifying the test to mean that it was resubmitted. If a test report was actually resubmitted, and not just edited, then the notice would say it was submitted. At least, that's what I found in my local test environment, and that's been my experience as a maintainer.
We probably shouldn't be sending notices about modifications until the report actually is resubmitted.
-
wine-bugs＠winehq.org