[Bug 48347] New: winetricks wmp10 no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48347

Bug ID: 48347
           Summary: winetricks wmp10 no longer installs
           Product: Wine
           Version: 5.0-rc2
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, Installer, regression
          Severity: normal
          Priority: P2
         Component: kernel32
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail]
   Regression SHA1: 1f626b5e1f072be9ba0b0d6eb0aab6e1cf7ebc71
      Distribution: Gentoo

Regression introduced by

commit 1f626b5e1f072be9ba0b0d6eb0aab6e1cf7ebc71
Author: Louis Lenders 
Date:   Wed Dec 18 19:29:56 2019 +0100

kernel32: Update version to win7.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48304
    Signed-off-by: Louis Lenders 
    Signed-off-by: Alexandre Julliard

winetricks sets the version to winxp, but it seems wmp10 checks the actual dll
resource version, which is hardcoded and not subject to override by wine's
reported version.

[Bug 48347] winetricks wmp10 no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48347

--- Comment #1 from Louis Lenders  ---
(In reply to Austin English from comment #0)
> winetricks sets the version to winxp, but it seems wmp10 checks the actual
> dll resource version, which is hardcoded and not subject to override by
> wine's reported version.

Yes, there is no mechanism as such, and i wonder if that really ever is. Here`s
my five cents on it: for 100% backward compability with xp one would have to
change dlls version resources, the fake dlls resources but for other installers
maybe also remove hardcoded registrykeys (from wine.inf), and some might even
look for existence of dlls or (non-)existing entry points in dlls, is that
dealable?

For wmp10 i think it can be workedaround by extracting WMP10.exe with
cabextract, then run setup_wm.exe manually, it seems to install all the stuff
afaict

[Bug 48347] winetricks wmp10 no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48347

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Zhiyi Zhang  ---
*** Bug 48393 has been marked as a duplicate of this bug. ***

[Bug 48347] winetricks wmp10 no longer installs

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48347

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 48347] Windows Media Player 10 for Windows XP no longer installs via 'winetricks wmp10' with Wine 5.0+ (kernel32.dll version resource blocker on Vista+)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48347

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|winetricks wmp10 no longer  |Windows Media Player 10 for
                   |installs                    |Windows XP no longer
                   |                            |installs via 'winetricks
                   |                            |wmp10' with Wine 5.0+
                   |                            |(kernel32.dll version
                   |                            |resource blocker on Vista+)
                URL|                            |https://download.microsoft.
                   |                            |com/download/1/2/a/12a31f29
                   |                            |-2fa9-4f50-b95d-e45ef7013f8
                   |                            |7/MP10Setup.exe

--- Comment #3 from Anastasius Focht  ---
Hello folks,

I suggest you create an issue at winetricks github project to implement the
workaround.

https://github.com/Winetricks/winetricks/issues

https://github.com/Winetricks/winetricks/commit/437248f9d280b53afc82cf81a8eb...

Although it's a regression from functionality point of view "it worked in the
past", it's not a regression w.r.t. Windows compatibility. Wine behaves exactly
as if you would run the installer in compatibility mode for Windows XP on
Windows 7 (minus the appcompat shim part).

Either 'INVALID' or 'WONTFIX' here.

Regards

[Bug 48347] Windows Media Player 10 for Windows XP no longer installs via 'winetricks wmp10' with Wine 5.0+ (kernel32.dll version resource blocker on Vista+)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48347

--- Comment #4 from Austin English  ---
There's already a PR:
https://github.com/Winetricks/winetricks/pull/1460

I'm fine in theory with closing this WONTFIX, however my concern is that we may
see other apps that don't have a workaround.

I'm currently travelling and can't test for a couple weeks, but I believe I
tested this with winxp mode, which IMO should report a winxp dll version.
However, that may not be achievable in practice given the current build setup.

[Bug 48347] Windows Media Player 10 for Windows XP no longer installs via 'winetricks wmp10' with Wine 5.0+ (kernel32.dll version resource blocker on Vista+)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48347

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |NOTOURBUG

--- Comment #5 from Austin English  ---
(In reply to Austin English from comment #4)
> There's already a PR:
> https://github.com/Winetricks/winetricks/pull/1460
>
> I'm fine in theory with closing this WONTFIX, however my concern is that we
> may see other apps that don't have a workaround.
>
> I'm currently travelling and can't test for a couple weeks, but I believe I
> tested this with winxp mode, which IMO should report a winxp dll version.
> However, that may not be achievable in practice given the current build
> setup.

Worked around upstream:
https://github.com/Winetricks/winetricks/commit/a3d1928f772c87b9f466e6a6ec43...

[Bug 48347] Windows Media Player 10 for Windows XP no longer installs via 'winetricks wmp10' with Wine 5.0+ (kernel32.dll version resource blocker on Vista+)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48347

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Austin English  ---
Closing.