[Bug 46948] New: Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

Bug ID: 46948
           Summary: Characters in The Sims Complete Collection render
                    completely white
           Product: Wine
           Version: 4.5
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 64071
  --> https://bugs.winehq.org/attachment.cgi?id=64071
screenshot

I've attached the screenshot to showcase the issue. All 3D models in the game
render completely white with the exception of the plumbob (it looks correct).
And the opposite happens in older editions of the game (like Deluxe Edition) -
the characters render just fine, but not the plumbob (it's still green but
looks flat and lacks any planes).
I've tried using latest master of Wine along with latest Wine-staging
(e2c7fb5bb6f4cb79156e0b7bcb3fa3485f1edb00) along with this patch
(thttps://bugs.winehq.org/attachment.cgi?id=63990) and the issue in The Sims
Complete Collection still persists. While the redrawing seems to work all
correctly, the characters still render incorrectly.

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

--- Comment #1 from Alexandr Oleynikov  ---
Created attachment 64072
  --> https://bugs.winehq.org/attachment.cgi?id=64072
+ddraw,+d3d,+d3d_shader

WINEDEBUG=+ddraw,+d3d,+d3d_shader log compressed with .xz (original size is
roughly 100mb).

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

Alexandr Oleynikov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

Alexandr Oleynikov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

--- Comment #2 from Paul Gofman  ---
Created attachment 64081
  --> https://bugs.winehq.org/attachment.cgi?id=64081
ddraw: Ignore surface caps when setting texture

Does the attached tweak fixes it or changes anything?

That is to be applied on top of Wine Staging, and presumably
https://bugs.winehq.org/attachment.cgi?id=63990 is also required.

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

--- Comment #3 from Alexandr Oleynikov  ---
Yes, it completely fixes the issue.

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

--- Comment #4 from Paul Gofman  ---
(In reply to Alexandr Oleynikov from comment #3)
> Yes, it completely fixes the issue.

Thanks for testing this. I didn't yet figure out the exact conditions how is it
supposed to succeed on Windows. Straightforward test trying to draw a texture
without DDSCAPS_TEXTURE doesn't succeed on Windows even with software device.

There was an issue with "plumbob" in yet another Sims flavor mentioned before,
do you know if this is fixed with these patches also or it is yet another bug?

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

--- Comment #5 from Alexandr Oleynikov  ---
Oh yeah, I forgot to mention, the plumbob issue is fixed with this too in
Deluxe Edition.

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

--- Comment #6 from Paul Gofman  ---
A modified version of the patch was accepted to Staging (commit
bfdd49203c7c427f90a8a7651fa2d63b8511bde1).

For the record, the details of the issue for future reference.

The Sims (all the flavors appeared in bug reports, not just The Complete
Collection) are using Directx 4 and create software (RGB) device. Render
targets and depth buffers are all created with DDSCAPS_SYSTEMMEMORY. This is
the reason why it doesn't start with mainstream Wine now and needs Staging
patches in this area.

This particular bug is about the way this version sets the textures. The game
passes offscreen surfaces (DDSCAPS_OFFSCREENPLAIN | DDSCAPS_SYSTEMMEMORY) to
_SetTexture(). Wine sets null texture if the texture doesn't have
DDSCAPS_TEXTURE. I've tested that the texture without DDSCAPS_TEXTURE is
actually set on Windows with ddraw4 and software device. It still sets null
texture with hardware device or with ddraw7 regardless of device type.

The patch adds a test for ddraw4 and allows setting of textures without
DDSCAPS_TEXTURE for ddraw4 software devices.

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |STAGED
    Staged patchset|                            |https://github.com/wine-sta
                   |                            |ging/wine-staging/tree/mast
                   |                            |er/patches/ddraw-Texture_Wr
                   |                            |ong_Caps
                 CC|                            |[e-mail]

--- Comment #7 from Olivier F. R. Dierick  ---
Hello. Marking this bug STAGED and filling the staged patchset field.

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

Adrien Fernandes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adrien_fernandes2@hotmail.c
                   |                            |om

--- Comment #8 from Adrien Fernandes  ---
Created attachment 64261
  --> https://bugs.winehq.org/attachment.cgi?id=64261
Meanwhile, not staged Wine

Actually, the normal Wine (not staged) doesn't pass the loading screen, it
sticks on "Recycling Hex Decimals" and the music keeps playing undefinitely.

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

Bruni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Bruni  ---
(In reply to Adrien Fernandes from comment #8)
> Created attachment 64261 [details]
> Meanwhile, not staged Wine
>
> Actually, the normal Wine (not staged) doesn't pass the loading screen, it
> sticks on "Recycling Hex Decimals" and the music keeps playing undefinitely.

Hello!

What version of mainline wine are you using?
Could you please attach the log?

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

--- Comment #10 from Olivier F. R. Dierick  ---
(In reply to Adrien Fernandes from comment #8)
> Created attachment 64261 [details]
> Meanwhile, not staged Wine
>
> Actually, the normal Wine (not staged) doesn't pass the loading screen, it
> sticks on "Recycling Hex Decimals" and the music keeps playing undefinitely.

Hello,

This is unrelated to the white characters issue this bug is about.
If your issue doesn't happen with wine-staging then it's already covered by
another staged bug somewhere.
If your issue happens with wine-staging then file a new bug.

Regards

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

--- Comment #11 from Bruni  ---
(In reply to Olivier F. R. Dierick from comment #10)
> (In reply to Adrien Fernandes from comment #8)
> > Created attachment 64261 [details]
> > Meanwhile, not staged Wine
> >
> > Actually, the normal Wine (not staged) doesn't pass the loading screen, it
> > sticks on "Recycling Hex Decimals" and the music keeps playing undefinitely.
>
> Hello,
>
> This is unrelated to the white characters issue this bug is about.
> If your issue doesn't happen with wine-staging then it's already covered by
> another staged bug somewhere.
> If your issue happens with wine-staging then file a new bug.
>
> Regards

Let him post the log, please.
Looks like he implies that bug 43709 got fixed.

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

--- Comment #12 from Paul Gofman  ---
(In reply to Bruni from comment #11)
> Let him post the log, please.
> Looks like he implies that bug 43709 got fixed.

If this discussion is about The Sims in mainstream Wine, there is no need for
the log, the reason is clear and it is yet fixed in Staging only (see Comment
#6).

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

--- Comment #13 from Olivier F. R. Dierick  ---
(In reply to Bruni from comment #11)
> Let him post the log, please.
> Looks like he implies that bug 43709 got fixed.

Hello,

I'm just trying to keep this bug about a single issue.

@Adrien Fernandes: Feel free to attach your log to bug 43709 directly as it
would show the evolution of that bug.

Regards

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

--- Comment #14 from Adrien Fernandes  ---
@Olivier F. R. Dierick

It's working with wine-staging 4.6, no problem, the issue is only with Wine 4.6
mainstream. What WINEDEBUG option could I add to get useful informations before
to post the log in 43709 ?

Kind regards.
Adrien

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

--- Comment #15 from Olivier F. R. Dierick  ---
(In reply to Adrien Fernandes from comment #14)
> @Olivier F. R. Dierick
>
> It's working with wine-staging 4.6, no problem, the issue is only with Wine
> 4.6 mainstream. What WINEDEBUG option could I add to get useful informations
> before to post the log in 43709 ?
>
> Kind regards.
> Adrien

Hello,

WINEDEBUG=+ddraw should be fine.

Regards

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

--- Comment #16 from Paul Gofman  ---
(In reply to Olivier F. R. Dierick from comment #15)
> (In reply to Adrien Fernandes from comment #14)
> > @Olivier F. R. Dierick
> >
> > It's working with wine-staging 4.6, no problem, the issue is only with Wine
> > 4.6 mainstream. What WINEDEBUG option could I add to get useful informations
> > before to post the log in 43709 ?
> >
> > Kind regards.
> > Adrien
>
> Hello,
>
> WINEDEBUG=+ddraw should be fine.
>
> Regards

Guys, which exactly the issue you are trying to debug? The (I believe already
documented) reason why The Sims are not working in mainstream Wine is _SYSMEM
render targets and depth buffer surfaces being attached to software device are
not supported. There are a few patches in Staging which add this support. It is
https://github.com/wine-staging/wine-staging/blob/master/patches/ddraw-Rende...
and it's dependencies.

[Bug 46948] Characters in The Sims Complete Collection render completely white

https://bugs.winehq.org/show_bug.cgi?id=46948

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |directx-d3d

[Bug 46948] Characters in The Sims Complete Collection render completely white

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46948

--- Comment #17 from Gijs Vermeulen  ---
The staging patch was upstreamed as
https://source.winehq.org/git/wine.git/commit/13ffebc7285198fe690aa44a5f70eb0c8fd3fa80,
please retest.

[Bug 46948] Characters in The Sims Complete Collection render completely white

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46948

Alexandr Oleynikov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|STAGED                      |RESOLVED

--- Comment #18 from Alexandr Oleynikov  ---
No longer an issue in 6.7

[Bug 46948] Characters in The Sims Complete Collection render completely white

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46948

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |13ffebc7285198fe690aa44a5f7
                   |                            |0eb0c8fd3fa80

[Bug 46948] Characters in The Sims Complete Collection render completely white

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46948

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #19 from Alexandre Julliard  ---
Closing bugs fixed in 6.8.