[Bug 11479] New: db: \r should be stripped from identifiers in SQL

http://bugs.winehq.org/show_bug.cgi?id=11479

Summary: db: \r should be stripped from identifiers in SQL
           Product: Wine
           Version: CVS/GIT
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: msi
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=10620)
 --> (http://bugs.winehq.org/attachment.cgi?id=10620)
stupid patch and testcase

While trying to compile the basic example in Wix, an query string is sent in to
MsiDatabaseOpenView() for which MSI_ParseSQL return 1. Eg:

trace:msi:MSI_DatabaseOpenViewW L"CREATE TABLE `_SummaryInformation` (
`PropertyId` INT NOT NULL, `Value\r` CHAR(255\r) NOT NULL LOCALIZABLE PRIMARY
KEY `PropertyId\r`)" 0x61ed98
trace:msi:MSI_ParseSQL Parse returned 1

To reproduce this error, the instructions in bug 11414, comment 10 applies.
Attached is a new test to msi/tests/db.c stupid and naive patch which just
strips the trailing \r if present.

[Bug 11479] db: \r should be stripped from identifiers in SQL

http://bugs.winehq.org/show_bug.cgi?id=11479

--- Comment #1 from James Hawkins   2008-02-05 13:05:39 ---
I already have a test case and fix ready to send in.

[Bug 11479] db: \r should be stripped from identifiers in SQL

http://bugs.winehq.org/show_bug.cgi?id=11479

--- Comment #2 from James Hawkins   2008-02-06 14:58:24 ---
Have you even tested that snippet in windows?  The test fails.

[Bug 11479] db: \r should be stripped from identifiers in SQL

http://bugs.winehq.org/show_bug.cgi?id=11479

--- Comment #3 from Johan Dahlin   2008-02-06 16:45:37 ---
James: No, I don't have access to a windows box.

Then I guess the error is somewhere else, reading lines from a stream or such.

[Bug 11479] db: \r should be stripped from identifiers in SQL

http://bugs.winehq.org/show_bug.cgi?id=11479

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #4 from James Hawkins   2008-02-17 21:06:40 ---
Invalid.  You can see the tests in wine/dlls/msi/tests/db.c.

[Bug 11479] db: \r should be stripped from identifiers in SQL

http://bugs.winehq.org/show_bug.cgi?id=11479

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from James Hawkins   2008-02-17 21:06:54 ---
Closing.

[Bug 11479] db: \r should be stripped from identifiers in SQL

http://bugs.winehq.org/show_bug.cgi?id=11479

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified