[Bug 47270] New: User shared data thread is always created

https://bugs.winehq.org/show_bug.cgi?id=47270

Bug ID: 47270
           Summary: User shared data thread is always created
           Product: Wine-staging
           Version: 4.9
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail]
      Distribution: ---

Due to the changes to "Fake Dlls" patch set, specifically for the 64-bit
syscalls, the user_shared_data is accessed in every Wine process. While this is
not incorrect, it does represent a change from the original intentions of the
"user_shared_data" patch set, which was to only create this extra thread, and
the associated overhead, on programs that *need* to access user_shared_data.

If this new behavior is going to stay, then it would probably be a good idea to
revisit the "user_shared_data" patch set. For instance, one might simplify it
to always create the user shared data thread. Alternatively, if the new
behavior is undesirable, then we should find a way to prevent it.

(I am not personally convinced that the theoretical overhead is a problem.
There was a long discussion about this on the old wine-staging patch submission
website which no longer exists.)

[Bug 47270] User shared data thread is always created

https://bugs.winehq.org/show_bug.cgi?id=47270

--- Comment #1 from Andrew Wesie  ---
This issue can probably be closed if you want to keep the conversation in bug
45642. I hadn't seen it previously.

[Bug 47270] User shared data thread is always created

https://bugs.winehq.org/show_bug.cgi?id=47270

--- Comment #2 from Zebediah Figura  ---
(In reply to Andrew Wesie from comment #1)
> This issue can probably be closed if you want to keep the conversation in
> bug 45642. I hadn't seen it previously.

It may make sense to leave this bug open, but yeah, it'd probably be better to
keep all of that conversation in one place.

[Bug 47270] User shared data thread is always created

https://bugs.winehq.org/show_bug.cgi?id=47270

pattietreutel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 47270] User shared data thread is always created

https://bugs.winehq.org/show_bug.cgi?id=47270

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Fabian Maurer  ---
Just for the record, how bad is the overhead? In theory, couldn't we update the
data in wineserver and just map it into all other processes? Shared memory
should work, right?

[Bug 47270] User shared data thread is always created

https://bugs.winehq.org/show_bug.cgi?id=47270

--- Comment #4 from Andrew Wesie  ---
I should really copy paste the previous thread about this. I'll do that when I
am at my computer.

The concern about a shared mapping updated from wineserver is that different
processes may have different advertised OS versions. This means that different
processes may have different data in their shared user data page.

[Bug 47270] User shared data thread is always created

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47270

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |ABANDONED

--- Comment #5 from Zebediah Figura  ---
I'm not really sure what to do with this bug, but since the relevant patches
have been completely rewritten, I'm just going to resolve it as ABANDONED.

[Bug 47270] User shared data thread is always created

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47270

--- Comment #6 from Austin English  ---
Closing.

[Bug 47270] User shared data thread is always created

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47270

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Austin English  ---
Closing.