[Bug 18895] New: Thief 3 crashes on closing.

http://bugs.winehq.org/show_bug.cgi?id=18895

Summary: Thief 3 crashes on closing.
           Product: Wine
           Version: 1.1.23
          Platform: PC-x86-64
               URL: http://www.eidos.de/downloads/search.html?gmid=174
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=21737)
 --> (http://bugs.winehq.org/attachment.cgi?id=21737)
Testcase to trigger the crash in d3d8.

Thief 3 crashes in DeletePixelShader if it closes/release all the resources.
The game deletes some resources twice and there could the crash happen.

The attached test case let wine crash in the same way. (The only difference is
it uses VertexShader instead of PixelShader, but the code which is responsible
for the crash is shared between both).

[Bug 18895] Thief 3 crashes on closing.

http://bugs.winehq.org/show_bug.cgi?id=18895

Rico  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, testcase

[Bug 18895] Thief 3 crashes on closing.

http://bugs.winehq.org/show_bug.cgi?id=18895

--- Comment #1 from Henri Verbeet   2009-06-12 03:28:33 ---
Could you check the return values for DeletePixelShader() as well? It would
probably make sense to extend test_shader() in device.c. As for fixing this, we
probably just need to store the handle type as well instead of just a pointer
to the object. I'll write a patch for that.

[Bug 18895] Thief 3 crashes on closing.

http://bugs.winehq.org/show_bug.cgi?id=18895

Rico  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21737|0                           |1
        is obsolete|                            |

--- Comment #2 from Rico   2009-06-12 05:15:36 ---
Created an attachment (id=21750)
 --> (http://bugs.winehq.org/attachment.cgi?id=21750)
new testcase with result checking

The result is a little bit curious, at least on my xp box with 8800GT.
- IDirect3DDevice8_DeleteVertexShader returns D3DERR_INVALIDCALL
- IDirect3DDevice8_DeletePixelShader returns D3D_OK

Could you verify the result?

[Bug 18895] Thief 3 crashes on closing.

http://bugs.winehq.org/show_bug.cgi?id=18895

--- Comment #3 from Henri Verbeet   2009-06-15 03:41:13 ---
Created an attachment (id=21801)
 --> (http://bugs.winehq.org/attachment.cgi?id=21801)
patch

How does this patch work?

[Bug 18895] Thief 3 crashes on closing.

http://bugs.winehq.org/show_bug.cgi?id=18895

Rico  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #4 from Rico   2009-06-15 07:31:15 ---
The patch works fine.

[Bug 18895] Thief 3 crashes on closing.

http://bugs.winehq.org/show_bug.cgi?id=18895

--- Comment #5 from Henri Verbeet   2009-06-16 12:19:51 ---
Should be fixed in current git.

[Bug 18895] Thief 3 crashes on closing.

http://bugs.winehq.org/show_bug.cgi?id=18895

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Dmitry Timoshkov   2009-06-16 23:22:30 ---
Fixed.

[Bug 18895] Thief 3 crashes on closing.

http://bugs.winehq.org/show_bug.cgi?id=18895

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard   2009-06-19 11:09:51 ---
Closing bugs fixed in 1.1.24.