[Bug 17917] New: New *.ini files contain spurious [] lines

http://bugs.winehq.org/show_bug.cgi?id=17917

Summary: New *.ini files contain spurious [] lines
           Product: Wine
           Version: 1.1.18
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

This is a regression against 1.1.17. It affects the win.ini and system.ini
files that wine creates itself, as well as e.g. Setup.ini files created by
InstallShield.

The number of [] lines is variable.

Can perform regression testing if nobody knows out of the head what may have
caused this.

[Bug 17917] New *.ini files contain spurious [] lines

http://bugs.winehq.org/show_bug.cgi?id=17917

Jörg Höhle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression, source

[Bug 17917] New *.ini files contain spurious [] lines

http://bugs.winehq.org/show_bug.cgi?id=17917

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|regression, source          |

--- Comment #1 from Jeff Zaroyko   2009-03-31 17:53:26 ---
confirming... first 38 lines of win.ini are "[]"

[Bug 17917] New *.ini files contain spurious [] lines

http://bugs.winehq.org/show_bug.cgi?id=17917

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression, source

--- Comment #2 from Austin English   2009-03-31 20:22:44 ---
A regression test is needed...

[Bug 17917] New *.ini files contain spurious [] lines

http://bugs.winehq.org/show_bug.cgi?id=17917

Jörg Höhle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |kernel32

--- Comment #3 from Jörg Höhle   2009-04-01 11:08:08 ---
7c3529f1cc6a3ce6f0a403c337926c8fc9fbfc57 is first bad commit
Author: James Hawkins 
Date:   Sun Mar 22 14:37:44 2009 -0700

kernel32: Handle writing empty sections and keys in
WritePrivateProfileString.

:040000 040000 ceb84e9b2c4d5953beced52f7ba10d0859478210
ebe9b70ade078cd5ad10725329b402386bcfc837 M      dlls
bisect run success

This is the first time I could (partly) use git bisect run <script>,
as the test is easy to automate (unlike failing apps).
If anybody is interested:
#! /bin/sh
#CC="ccache gcc" ./configure || exit 125
CC="ccache gcc" make depend all || exit 125
rm -rf $HOME/.wine
./wine cmd /c echo hello || exit 125
fgrep -q '[]' $HOME/.wine/drive_c/windows/system.ini
test $? -eq 1

[Bug 17917] New *.ini files contain spurious [] lines

http://bugs.winehq.org/show_bug.cgi?id=17917

Paul Vriens  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Paul Vriens   2009-04-02 04:48:45 ---
Looks like the number of empty sections ([]) is equal to the total number of
values - 1. Coincidence?

This piece from profile.c looks suspicious:

*p++ = '[';
        if (section->name[0])
        {
            strcpyW( p, section->name );
            p += strlenW(p);
        }
        *p++ = ']';
        *p++ = '\r';
        *p++ = '\n';

If we don't have a section name we will write "[]\r\n".

[Bug 17917] New *.ini files contain spurious [] lines

http://bugs.winehq.org/show_bug.cgi?id=17917

--- Comment #5 from Paul Vriens   2009-04-02 05:21:34 ---
Sent patch:

http://www.winehq.org/pipermail/wine-patches/2009-April/071432.html

[Bug 17917] New *.ini files contain spurious [] lines

http://bugs.winehq.org/show_bug.cgi?id=17917

--- Comment #6 from Paul Vriens   2009-04-03 05:13:43 ---
Patch is in GIT:

http://source.winehq.org/git/wine.git/?a=commitdiff;h=9a10234ef2b5212ba44b82...

[Bug 17917] New *.ini files contain spurious [] lines

http://bugs.winehq.org/show_bug.cgi?id=17917

Jörg Höhle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Jörg Höhle   2009-04-07 04:26:37 ---
Patch not tested with InstallShield, but windows/system.ini is back to normal.

[Bug 17917] New *.ini files contain spurious [] lines

http://bugs.winehq.org/show_bug.cgi?id=17917

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard   2009-04-10 11:25:01 ---
Closing bugs fixed in 1.1.19.