[Bug 52345] New: Unclosed right-side double quote in if command breaks wine cmd

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52345

Bug ID: 52345
           Summary: Unclosed right-side double quote in if command breaks
                    wine cmd
           Product: Wine
           Version: 6.0.2
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: cmd
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Unhandled exception: page fault on read access to 0xfffffffc in 32-bit code
(0x70ba1370).
Register dump:
 CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b
 EIP:70ba1370 ESP:007b2f74 EBP:007b2fc8 EFLAGS:00010202(  R- --  I   - - - )
 EAX:007b31e0 EBX:ffebf098 ECX:ffebf098 EDX:00067227
 ESI:fffffff8 EDI:00672270
Stack dump:
0x007b2f74:  00000000 00140f68 70ba6513 007b31e0
0x007b2f84:  00140f68 ffebf098 004016e4 0000000c
0x007b2f94:  00140f68 00002000 007b2fc0 00000002
0x007b2fa4:  00140f68 00000000 0041e476 00140ca0
0x007b2fb4:  007b71e0 00000000 ffebf098 00000000
0x007b2fc4:  00000000 007b2fe8 70ba7982 007b31e0
Backtrace:
=>0 0x70ba1370 EntryPoint+0xffffffff() in ucrtbase (0x007b2fc8)
  1 0x00000000 (0x007b2fc8)
  2 0x70ba7982 EntryPoint+0xffffffff() in ucrtbase (0x007b2fe8)
  3 0x004201fc EntryPoint+0xffffffff() in cmd (0x00000000)
  4 0x00424a50 EntryPoint+0xffffffff() in cmd (0x007bfef8)
  5 0x00426dc8 in cmd (+0x26dc7) (0x007bff30)
  6 0x7b62e260 EntryPoint+0xffffffff() in kernel32 (0x007bff48)
  7 0x7bc5bab7 EntryPoint+0xffffffff() in ntdll (0x007bff5c)
  8 0x7bc5bd10 EntryPoint+0xffffffff() in ntdll (0x007bffec)
0x70ba1370 EntryPoint+0xffffffff in ucrtbase: movl    0x4(%esi),%eax
Modules:
Module    Address            Debug info    Name (18 modules)
PE      400000-  5b5000    Dwarf           cmd
PE    61740000-61829000    Deferred        advapi32
PE    62fc0000-631f2000    Deferred        rpcrt4
PE    63480000-6349c000    Deferred        version
PE    63bc0000-63c02000    Deferred        shcore
PE    64a40000-64b5e000    Deferred        shlwapi
PE    68500000-6864b000    Deferred        combase
PE    6a400000-6a884000    Deferred        ole32
PE    6bc00000-6bca1000    Deferred        sechost
PE    6bcc0000-6be9c000    Deferred        setupapi
PE    6c9c0000-6cf40000    Deferred        gdi32
PE    6ed00000-6f392000    Deferred        user32
PE    70b40000-70df3000    Dwarf           ucrtbase
PE    71200000-71248000    Deferred        imm32
PE    7b000000-7b30c000    Deferred        kernelbase
PE    7b600000-7b928000    Dwarf           kernel32
PE    7bc00000-7bedf000    Dwarf           ntdll
PE    7dfc0000-7e897000    Deferred        shell32
Threads:
process  tid      prio (all id:s are in hex)
00000038 services.exe
    0000003c    0
    00000040    0
    0000004c    0
    00000070    0
    00000088    0
    000000a4    0
    000000c4    0
    000000dc    0
00000044 winedevice.exe
    00000048    0
    00000054    0
    00000058    0
    0000005c    0
00000060 plugplay.exe
    00000064    0
    00000074    0
    00000078    0
    0000007c    0
    00000098    0
00000068 explorer.exe
    0000006c    0
    000000a8    0
    000000bc    0
00000080 winedevice.exe
    00000084    0
    0000008c    0
    00000090    0
    00000094    0
    000000a0    0
    000000ac    0
    000000b0    0
000000b4 svchost.exe
    000000b8    0
    000000cc    0
    000000d0    0
000000d4 rpcss.exe
    000000d8    0
    000000e0    0
    000000e4    0
    000000e8    0
    000000ec    0
    000000f0    0
000001a4 cmd.exe
    000001a8    0
000001ac conhost.exe
    000001b0    0
    000001b4    0
000002dc notepad++.exe
    000002e0    0
    000002ec    0
    000002fc    0
000007e0 (D) C:\windows\system32\cmd.exe
    000007e4    0 <==
    000007fc    0
000007e8 conhost.exe
    000007ec    0
    000007f0    0
System information:
    Wine build: wine-6.0.2
    Platform: i386 (WOW64)
    Version: Windows 10
    Host system: Linux
    Host version: 5.4.0-92-generic

[Bug 52345] Unclosed right-side double quote in if command breaks wine cmd

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52345

Eric Pouech  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Eric Pouech  ---
thanks for the report, can you post the exact command you're using
TIA

[Bug 52345] Unclosed right-side double quote in if command breaks wine cmd

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52345

--- Comment #2 from Emily Seville  ---
(In reply to Eric Pouech from comment #1)
> thanks for the report, can you post the exact command you're using
> TIA

Here it is:

if x == " echo 1

[Bug 52345] Unclosed right-side double quote in if command breaks wine cmd

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52345

--- Comment #3 from Eric Pouech  ---
Created attachment 71518
  --> https://bugs.winehq.org/attachment.cgi?id=71518
proposed patch

confirming
patch sent upstream

[Bug 52345] Unclosed right-side double quote in if command breaks wine cmd

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52345

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch
           Severity|major                       |minor

[Bug 52345] Unclosed right-side double quote in if command breaks wine cmd

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52345

Vijay Kamuju  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |[e-mail]

--- Comment #4 from Vijay Kamuju  ---
This is now fixed, wine does not crash with version 9.12
I dont know the exact commit, which fixed it.

[Bug 52345] Unclosed right-side double quote in if command breaks wine cmd

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52345

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 9.13.