[Bug 11553] New: Paintbrush movement becomes erratic

http://bugs.winehq.org/show_bug.cgi?id=11553

Summary: Paintbrush movement becomes erratic
           Product: Wine
           Version: 0.9.54.
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

If I select a large brush size, the brush seems to crawl behind the mouse. I'm
not sure if this is due to my graphics card. I have an onboard ATI Technologies
Inc Rage XL rev 39, Mem @ 0xf1000000/24, 0xf2041000/12, I/O @ 0x9c00/8, which
is supposed to be very slow, but I'm not sure if its enough to cause this
behavior.

Could someone try setting a large paintbrush size and move it around to
determine if this is really a bug? For more information, please see screenshot:

http://download.erasmix.net/CS2-WINE/Screenshot-9.png

[Bug 11553] Paintbrush movement becomes erratic

http://bugs.winehq.org/show_bug.cgi?id=11553

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |minor

--- Comment #1 from Vitaliy Margolen   2008-02-11 21:11:44 ---
Test it on a faster PC I guess. Not major.

[Bug 11553] Paintbrush movement becomes erratic with large brush in photoshop

http://bugs.winehq.org/show_bug.cgi?id=11553

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|Paintbrush movement becomes |Paintbrush movement becomes
                   |erratic                     |erratic with large brush in
                   |                            |photoshop

--- Comment #2 from Dan Kegel   2008-02-11 21:25:58 ---
Can you boot the same machine in Windows and see
if Photoshop for Windows performs better?

Also, how many pixels large is the brush when problems happen?

[Bug 11553] Paintbrush movement becomes erratic with large brush in photoshop

http://bugs.winehq.org/show_bug.cgi?id=11553

--- Comment #3 from Erasmo Acosta   2008-02-11 21:36:31 ---
(In reply to comment #2)

Sorry, I don't have dual boot on. I only have one box with linux and one with
Windows, I can't test it on a different machine.

The size of the brush is a 1000 pixels, you can see it on the screenshot :-)

If the bug is confirmed, the severity should be raised. It's impossible to
control the brush.

[Bug 11553] Paintbrush movement becomes erratic with large brush in photoshop

http://bugs.winehq.org/show_bug.cgi?id=11553

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |download

--- Comment #4 from Dan Kegel   2008-02-12 16:28:48 ---
Tested this with Photoshop 6 (last version without a time
limit on the trial).  Used largest possible brush size, 999 pixels.
Sure enough, it's slower on Linux than on Windows, enough that
the mouse is hard to control.  (And this was on a damn
fast computer with a great graphics card and craploads of RAM.)

Perhaps this is a case of not throwing away stale mouse
motion events?  I don't think a DIBengine would help,
as I don't see any messages like those in 
http://bugs.winehq.org/show_bug.cgi?id=421#c26

Can you tell us how frequently you use large brushes,
what size they tend to be, and what you use them for?

[Bug 11553] Paintbrush movement becomes erratic with large brush in photoshop

http://bugs.winehq.org/show_bug.cgi?id=11553

--- Comment #5 from Erasmo Acosta   2008-02-12 16:59:33 ---
(In reply to comment #4)

It depends on the photographer, the image, and the kind of correction. In my
case using a smaller brush size would leave brush patterns on areas of the
image with a smooth pattern (like the sky or water). The larger the image, the
more likely you'll need "large" brush sizes. My images are 12.8 megapixels.

Furthermore, the size I used on the test, 1000 pix, is not by far the largest I
normally use. So to answer your question, YES very common.

I was really hoping this was not a bug, but related to my graphics card.
However, since it is, I'd advice you to raise the severity.

[Bug 11553] Paintbrush movement becomes erratic with large brush in photoshop

http://bugs.winehq.org/show_bug.cgi?id=11553

--- Comment #6 from Erasmo Acosta   2008-02-12 17:30:06 ---
(In reply to comment #5)

Yes I forgot. Mostly you use them for Dodge & Burning, but they have loads of
uses. Like when you do bracketing and have two exposures of the same scene, and
you use a brush to reveal portions of one scene that are dark on the other one.
I've also used them to clone out a piece of a street light.

[Bug 11553] Paintbrush movement becomes erratic with large brush in photoshop

http://bugs.winehq.org/show_bug.cgi?id=11553

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Dmitry Timoshkov   2008-02-13 08:23:03 ---
This seems to be related to a missing optimized code path for SRCINVERT in
dlls/winex11.drv/bitblt.c,BITBLT_InternalStretchBlt(). Once I add SRCINVERT
case to any existing case statements (say DSTINVERT) any slowdown in mouse
movements goes away, though painting apparently becomes wrong. Now what needs
to be done is a proper implementation of SRCINVERT in X11 graphics terms.
I'm not an expert in that, any takers?

[Bug 11553] Paintbrush movement becomes erratic with large brush in photoshop

http://bugs.winehq.org/show_bug.cgi?id=11553

--- Comment #8 from Dmitry Timoshkov   2008-02-21 04:11:46 ---
Created an attachment (id=10879)
 --> (http://bugs.winehq.org/attachment.cgi?id=10879)
Ad an optimized path for BitBlt(SRCINVERT) to winex11.drv

Although Alexandre said that the code already does as much as it can, I decided
to try anyway. Attached patch makes mouse movements with very large brush sizes
as smooth as with small ones for me.

[Bug 11553] Paintbrush movement becomes erratic with large brush in photoshop

http://bugs.winehq.org/show_bug.cgi?id=11553

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |winex11.drv

[Bug 11553] Paintbrush movement becomes erratic with large brush in photoshop

http://bugs.winehq.org/show_bug.cgi?id=11553

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10879|Ad an optimized path for    |Add an optimized path for
        description|BitBlt(SRCINVERT) to        |BitBlt(SRCINVERT) to
                   |winex11.drv                 |winex11.drv

[Bug 11553] Paintbrush movement becomes erratic with large brush in photoshop

http://bugs.winehq.org/show_bug.cgi?id=11553

--- Comment #9 from Dmitry Timoshkov   2008-02-21 04:25:25 ---
I sent it to wine-patches.

[Bug 11553] Paintbrush movement becomes erratic with large brush in photoshop

http://bugs.winehq.org/show_bug.cgi?id=11553

--- Comment #10 from Dmitry Timoshkov   2008-02-21 07:45:26 ---
Alexandre committed the patch. Please retest and close if appropriate.

[Bug 11553] Paintbrush movement becomes erratic with large brush in photoshop

http://bugs.winehq.org/show_bug.cgi?id=11553

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Dan Kegel   2008-02-21 10:45:11 ---
LGTM, thanks!

[Bug 11553] Paintbrush movement becomes erratic with large brush in photoshop

http://bugs.winehq.org/show_bug.cgi?id=11553

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Dan Kegel   2008-02-22 11:40:21 ---
0.9.56 released, so closing all bugs marked as RESOLVED FIXED.