[Bug 12640] New: Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

Summary: Applications written in Delphi has got minimize,
                    maximize and size controls disabled for its item in
                    taskbar
           Product: Wine
           Version: CVS/GIT
          Platform: Other
               URL: http://www.pspad.com
        OS/Version: other
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: winex11.drv
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

This bug was risen after correcting of bug 12264.
I am testing this on PSPad on Gnome 2.22.
The item in taskbar of this application have controls for minimize, maximize
and size disabled. In 0.9.58 is everything OK; in 0.9.59 was no item in taskbar
(bug 12264).

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

otula  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from otula   2008-04-18 08:37:20 ---
The same problem in KDE and Fluxbox.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

Giuseppe Bilotta  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Giuseppe Bilotta   2008-04-19 01:53:44 ---
Experiencing the same problem with The Bat! too.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #3 from Austin English   2008-04-19 17:55:42 ---
Please run a regression test:
http://wiki.winehq.org/RegressionTesting

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #4 from Petr Dlouhý   2008-04-19 18:04:06 ---
I think, it is impossible. As I have already written. In 0.9.58 is it working,
and in 0.9.59 it is broken completely (no item in taskbar) by bug 12264. This
was risen after fixing that bug.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #5 from Austin English   2008-04-19 18:17:24 ---
(In reply to comment #4)
> I think, it is impossible. As I have already written. In 0.9.58 is it working,
> and in 0.9.59 it is broken completely (no item in taskbar) by bug 12264. This
> was risen after fixing that bug.

No, not impossible, just more difficult ;-).

http://wiki.winehq.org/ReverseRegressionTesting

May help. Essentially, you'll need to identify the patch(es) that fixed the
problem, then apply the patches before each regression test.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #6 from Petr Dlouhý   2008-04-19 18:22:05 ---
And what if it is broken by the patch that is fixing bug 12264?

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #7 from Petr Dlouhý   2008-04-19 19:00:27 ---
> And what if it is broken by the patch that is fixing bug 12264?

I was wrong. Fortunately The Bat! is affected just by this bug, and not by bug
12264. So I will make normal regression testing on The Bat!.
This is also meaning, that I was probably wrong that Delphi written
applications are affected.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

Petr Dlouhý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #8 from Petr Dlouhý   2008-04-19 19:01:25 ---
*** This bug has been confirmed by popular vote. ***

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #9 from Petr Dlouhý   2008-04-19 21:49:27 ---
Created an attachment (id=12322)
 --> (http://bugs.winehq.org/attachment.cgi?id=12322)
bisect-log

The result is this:
http://source.winehq.org/git/wine.git/?a=commit;h=e1ee7a3b8b17f56fd282d89c89...

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #10 from Petr Dlouhý   2008-04-19 21:54:10 ---
Sorry, I made a mistake (I run wine instead of ~/....../wine from certain
time). The result I sent is wrong. I have to rerun the regression testing.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #11 from Dmitry Timoshkov   2008-04-20 00:54:33 ---
There is no need for a regression test, the result will be meaningless.

Main window disappearing from the task bar has beed caused by the patch
which marked owned windows as NET_WM_STATE_SKIP_TASKBAR. That has caused
a "regression" for apps developed in Delphi since they use a visible, but
zero sized (0x0) window as an owner for main app window. Wine didn't map
(make visible) zero sized windows because Window managers don't handle
them gracefully. Then I've sent a patch which maps zero sized windows
and fixes the previous "regression". Now the problem is that apparently
Window Managers disable minimize,maximize and size functions for zero-sized
windows, and that's what needs to be worked on/around now.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #12 from Giuseppe Bilotta   2008-04-20 02:34:46 ---
The situation seems to be more complicated than that: for example, The Bat! has
no minimize button, but it has a maximize button and I can resize it. Its
taskbar button has a minimize command, but the maximize and shade commands are
disabled.

Doing something like minimizing and restoring restores the functionality. I
think this happens because something happens to the zero-sized control window
although it's marked non-resizable (this is, however, something that deserves a
different bug report because it happened even before the 'disappearing taskbar
button' bug).

Also, there are lots of focusing problems because while for example clicking on
the taskbar button brings the visible non-zero-sized window to front, it
doesn't give it focus, which causes problems with e.g.  dead keys. Also
changing focus via alt-tab gives lots of strange problems. Not to mention that
the app window comes up with the ugly <2> specifier that WMs put to
disambiguate windows with the same name.

IMO, mapping the zero-sized window was not the best way fix for the
disappearing taskbar, precisely because of all these problems (the patch I
proposed to fix bug 12264 does not present this problem, AFAICS): we should
just accept the fact that X window managers can't handle the zero-sized control
window properly, and get done with it.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #13 from Dmitry Timoshkov   2008-04-20 07:11:09 ---
(In reply to comment #12)
> IMO, mapping the zero-sized window was not the best way fix for the
> disappearing taskbar, precisely because of all these problems (the patch I
> proposed to fix bug 12264 does not present this problem, AFAICS): we should
> just accept the fact that X window managers can't handle the zero-sized control
> window properly, and get done with it.

If you have a better idea feel free to send a patch.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #14 from Giuseppe Bilotta   2008-04-20 07:27:39 ---
Well, my patch was attached to bug 12264 because it was supposed to fix that
bug. I can reattach it here, but it's obviously supposed to be applied after
reverting commit 15c0bcb3d8eff7c38def24b58633bb1d6116d8c4

Do you want me to make a single patch that reverts the commit and applies my
proposed solution?

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #15 from Giuseppe Bilotta   2008-04-20 07:32:31 ---
Created an attachment (id=12338)
 --> (http://bugs.winehq.org/attachment.cgi?id=12338)
Patch to add windows with unmapped owners to the taskbar

I'm attaching that solves bug 12264 by adding to the taskbar the windows whose
owners are unmapped. This is to be applied after reverting
15c0bcb3d8eff7c38def24b58633bb1d6116d8c4 and should resolve this bug too.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #16 from Dmitry Timoshkov   2008-04-20 07:38:25 ---
(In reply to comment #15)
> Created an attachment (id=12338)

--> (http://bugs.winehq.org/attachment.cgi?id=12338) [details]
> Patch to add windows with unmapped owners to the taskbar
> I'm attaching that solves bug 12264 by adding to the taskbar the windows whose
> owners are unmapped. This is to be applied after reverting
> 15c0bcb3d8eff7c38def24b58633bb1d6116d8c4 and should resolve this bug too.

I don't see what has changed since then which suddenly makes this patch
correct.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #17 from Giuseppe Bilotta   2008-04-20 07:50:33 ---
Nothing has changed. The point is, my patch fixes bug 12264 (i.e. the
disappearing taskbar button) without introducing the issues which are
introduced by mapping the zero-sized window (i.e. the issues presented in this
bug).

Now, although I agree with you that in theory fixing it by mapping the
zero-sized window would be 'more correct', I also find that the inability of
X's window managers to cope with such window adequately causes such a
theoretically better fix to behave *worse*, in practice, than my patch which
is, admittely, a hack.

What I fear is that your fix preludes to a neverending series of following
hacks to work around all the issues zero-sized windows cause to window managers
in X. So in the end my hack would turn out to be, if not else, simpler and
cleaner.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #18 from Dmitry Timoshkov   2008-04-20 08:06:50 ---
Actually that's a contrary to your understanding. You propose a hack
which neither properly fixes the problem, nor is a clean fix. With Wine
it's always a challenge to both: replicate what Windows actually does
(and therefore what applications expect), and cope with limitations of
an underlying system (which quite frequently leads to patches we send to
other projects to fix the bugs preventing Wine to work properly).

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #19 from otula   2008-04-20 15:09:37 ---
It works fine with Wine 0.9.60 again.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #20 from Austin English   2008-04-20 23:41:53 ---
*** Bug 12697 has been marked as a duplicate of this bug. ***

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.0.0

--- Comment #21 from Dan Kegel   2008-04-21 05:00:34 ---
Nominating for 1.0 since it's a recent regression that affects
multiple apps.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

Vincent Hardy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

Jan Niklas Hasse  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #22 from Dmitry Timoshkov   2008-05-01 01:27:23 ---
Created an attachment (id=12610)
 --> (http://bugs.winehq.org/attachment.cgi?id=12610)
Do not use dialog window type

The problem is that at least Metacity disables minimize/maximize/fullscreen
capabilities for windows with _NET_WM_WINDOW_TYPE_DIALOG type.

Does the attached patch help?

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #23 from Dmitry Timoshkov   2008-05-01 05:26:31 ---
I sent the patch to wine-patches.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #24 from Petr Dlouhý   2008-05-01 06:51:46 ---
Created an attachment (id=12617)
 --> (http://bugs.winehq.org/attachment.cgi?id=12617)
small window

I tried the patch, but it didn't repair everything. The "Minimize" item is
working, but the "Maximize" item is still disabled and "move" item is acting
wierdely - there is something what may be realy small window (I am sending
screenshot of "it" in attachment) which is moved instead of the main window of
PSPad.
I am using Gnome, as I have writen earlier.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #25 from Dmitry Timoshkov   2008-05-01 07:34:46 ---
(In reply to comment #24)
> I tried the patch, but it didn't repair everything. The "Minimize" item is
> working, but the "Maximize" item is still disabled and "move" item is acting
> wierdely - there is something what may be realy small window (I am sending
> screenshot of "it" in attachment) which is moved instead of the main window of
> PSPad.

The patch was aiming to help only with minimizing. I don't think that
you really supposed to resize a zero-sized owner even under Windows.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #26 from Petr Dlouhý   2008-05-01 12:14:57 ---
Aha, you are right, on Windows is not possible to resize, maximize or move the
window from the taskbar item, but the controls are not displayed at all instead
of being disabled. It is not possible to move the window, so the zero sized
window never gets visible.
Should I report this as a new bug?

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #27 from Alexandre Julliard   2008-05-01 13:41:53 ---
I committed a fix, please retest.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

--- Comment #28 from Petr Dlouhý   2008-05-01 14:53:50 ---
In newest GIT is "minimize" working, it is working also "maximize", "move" and
"change size". It seems than, that it is working better than on native Windows
:-)

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #29 from Alexandre Julliard   2008-05-02 12:38:13 ---
Closing bugs fixed in 0.9.61.

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

Vincent Hardy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]  |

[Bug 12640] Applications written in Delphi has got minimize, maximize and size controls disabled for its item in taskbar

http://bugs.winehq.org/show_bug.cgi?id=12640

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified