[Bug 36122] New: valgrind possible leak in winemenubuilder/winemenubuilder.c

https://bugs.winehq.org/show_bug.cgi?id=36122

Bug ID: 36122
           Summary: valgrind possible leak in
                    winemenubuilder/winemenubuilder.c
           Product: Wine
           Version: 1.7.17
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: normal
          Priority: P2
         Component: programs
          Assignee: [e-mail]
          Reporter: [e-mail]

==22312== 28 bytes in 1 blocks are possibly lost in loss record 164 of 578
==22312==    at 0x7BC4C735: notify_alloc (heap.c:255)
==22312==    by 0x7BC50F79: RtlAllocateHeap (heap.c:1716)
==22312==    by 0x510B8B6: COMPOBJ_DllList_Add (compobj.c:526)
==22312==    by 0x510DBF2: apartment_getclassobject (compobj.c:1335)
==22312==    by 0x511133C: get_inproc_class_object (compobj.c:2894)
==22312==    by 0x51117FB: CoGetClassObject (compobj.c:3032)
==22312==    by 0x5111DBD: CoCreateInstance (compobj.c:3197)
==22312==    by 0x47767A7: Process_Link (winemenubuilder.c:3229)
==22312==    by 0x4778134: wWinMain (winemenubuilder.c:3703)
==22312==    by 0x4778869: wmain (exe_wmain.c:51)
==22312==    by 0x4778744: __wine_spec_exe_wentry (exe_wentry.c:36)
==22312==    by 0x7B864247: ??? (process.c:1045)
==22312==    by 0x7B864394: start_process (process.c:1097)
==22312==    by 0x7BC87087: ??? (signal_i386.c:2571)
==22312==    by 0x7BC870D0: call_thread_func (signal_i386.c:2630)
==22312==    by 0x7BC87065: ??? (signal_i386.c:2571)
==22312==    by 0x7BC5A1C0: start_process (loader.c:2840)
==22312==    by 0x401B03C: ??? (port.c:60)
==22312==

exposed by msi/tests/action.c

[Bug 36122] valgrind possible leak in winemenubuilder/winemenubuilder.c

https://bugs.winehq.org/show_bug.cgi?id=36122

--- Comment #1 from Austin English  ---
and lots of it in setupapi/tests/install.c as well

[Bug 36122] valgrind possible leak in winemenubuilder/winemenubuilder.c

https://bugs.winehq.org/show_bug.cgi?id=36122

--- Comment #2 from Austin English  ---
==27820== 28 bytes in 1 blocks are possibly lost in loss record 166 of 590
==27820==    at 0x7BC50A9B: RtlAllocateHeap (heap.c:255)
==27820==    by 0x5232BB8: apartment_getclassobject (compobj.c:526)
==27820==    by 0x5235FC6: get_inproc_class_object (compobj.c:2894)
==27820==    by 0x5238D2F: CoGetClassObject (compobj.c:3032)
==27820==    by 0x52394B7: CoCreateInstance (compobj.c:3197)
==27820==    by 0x48637A0: convert_to_native_icon.isra.5.constprop.11
(winemenubuilder.c:391)
==27820==    by 0x486482D: extract_icon (winemenubuilder.c:1342)
==27820==    by 0x48658AD: InvokeShellLinker (winemenubuilder.c:2865)
==27820==    by 0x486680D: Process_Link (winemenubuilder.c:3250)
==27820==    by 0x4866D14: wWinMain (winemenubuilder.c:3703)
==27820==    by 0x4869C99: wmain (exe_wmain.c:51)
==27820==    by 0x4869B74: __wine_spec_exe_wentry (exe_wentry.c:36)
==27820==    by 0x7B85EDFB: ??? (in
/home/austin/wine-valgrind-known/dlls/kernel32/kernel32.dll.so)
==27820==    by 0x7B85FE12: start_process (process.c:1097)
==27820==    by 0x7BC80ABF: ??? (in
/home/austin/wine-valgrind-known/dlls/ntdll/ntdll.dll.so)
==27820==    by 0x7BC83A6C: call_thread_func (signal_i386.c:2630)
==27820==    by 0x7BC80A9D: ??? (in
/home/austin/wine-valgrind-known/dlls/ntdll/ntdll.dll.so)
==27820==    by 0x7BC53F0D: start_process (loader.c:2840)
==27820==    by 0x401BC7C: ??? (in
/home/austin/wine-valgrind-known/libs/wine/libwine.so.1.0)
==27820==

[Bug 36122] valgrind shows a definite leak in winemenubuilder/winemenubuilder.c

https://bugs.winehq.org/show_bug.cgi?id=36122

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|valgrind possible leak in   |valgrind shows a definite
                   |winemenubuilder/winemenubui |leak in
                   |lder.c                      |winemenubuilder/winemenubui
                   |                            |lder.c

--- Comment #3 from Austin English  ---
Got a definite leak:
==28829== 80 bytes in 4 blocks are definitely lost in loss record 326 of 572
==28829==    at 0x7BC4C6DF: notify_alloc (heap.c:255)
==28829==    by 0x7BC50F23: RtlAllocateHeap (heap.c:1716)
==28829==    by 0x501ECAC: CreatePropertyBag2 (propertybag.c:293)
==28829==    by 0x501DAB6: PngEncoder_CreateNewFrame (pngformat.c:1617)
==28829==    by 0x495EBDD: convert_to_native_icon (wincodec.h:4374)
==28829==    by 0x49617CD: platform_write_icon (winemenubuilder.c:1342)
==28829==    by 0x49619EA: extract_icon (winemenubuilder.c:1373)
==28829==    by 0x4966E3F: InvokeShellLinker (winemenubuilder.c:2865)
==28829==    by 0x49688DB: Process_Link (winemenubuilder.c:3250)
==28829==    by 0x496A122: wWinMain (winemenubuilder.c:3703)
==28829==    by 0x496A853: wmain (exe_wmain.c:51)
==28829==    by 0x496A730: __wine_spec_exe_wentry (exe_wentry.c:36)
==28829==    by 0x7B8641DB: ??? (process.c:1045)
==28829==    by 0x7B864328: start_process (process.c:1097)
==28829==    by 0x7BC870C7: ??? (signal_i386.c:2571)
==28829==    by 0x7BC87110: call_thread_func (signal_i386.c:2630)
==28829==    by 0x7BC870A5: ??? (signal_i386.c:2571)
==28829==    by 0x7BC5A1FC: start_process (loader.c:2856)
==28829==    by 0x403EFD4: ??? (port.c:60)
==28829==

[Bug 36122] valgrind shows a definite leak in winemenubuilder/winemenubuilder.c

https://bugs.winehq.org/show_bug.cgi?id=36122

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |valgrind

[Bug 36122] valgrind shows a definite leak in winemenubuilder/winemenubuilder.c

https://bugs.winehq.org/show_bug.cgi?id=36122

Indrek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Indrek  ---
The definitive leak should be fixed with commit
http://source.winehq.org/git/wine.git/commit/7b8624649ac5e577f0b8da802091c51...

Do other warnings still occur?

[Bug 36122] valgrind shows a definite leak in winemenubuilder/winemenubuilder.c

https://bugs.winehq.org/show_bug.cgi?id=36122

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |7b8624649ac5e577f0b8da80209
                   |                            |1c51d48bb7e88
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Austin English  ---
(In reply to Indrek from comment #4)
> The definitive leak should be fixed with commit
> http://source.winehq.org/git/wine.git/commit/
> 7b8624649ac5e577f0b8da802091c51d48bb7e88
>
> Do other warnings still occur?

I see
==24183== 256 bytes in 1 blocks are definitely lost in loss record 476 of 655
==24183==    at 0x7BC494E5: notify_alloc (heap.c:255)
==24183==    by 0x7BC4D71B: RtlAllocateHeap (heap.c:1716)
==24183==    by 0x49A60EC: IMalloc_fnAlloc (ifs.c:186)
==24183==    by 0x49A6943: CoTaskMemAlloc (objidl.h:1236)
==24183==    by 0x56CA588: get_profile_string (intshcut.c:429)
==24183==    by 0x56CA8AF: PersistFile_Load (intshcut.c:473)
==24183==    by 0x4877583: Process_URL (objidl.h:5279)
==24183==    by 0x4878843: wWinMain (winemenubuilder.c:3703)
==24183==    by 0x4878EBB: wmain (exe_wmain.c:51)
==24183==    by 0x4878DA5: __wine_spec_exe_wentry (exe_wentry.c:36)
==24183==    by 0x7B85D9DF: ??? (process.c:1045)
==24183==    by 0x7B85DB21: start_process (process.c:1097)
==24183==    by 0x7BC7EF53: ??? (signal_i386.c:2578)
==24183==    by 0x7BC7EF9A: call_thread_func (signal_i386.c:2637)
==24183==    by 0x7BC7EF31: ??? (signal_i386.c:2578)
==24183==    by 0x7BC55F4B: start_process (loader.c:2856)
==24183==    by 0x403CDAC: ??? (port.c:60)
==24183==

in ieframe/tests/webbrowser.c, but not the others. I'll mark this fixed,
thanks.

[Bug 36122] valgrind shows a definite leak in winemenubuilder/winemenubuilder.c

https://bugs.winehq.org/show_bug.cgi?id=36122

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.26.