[Bug 16386] New: Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

Summary: Unimplemented KERNEL32.dll.GetConsoleAliasW
           Product: Wine
           Version: 1.1.10
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: kernel32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

When I attempt to run Unicode FAR manager (opensource version, r575) and then
type anything on the commandline and press ENTER, FAR is terminated with
following message:

wine: Call from 0x7b847370 to unimplemented function
KERNEL32.dll.GetConsoleAliasW, aborting
wine: Unimplemented function KERNEL32.dll.GetConsoleAliasW called at address
0x7b847370 (thread 0020), starting debugger...

[Bug 16386] Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.farmanager.com/op
                   |                            |ensource.php
           Keywords|                            |download, source

[Bug 16386] FAR crashes with Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
         OS/Version|other                       |Linux
           Platform|Other                       |PC
            Summary|Unimplemented               |FAR crashes with
                   |KERNEL32.dll.GetConsoleAlias|Unimplemented
                   |W                           |KERNEL32.dll.GetConsoleAlias
                   |                            |W

[Bug 16386] FAR crashes with Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

--- Comment #1 from Alexander Nicolaysen Sørnes   2008-12-07 17:30:36 ---
Created an attachment (id=17731)
 --> (http://bugs.winehq.org/attachment.cgi?id=17731)
Proposed patch

Does the following patch work?  Please post the new console output in any case.

[Bug 16386] FAR crashes with Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 16386] FAR crashes with Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

--- Comment #2 from MP   2008-12-15 04:55:43 ---
I have applied the proposed patch to git checkout, compiled it and installed
the new version.

$ wine --version
wine-1.1.10-74-gd3f7f5e

I run FAR with "wineconsole --backend=user d:/far/Far.exe"
When I type anything in the commandline, FAR no longer crashes (invalid
commands like "asdf" produce no output, executing other .exe file work as
expected), however, there is no console output when executing the
commands/other executables at all (except possible console output coming from
the executed executable).

I think the patch fixed the problem for me.

[Bug 16386] FAR crashes with Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Austin English   2008-12-15 12:06:02 ---
Patch was committed to git today.

[Bug 16386] FAR crashes with Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard   2008-12-20 09:06:40 ---
Closing bugs fixed in 1.1.11.

[Bug 16386] FAR crashes with Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

--- Comment #5 from Vasya Pupkin   2008-12-24 13:12:15 ---
> -
> - RETURNS
> -
> - 0 if an error occurred, non-zero for success

Alexander, did you understand what you doing?

You write an empty string in lpTargetBuffer and return success code regardless
of lpSource and lpExename at all.

As a result, software, which uses this function, will think, that ANY command
is alias, which points to an empty string.

That why "invalid commands like "asdf" produce no output" in FAR - they are
just not executed, because those "asdf" is replaced with space.

This function is stub, and it must ALWAYS return zero and don't touch
lpTargetBuffer:

DWORD WINAPI GetConsoleAliasW(LPWSTR lpSource, LPWSTR lpTargetBuffer,
                              DWORD TargetBufferLength, LPWSTR lpExename)
{
  SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
  return 0;
}

[Bug 16386] FAR crashes with Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Dmitry Timoshkov   2008-12-25 23:58:45 ---
Alexander, please read the comment #5.

[Bug 16386] FAR crashes with Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

Alexander Nicolaysen Sørnes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |UNCONFIRMED
         Resolution|FIXED                       |

--- Comment #7 from Alexander Nicolaysen Sørnes   2008-12-30 18:39:28 ---
Sorry, I should have done some more research before sending the patch.  I will
make a new one shortly.

[Bug 16386] FAR crashes with Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Jerome Leclanche   2009-06-12 03:14:30 ---
(In reply to comment #7)
> Sorry, I should have done some more research before sending the patch.  I will
> make a new one shortly.

Has it been sent/committed?

[Bug 16386] FAR crashes with Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

--- Comment #9 from Austin English   2009-06-12 12:05:32 ---
(In reply to comment #8)
> (In reply to comment #7)
> > Sorry, I should have done some more research before sending the patch.  I will
> > make a new one shortly.
>
> Has it been sent/committed?

http://www.winehq.org/pipermail/wine-patches/2009-June/074168.html

[Bug 16386] FAR crashes with Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

--- Comment #10 from Austin English   2009-06-15 10:49:41 ---
Patch committed:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=056131f67e9c9402269f84...

[Bug 16386] FAR crashes with Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

Yuri Khan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Yuri Khan   2009-06-22 05:51:14 ---
With the new patch, commands run fine. Suggest "Resolved Fixed".

[Bug 16386] FAR crashes with Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

Alexander Nicolaysen Sørnes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Alexander Nicolaysen Sørnes   2009-06-22 08:28:05 ---
Resolving as fixed, then

[Bug 16386] FAR crashes with Unimplemented KERNEL32.dll.GetConsoleAliasW

http://bugs.winehq.org/show_bug.cgi?id=16386

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard   2009-07-03 12:22:19 ---
Closing bugs fixed in 1.1.25.