https://bugs.winehq.org/show_bug.cgi?id=56781
Bug ID: 56781 Summary: srcrrun: Dictionary setting item to object fails Product: Wine Version: 9.4 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: scrrun Assignee: wine-bugs@winehq.org Reporter: francisdb@gmail.com Distribution: ---
Reproducer in vbscript
Class C End Class Dim cls1: Set cls1 = new C Dim cls2: Set cls2 = new C Dim dict: Set dict = createobject("scripting.dictionary") Dim key: key = "test" dict.Add key, cls1 Set dict.Item(key) = cls2
Looks like this is not implemented https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/scrrun/dictionary.c?r...
Without understanding the code this should maybe increase the reference count and delegate to dictionary_put_Item?
https://bugs.winehq.org/show_bug.cgi?id=56781
--- Comment #1 from francisdb francisdb@gmail.com --- wine cscript ./test.vbs Before 0120:fixme:scrrun:dictionary_putref_Item 0143F464, 01449108, 01449118 stub 0120:fixme:wscript:ActiveScriptSite_OnScriptError ()
https://bugs.winehq.org/show_bug.cgi?id=56781
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW
--- Comment #2 from Nikolay Sivov bunglehead@gmail.com --- I don't see any semantic difference with put_Item(). Both will addref on get/set. I sent a fix https://gitlab.winehq.org/wine/wine/-/merge_requests/5795.
https://bugs.winehq.org/show_bug.cgi?id=56781
--- Comment #3 from francisdb francisdb@gmail.com --- Thanks for the quick fix!
https://bugs.winehq.org/show_bug.cgi?id=56781
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED Fixed by SHA1| |0da33d5493814b8cb8309c092bd | |7c6e1c60f1868
--- Comment #4 from Nikolay Sivov bunglehead@gmail.com --- This is now fixed, 0da33d5493814b8cb8309c092bd7c6e1c60f1868.
https://bugs.winehq.org/show_bug.cgi?id=56781
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #5 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 9.11.
https://bugs.winehq.org/show_bug.cgi?id=56781
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |9.0.x