[Bug 12979] New: Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

Summary: Trucks&Trains game error in quartz.dll
           Product: Wine
           Version: 0.9.61.
          Platform: All
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: quartz
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Game - Tracks & Trains Tycoon
Game graphics - DirectX or Open GL

If i Use Open GL
While I using wine 0.9.60 with this game there are no problems...
I upgrade wine to 0.9.61
Now game crashes with error in quartz.dll
If I use Windows dll quartz - game - runnning but very slowly

If i Use DirectX 
With Direct X ,game don't want starting  
log
fixme:win:EnumDisplayDevicesW ((null),0,0x1caf814,0x00000000), stub!
fixme:d3d:test_pbo_functionality >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502)
from Loading the PBO test texture
 @ directx.c / 3518
err:d3d:WineD3D_ChoosePixelFormat Can't find a suitable iPixelFormat
fixme:xrandr:X11DRV_XRandR_SetCurrentMode Cannot change screen BPP from 32 to
16

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

--- Comment #1 from Michael Povarov   2008-05-04 23:43:44 ---
Created an attachment (id=12729)
 --> (http://bugs.winehq.org/attachment.cgi?id=12729)
log while using Opengl In this game

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

Olivier Samyn  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Olivier Samyn   2008-05-05 16:39:10 ---
I got a similar problem with gta vicecity.

It works fine with wine 0.9.60 but, with wine 0.9.61, it crashes (segfault) in
the quartz.dll (using wine builtin one).

So, for me it's a regression, and I will try to bisect it once I get a little
bit of time.

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

--- Comment #3 from Olivier Samyn   2008-05-06 18:12:29 ---
I located the problem. In the following code from dlls/quartz/filesource.c,
sometimes, *pin is null (ie This->pOutputPin).

I just added a return S_FALSE in that case and it works again for me.

Small patch below:

diff --git a/dlls/quartz/filesource.c b/dlls/quartz/filesource.c
index f410b56..a4e708f 100644
--- a/dlls/quartz/filesource.c
+++ b/dlls/quartz/filesource.c
@@ -533,6 +533,10 @@ static HRESULT AsyncReader_GetPin(IBaseFilter *iface,
ULONG
         return S_FALSE;

*pin = (IPin *)This->pOutputPin;
+    
+    if(!(*pin))
+        return S_FALSE;
+    
     IPin_AddRef(*pin);
     return S_OK;
 }

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

--- Comment #4 from Olivier Samyn   2008-05-06 18:14:53 ---
Created an attachment (id=12784)
 --> (http://bugs.winehq.org/attachment.cgi?id=12784)
Small patch adding a null test

Patch copy paste in comments are always bad.

So here is the correct patch version as an attachment.

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

--- Comment #5 from Michael Povarov   2008-05-07 06:20:40 ---
It works!!Thank you ever so much

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

Michael Povarov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Michael Povarov   2008-05-07 09:26:47 ---
 _

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |

--- Comment #7 from Austin English   2008-05-07 09:29:05 ---
(In reply to comment #6)
> _

Not fixed. The patch hasn't been committed.

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Lei Zhang   2008-05-08 20:01:01 ---
*** Bug 13047 has been marked as a duplicate of this bug. ***

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

Maarten Lankhorst  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Maarten Lankhorst   2008-05-09 17:19:54 ---
*** Bug 13000 has been marked as a duplicate of this bug. ***

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

Florian  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #10 from Florian   2008-05-10 05:47:33 ---
*** This bug has been confirmed by popular vote. ***

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

--- Comment #11 from Gary Pendergast   2008-05-10 08:46:29 ---
Given that this is a small bug with a simple patch, can it be targeted for
1.0.0?

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

Florian  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Florian   2008-05-11 05:09:55 ---
(In reply to comment #5)
> It works!!Thank you ever so much

This patch also works for GTA:SA with wine-1.0-rc1

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

--- Comment #13 from Austin English   2008-05-11 22:20:39 ---
(In reply to comment #11)
> Given that this is a small bug with a simple patch, can it be targeted for
> 1.0.0?

If the patch is small and correct, there's a good chance it'll be applied. I
don't think this app warrants adding another bug to 1.0 list, especially this
close to release.

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

--- Comment #14 from Gary Pendergast   2008-05-13 19:59:07 ---
Patch fixes Audiosurf when applied to Git HEAD.

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #15 from Juan Lang   2008-05-15 19:46:43 ---
Now the fix is in git, so it's been fixed.

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Alexandre Julliard   2008-05-23 10:38:09 ---
Closing bugs fixed in 1.0-rc2.

[Bug 12979] Trucks&Trains game error in quartz.dll

http://bugs.winehq.org/show_bug.cgi?id=12979

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|All                         |Other

--- Comment #17 from Austin English  2012-02-23 15:25:53 CST ---
Removing deprecated 'All' Platform.