https://bugs.winehq.org/show_bug.cgi?id=46909
Bug ID: 46909 Summary: Missing (black) textures in Black & White Product: Wine Version: 3.20 Hardware: x86 OS: Linux Status: NEW Keywords: regression Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs@winehq.org Reporter: gyebro69@gmail.com CC: hverbeet@gmail.com Regression SHA1: 961a94ac046644004718c56bfeeb81740cb73793 Distribution: ---
Created attachment 63986 --> https://bugs.winehq.org/attachment.cgi?id=63986 plain terminal output
Most objects (trees, buildings, people) are pitch black in Black & White and in the Creature Isle expansion. Changing graphical details in the setup menu or disabling GLSL, CSMT don't make a difference. Reproduced the problem with nouveau/Mesa 19.0.0. and with Nvidia binary drivers 418.49.04. There is no demo version available. Please let me know if you need debug logs.
I found that the problem is present since commit 961a94ac046644004718c56bfeeb81740cb73793. I couldn't revert the commit on current git, but I verified that textures are rendered properly with the previous commit.
Still present in wine-4.4-188-gc988910cae (also in Staging). OpenGL vendor string: NVIDIA Corporation OpenGL renderer string: GeForce GT 730/PCIe/SSE2 OpenGL core profile version string: 4.6.0 NVIDIA 418.49.04
https://bugs.winehq.org/show_bug.cgi?id=46909
--- Comment #1 from Béla Gyebrószki gyebro69@gmail.com --- Created attachment 63987 --> https://bugs.winehq.org/attachment.cgi?id=63987 screenshot (comparison)
https://bugs.winehq.org/show_bug.cgi?id=46909
--- Comment #2 from Henri Verbeet hverbeet@gmail.com --- Could you attach a WINEDEBUG="+ddraw,+d3d,+seh,+tid" log? Preferably with csmt disabled.
https://bugs.winehq.org/show_bug.cgi?id=46909
--- Comment #3 from Béla Gyebrószki gyebro69@gmail.com --- Created attachment 63989 --> https://bugs.winehq.org/attachment.cgi?id=63989 +ddraw,+d3d,+seh,+tid log (uncompressed 209 MB)
https://bugs.winehq.org/show_bug.cgi?id=46909
--- Comment #4 from Henri Verbeet hverbeet@gmail.com --- Could you add +d3d_shader and warn+heap to the existing debug channels?
https://bugs.winehq.org/show_bug.cgi?id=46909
--- Comment #5 from Béla Gyebrószki gyebro69@gmail.com --- Created attachment 64006 --> https://bugs.winehq.org/attachment.cgi?id=64006 warn+heap,+ddraw,+d3d,+d3d_shader,+seh,+tid log
https://bugs.winehq.org/show_bug.cgi?id=46909
--- Comment #6 from Henri Verbeet hverbeet@gmail.com --- Created attachment 64009 --> https://bugs.winehq.org/attachment.cgi?id=64009 patch
Does the attached patch make it any better?
https://bugs.winehq.org/show_bug.cgi?id=46909
--- Comment #7 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to Henri Verbeet from comment #6)
Created attachment 64009 [details] patch
Does the attached patch make it any better?
The patch fixes the problem, thank you.
Are those errors in my terminal output have anything to do with the problem or they are unrelated? Just asking because they're still present even with the patch applied.
err:d3d:wined3d_debug_callback 0x1bb828: "GL_INVALID_OPERATION error generated. The target of the texture named by <texture> and the target <textarget> do not match.". err:d3d:wined3d_debug_callback 0x1bb828: "GL_INVALID_OPERATION error generated. <texture> is not the name of an existing texture.".
https://bugs.winehq.org/show_bug.cgi?id=46909
--- Comment #8 from Henri Verbeet hverbeet@gmail.com --- (In reply to Béla Gyebrószki from comment #7)
Are those errors in my terminal output have anything to do with the problem or they are unrelated? Just asking because they're still present even with the patch applied.
err:d3d:wined3d_debug_callback 0x1bb828: "GL_INVALID_OPERATION error generated. The target of the texture named by <texture> and the target <textarget> do not match.". err:d3d:wined3d_debug_callback 0x1bb828: "GL_INVALID_OPERATION error generated. <texture> is not the name of an existing texture.".
It's not entirely clear to me what causes those. They're certainly not supposed to happen though. Were they introduced by the same commit that introduced the black textures?
https://bugs.winehq.org/show_bug.cgi?id=46909
--- Comment #9 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to Henri Verbeet from comment #8)
(In reply to Béla Gyebrószki from comment #7)
Are those errors in my terminal output have anything to do with the problem or they are unrelated? Just asking because they're still present even with the patch applied.
err:d3d:wined3d_debug_callback 0x1bb828: "GL_INVALID_OPERATION error generated. The target of the texture named by <texture> and the target <textarget> do not match.". err:d3d:wined3d_debug_callback 0x1bb828: "GL_INVALID_OPERATION error generated. <texture> is not the name of an existing texture.".
It's not entirely clear to me what causes those. They're certainly not supposed to happen though. Were they introduced by the same commit that introduced the black textures?
As I recall, those were present in every Wine version I tried the game with, at least in the 3.x series of Wine.
https://bugs.winehq.org/show_bug.cgi?id=46909
--- Comment #10 from Béla Gyebrószki gyebro69@gmail.com --- Just one more note. At first I thought this would be the same as bug #45053. Then I realized that 45053 was reported against Wine 3.6. Besides, restarting the game doesn't resolve the issue for me and the black textures are present from the very beginning after starting the game.
https://bugs.winehq.org/show_bug.cgi?id=46909
--- Comment #11 from Henri Verbeet hverbeet@gmail.com --- (In reply to Béla Gyebrószki from comment #9)
(In reply to Henri Verbeet from comment #8)
(In reply to Béla Gyebrószki from comment #7)
Are those errors in my terminal output have anything to do with the problem or they are unrelated? Just asking because they're still present even with the patch applied.
err:d3d:wined3d_debug_callback 0x1bb828: "GL_INVALID_OPERATION error generated. The target of the texture named by <texture> and the target <textarget> do not match.". err:d3d:wined3d_debug_callback 0x1bb828: "GL_INVALID_OPERATION error generated. <texture> is not the name of an existing texture.".
It's not entirely clear to me what causes those. They're certainly not supposed to happen though. Were they introduced by the same commit that introduced the black textures?
As I recall, those were present in every Wine version I tried the game with, at least in the 3.x series of Wine.
That's unfortunate. At first sight the issue looks like some kind of memory corruption, and it may not be easy to track that down remotely.
https://bugs.winehq.org/show_bug.cgi?id=46909
--- Comment #12 from Henri Verbeet hverbeet@gmail.com --- Created attachment 64016 --> https://bugs.winehq.org/attachment.cgi?id=64016 debug patch
Just to give it a shot though, could you please create a new log (same channels as the last one), with the attached debug patch in addition to the previous patch?
https://bugs.winehq.org/show_bug.cgi?id=46909
--- Comment #13 from Béla Gyebrószki gyebro69@gmail.com --- Created attachment 64023 --> https://bugs.winehq.org/attachment.cgi?id=64023 warn+heap,+ddraw,+d3d,+d3d_shader,+seh,+tid log (debug patch applied, uncompressed 346 MB)
https://bugs.winehq.org/show_bug.cgi?id=46909
--- Comment #14 from Henri Verbeet hverbeet@gmail.com --- I think I see the issue, thanks.
It looks like the application is doing a decompression blit to a system memory destination. System memory destinations are not normally supported by the GLSL blitter, but we make an exception for decompression blits.
https://bugs.winehq.org/show_bug.cgi?id=46909
Béla Gyebrószki gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |a5279a5fba452d779cafc2cbd30 | |98e9ed81598d9 Status|NEW |RESOLVED
--- Comment #15 from Béla Gyebrószki gyebro69@gmail.com --- Thank you for taking your time to go through the logs and providing the patch.
Fixed with https://source.winehq.org/git/wine.git/commit/a5279a5fba452d779cafc2cbd3098e...
https://bugs.winehq.org/show_bug.cgi?id=46909
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #16 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 4.5.
https://bugs.winehq.org/show_bug.cgi?id=46909
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |4.0.x
https://bugs.winehq.org/show_bug.cgi?id=46909
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.0.x |---
--- Comment #17 from Michael Stefaniuc mstefani@winehq.org --- Removing the 4.0.x milestone from bug fixes included in 4.0.2.