[Bug 24432] New: League of Legends standalone client crashes when starting tutorial game, with unimplemented functions from msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=24432

Summary: League of Legends standalone client crashes when
                    starting tutorial game, with unimplemented functions
                    from msvcp80.dll
           Product: Wine
           Version: 1.3.2
          Platform: x86
               URL: http://l3cdn.riotgames.com/Installer/lol/LOL_Standalon
                    e_09_16_2010.rar
        OS/Version: Linux
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=30811)
 --> (http://bugs.winehq.org/attachment.cgi?id=30811)
log from mscodescan.pl (which runs winedump -j import)

After doing 'winetricks ie6' to work around bug 24431, the
LoL standalone client crashes when you enter a tutorial game, with

wine: Call from 0x7b8367b3 to unimplemented function
msvcp80.dll.?clear@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAEXXZ,
aborting

winedump shows the game uses about 120 routines from msvcp80 that are
currently stubs in wine; see attached log.

winetricks vcrun2005 works around this, and gets you to the next problem.

[Bug 24432] League of Legends standalone client crashes when starting tutorial game, with unimplemented functions from msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=24432

--- Comment #1 from Dan Kegel  2010-09-23 22:06:02 CDT ---
For completeness: the next problem is

wine: Call from 0x7b8370fb to unimplemented function
msvcr80.dll._localtime64_s, aborting

The attached log lists a few other msvcr80 imports probably needed:

msvcr80:_get_errno
  msvcr80:_itoa_s
  msvcr80:_localtime64_s
  msvcr80:_mbsnbcat_s
  msvcr80:_strlwr_s
  msvcr80:_ultoa_s
  msvcr80:strerror_s

[Bug 24432] League of Legends standalone client crashes when starting tutorial game, with unimplemented functions from msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=24432

--- Comment #2 from Dan Kegel  2010-10-11 08:50:52 CDT ---
I see patches for a few of these have been sent,
http://www.winehq.org/pipermail/wine-patches/2010-October/094375.html

[Bug 24432] League of Legends standalone client crashes when starting tutorial game, with unimplemented functions from msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=24432

--- Comment #3 from Andrew Nguyen  2010-10-11 13:21:43 CDT ---
(In reply to comment #2)
> I see patches for a few of these have been sent,
> http://www.winehq.org/pipermail/wine-patches/2010-October/094375.html

Now that my patches have been committed, only _mbsnbcat_s and _ultoa_s are left
to be implemented.

[Bug 24432] League of Legends standalone client crashes when starting tutorial game, with unimplemented functions from msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=24432

--- Comment #4 from Dan Kegel  2010-10-11 13:47:47 CDT ---
Cool.  After those two, all we need is a full open source replacement for
msvcp80
to drop down from heaven, and we can close this bug :-)

[Bug 24432] League of Legends standalone client crashes when starting tutorial game, with unimplemented functions from msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=24432

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |msvcp

--- Comment #5 from Dan Kegel  2011-06-06 13:39:34 CDT ---
looks like the msvcr80 functions are in, so this is just msvcp80 now?

[Bug 24432] League of Legends standalone client crashes when starting tutorial game, with unimplemented functions from msvcp80.dll

http://bugs.winehq.org/show_bug.cgi?id=24432

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Dylan Smith  2011-06-20 13:58:48 CDT ---
The download url no longer works (404 Not Found). The game can be downloaded
from http://l3cdn.riotgames.com/Installer/NA_Installer/LeagueofLegends.exe but
it seems to be a newer version.

This version shows an error dialog with builtin msvcp80 saying "Failed to
launch RADS\system\rads_user_kernel.exe", and with native msvcp80 it deadlocks
waiting for an unnamed critical section. mscodescan.pl shows just unimplemented
msvcp80 functions, but many of them as with the older version.

[Bug 24432] League of Legends standalone client crashes on unimplemented function msvcr80.dll._localtime64_s

http://bugs.winehq.org/show_bug.cgi?id=24432

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |e245cb52c6f4e2dd60a8e4989a2
                   |                            |ba79e39039067
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
          Component|msvcp                       |msvcrt
         Resolution|                            |FIXED
            Summary|League of Legends           |League of Legends
                   |standalone client crashes   |standalone client crashes
                   |when starting tutorial      |on unimplemented function
                   |game, with unimplemented    |msvcr80.dll._localtime64_s
                   |functions from msvcp80.dll  |

--- Comment #7 from Anastasius Focht  2011-10-30 09:37:38 CDT ---
Hello,

this bug has been recycled several times -> should be avoided.
Marking this one fixed with msvcr80.dll._localtime64_s implementation (per
comment #1)

The initial missing
msvcp80.dll.?clear@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAEXXZ
was covered by bug 26793

If you still find problems due to insufficient MSVC runtime API, open new bug
reports.
Make sure you don't create dupes.

Regards

[Bug 24432] League of Legends standalone client crashes on unimplemented function msvcr80.dll._localtime64_s

http://bugs.winehq.org/show_bug.cgi?id=24432

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  2011-11-04 14:15:09 CDT ---
Closing bugs fixed in 1.3.32.