[Bug 36389] New: Dungeons & Dragons Online (DDO) doesn't detect 3D compatible device. Regression for 1.7.15+

http://bugs.winehq.org/show_bug.cgi?id=36389

Bug ID: 36389
           Summary: Dungeons & Dragons Online (DDO) doesn't detect 3D
                    compatible device. Regression for 1.7.15+
           Product: Wine
           Version: 1.7.15
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]

The game fails to load with the following error:

"No suitable graphics device was found. Are you running through a remote
session or a VM? If not, please check your video hardware capabilities.[122]"

Bisected the regression down to patch:

[938529e1f91d4b3dce1f4526f2a68e4243926f28] wined3d: Remove the version
parameter.

A trunk build with this patch reverted, game works fine. (Used 1.7.14 to 1.7.15
for bisect.)

Card is Radeon HD 5670 using latest catalyst. Not that this is likely to matter
considering the offending patch.

Now, which kind of trace do you need? :-)

[Bug 36389] Dungeons & Dragons Online (DDO) doesn't detect 3D compatible device. Regression for 1.7.15+

http://bugs.winehq.org/show_bug.cgi?id=36389

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
    Regression SHA1|                            |938529e1f91d4b3dce1f4526f2a
                   |                            |68e4243926f28

--- Comment #1 from Henri Verbeet  ---
Do you have any custom registry settings set? ("DirectDrawRenderer" in
particular.) If not, a WINEDEBUG="+seh,+tid,+d3d" log would probably be a good
start.

[Bug 36389] Dungeons & Dragons Online (DDO) doesn't detect 3D compatible device. Regression for 1.7.15+

http://bugs.winehq.org/show_bug.cgi?id=36389

--- Comment #2 from David Philippi  ---
Created attachment 48441
  --> http://bugs.winehq.org/attachment.cgi?id=48441
Trace with options

[Bug 36389] Dungeons & Dragons Online (DDO) doesn't detect 3D compatible device. Regression for 1.7.15+

http://bugs.winehq.org/show_bug.cgi?id=36389

--- Comment #3 from David Philippi  ---
CSMT                    disabled
DirectDrawRenderer      gdi
OffscreenRenderingMode  fbo

Those are set since long ago, don't even remember why. Without them it works on
vanilla trunk so I'll keep them out.
Seems like testing clean prefix would have been a good plan but then it worked
for months or longer without any changes, why suspect innocent looking patches
then? :-)

I've attached traces with and without those settings. Some of the messages
belong to PyLotRo, the launcher required (QT4).

[Bug 36389] Dungeons & Dragons Online (DDO) doesn't detect 3D compatible device. Regression for 1.7.15+

http://bugs.winehq.org/show_bug.cgi?id=36389

--- Comment #4 from David Philippi  ---
Created attachment 48442
  --> http://bugs.winehq.org/attachment.cgi?id=48442
Trace after removing offending keys

[Bug 36389] Dungeons & Dragons Online (DDO) doesn't detect 3D compatible device. Regression for 1.7.15+

http://bugs.winehq.org/show_bug.cgi?id=36389

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Stefan Dösinger  ---
I'm not sure I understand comment 3. Does the problem go away when you remove
the registry keys?

If not, please attach a +ddraw,+d3d,+d3d_surface log.

If removing those keys makes the problem go away: The only key that matters
here is DirectDrawRenderer=gdi. The CSMT key does not yet exist in the official
tree, only in my csmt branch. OffscreenRenderingMode defaults to fbo.

[Bug 36389] Dungeons & Dragons Online (DDO) doesn't detect 3D compatible device. Regression for 1.7.15+

http://bugs.winehq.org/show_bug.cgi?id=36389

--- Comment #6 from David Philippi  ---
Yes, removing the DirectDrawRenderer key and keeping default does remove the
bug. Not sure wheter gdi is supposed to work as well.

[Bug 36389] Dungeons & Dragons Online (DDO) doesn't detect 3D compatible device. Regression for 1.7.15+

http://bugs.winehq.org/show_bug.cgi?id=36389

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #7 from Stefan Dösinger  ---
The game is from 2006, I guess it uses d3d8 or d3d9. Prior to
938529e1f91d4b3dce1f4526f2a68e4243926f28, the DirectDrawRenderer key was
ignored for d3d8 and newer. Now setting it to gdi disables 3D acceleration for
every d3d version - so it completely breaks d3d8 and d3d9.

This was a conscious decision. Doing so keeps the code simpler. There's no
reason to ignore the key for d3d8/9. Just don't set it for such a game. If you
have two games, where one needs it and another doesn't, you can set it in
AppDefaults.

I'm closing this bug as invalid, the code is behaving as intended. I'm sorry to
have caused this inconvenience though :-( .

[Bug 36389] Dungeons & Dragons Online (DDO) doesn't detect 3D compatible device. Regression for 1.7.15+

https://bugs.winehq.org/show_bug.cgi?id=36389

--- Comment #8 from Henri Verbeet  ---
For what it's worth, in general setting "DirectDrawRenderer" to "gdi" is not a
great idea for DirectDraw applications either, it really only benefits a few
specific applications.

[Bug 36389] Dungeons & Dragons Online (DDO) doesn't detect 3D compatible device. Regression for 1.7.15+

https://bugs.winehq.org/show_bug.cgi?id=36389

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Stefan Dösinger  ---
Closing