[Bug 17525] New: make test fails on wininet:http

http://bugs.winehq.org/show_bug.cgi?id=17525

Summary: make test fails on wininet:http
           Product: Wine
           Version: 1.1.15
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wininet
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

The test fails for me every time.

http.c:354: Test succeeded inside todo block: expected status 10
(INTERNET_STATUS_RESOLVING_NAME) 1 times, received 1 times
http.c:355: Test succeeded inside todo block: expected status 11
(INTERNET_STATUS_NAME_RESOLVED) 1 times, received 1 times
http.c:757: Test failed: expected status 50
(INTERNET_STATUS_CLOSING_CONNECTION) 0 times, received 1 times
http.c:758: Test failed: expected status 51 (INTERNET_STATUS_CONNECTION_CLOSED)
0 times, received 1 times

I've noticed that all the people who have this succeed for them it says
"received 2 times" for the first two at the end.

[Bug 17525] make test fails on wininet:http

http://bugs.winehq.org/show_bug.cgi?id=17525

--- Comment #1 from Austin Lund   2009-02-24 21:38:58 ---
Created an attachment (id=19636)
 --> (http://bugs.winehq.org/attachment.cgi?id=19636)
Test run with WINEDEBUG="+wininet"

[Bug 17525] make test fails on wininet:http

http://bugs.winehq.org/show_bug.cgi?id=17525

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Hans Leidekker   2009-02-25 04:23:11 ---
> trace:wininet:NETCON_getNextLine :43 "Via: 1.1 webcache1 (NetCache NetApp/6.1.1)"

Looks like you are behind a proxy which might explain the failures. Perhaps we
should
change those tests to specify INTERNET_OPEN_TYPE_DIRECT and skip them if we
can't
use a direct connection.

[Bug 17525] make test fails on wininet:http

http://bugs.winehq.org/show_bug.cgi?id=17525

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Dan Kegel   2009-02-25 09:55:19 ---
The best thing to do would be to have the
tests start their own server, and not try
to access the public internet.

[Bug 17525] make test fails on wininet:http

http://bugs.winehq.org/show_bug.cgi?id=17525

--- Comment #4 from Austin Lund   2009-02-25 16:45:30 ---
I'm not 100% what the set up is here, but a proxy is involved somehow and only
sometimes (!).  Many ports are blocked and that's been the most frustrating
feature.

[Bug 17525] make test fails on wininet:http

http://bugs.winehq.org/show_bug.cgi?id=17525

--- Comment #5 from Austin Lund   2009-03-18 00:46:01 ---
I think this is the same explanation for the failures of wininet:http on only
some of the windows tests.

I don't understand what is meant by the tests should "tests start their own
server".  Is that meant to mean writing a server using the winapi?  Is there an
easy path to doing this?

[Bug 17525] make test fails on wininet:http

http://bugs.winehq.org/show_bug.cgi?id=17525

--- Comment #6 from Dan Kegel   2009-03-18 02:18:11 ---
Yes, in general, tests should implement their own server with win32 
to connect to rather than connecting to a real server on the internet.

There are examples of this already in ws2_32/tests/sock.c.

[Bug 17525] make test fails on wininet:http

http://bugs.winehq.org/show_bug.cgi?id=17525

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source

--- Comment #7 from Austin English   2009-09-15 15:25:05 ---
Still present.

[Bug 17525] make test fails on wininet:http

http://bugs.winehq.org/show_bug.cgi?id=17525

Jacek Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #8 from Jacek Caban  2011-05-11 07:41:01 CDT ---
Mentioned tests are no longer todo_wine in git. Assuming fixed.

[Bug 17525] make test fails on wininet:http

http://bugs.winehq.org/show_bug.cgi?id=17525

--- Comment #9 from Dan Kegel  2011-05-11 11:10:15 CDT ---
Not all of the failures Austin mentioned were inside todo blocks.

I rather doubt this bug is really fixed; the title should probably be
"network tests fail when connection to outside world is broken".

[Bug 17525] make test fails on wininet:http

http://bugs.winehq.org/show_bug.cgi?id=17525

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  2011-05-13 13:33:07 CDT ---
Closing bugs fixed in 1.3.20.