[Bug 24568] New: PNG decoder can't decode some PNGs

http://bugs.winehq.org/show_bug.cgi?id=24568

Summary: PNG decoder can't decode some PNGs
           Product: Wine
           Version: 1.3.3
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: windowscodecs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=31029)
 --> (http://bugs.winehq.org/attachment.cgi?id=31029)
PNG that windowscodecs fails to open

With windowscodecs I get this error:

warn:wincodecs:user_error_fn PNG error: "Extra compressed data"

on the attached PNG (from www.emule-project.net) and it fails to open.

Nautilus, F-Spot and Eye of Gnome open it perfectly.

[Bug 24568] PNG decoder can't decode some PNGs

http://bugs.winehq.org/show_bug.cgi?id=24568

--- Comment #1 from Vincent Povirk  2010-09-29 14:30:46 CDT ---
Firefox says "The image “http://bugs2.winehq.org/attachment.cgi?id=31029%E2%80%9D
cannot be displayed, because it contains errors."

Gdiplus and WIC on Windows XP can both read it, though.

[Bug 24568] PNG decoder can't decode some PNGs

http://bugs.winehq.org/show_bug.cgi?id=24568

--- Comment #2 from Damjan Jovanovic  2010-09-29 14:33:26 CDT ---
Google Chrome displays it fine.

[Bug 24568] PNG decoder can't decode some PNGs

http://bugs.winehq.org/show_bug.cgi?id=24568

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Jerome Leclanche  2010-09-29 14:40:16 CDT ---
Chrome displays it fine, so does PIL, for what it's worth.

[Bug 24568] PNG decoder can't decode some PNGs

http://bugs.winehq.org/show_bug.cgi?id=24568

--- Comment #4 from Damjan Jovanovic  2010-10-06 00:29:01 CDT ---
The error comes from libpng's pngread.c, function png_read_row:

png_benign_error(png_ptr, "Extra compressed data");

The saga continues in pngconf.h:

/* Enabled in 1.4.0. */
#ifdef PNG_ALLOW_BENIGN_ERRORS
#  define png_benign_error png_warning
#  define png_chunk_benign_error png_chunk_warning
#else
#  ifndef PNG_BENIGN_ERRORS_SUPPORTED
#    define png_benign_error png_error
#    define png_chunk_benign_error png_chunk_error
#  endif
#endif

Since user_error_fn gets called in windowscodecs, benign errors must be
disabled in Ubuntu.

The interesting thing is how Nautilus and Eye of Gnome both open the same image
without problems. They both defer to libgtk's gdk-pixbuf image loader, which
uses progressive PNG loading, which probably bypasses the problem somehow.

Since eMule is a widely used app on Wine, I can't submit a patch to get
winemenubuilder to extract PNGs from ICO files until this is fixed.

[Bug 24568] PNG decoder can't decode some PNGs

http://bugs.winehq.org/show_bug.cgi?id=24568

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Damjan Jovanovic  2010-10-07 12:44:21 CDT ---
Fixed by commit d53e1a71f48e1456cd99965fdf0f40eeb805b8e3, resolving FIXED.

[Bug 24568] PNG decoder can't decode some PNGs

http://bugs.winehq.org/show_bug.cgi?id=24568

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #6 from Damjan Jovanovic  2010-10-07 14:40:36 CDT ---
Actually that patch did nothing. My x86_64 machine still fails to parse the
PNG, while a x86 machine probably worked even without the patch. The issue
seems to be  a 32<->64 libpng issue of some sort.

[Bug 24568] PNG decoder can't decode some PNGs

http://bugs.winehq.org/show_bug.cgi?id=24568

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Damjan Jovanovic  2010-10-11 22:27:14 CDT ---
For the PNG here, no libpng version works in non-incremental mode, but some
versions work in incremental mode. I'll do more investigating if Ubuntu 10.10's
version doesn't work, but for now, it's not Wine's bug any more, so resolving
FIXED.

[Bug 24568] PNG decoder can't decode some PNGs

http://bugs.winehq.org/show_bug.cgi?id=24568

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  2010-10-15 12:53:03 CDT ---
Closing bugs fixed in 1.3.5.