http://bugs.winehq.org/show_bug.cgi?id=28137
Summary: Bloxx It crashes Product: Wine Version: 1.3.26 Platform: x86-64 URL: http://eq03.mirror.alawar.com/SubAlawarComBloxxit.exe OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-ddraw AssignedTo: wine-bugs@winehq.org ReportedBy: RandomAccountName@mail.com CC: hverbeet@gmail.com Regression SHA1: 92e616f355ded5f3634625dba245e9b437e3ad6a
Created an attachment (id=36049) --> (http://bugs.winehq.org/attachment.cgi?id=36049) Terminal output
The game Bloxx It crashes when progressing from one level to the next, entering the options menu from within a level, or attempting to view demo mode. The latter is the quickest way to see the problem - just choose "demo" from the main menu to get a crash.
It used to work; regression testing indicated:
92e616f355ded5f3634625dba245e9b437e3ad6a is the first bad commit commit 92e616f355ded5f3634625dba245e9b437e3ad6a Author: Henri Verbeet hverbeet@codeweavers.com Date: Wed Aug 3 21:34:47 2011 +0200
ddraw: Remove rectangle validation from ddraw_surface7_Blt().
This is already done by wined3d_surface_blt().
:040000 040000 6aff7a5b6a628521823fd51d35f6aecb3dabfff8 f1c2bd43a5aab998269d496866f3ad59c5e12d3d M dlls
Reverting the patch fixed the problem. Tested with a Radeon HD 4250 (fglrx 8.84.60) and GMA 950 (i915 2.9.1).
http://bugs.winehq.org/show_bug.cgi?id=28137
A Wine user RandomAccountName@mail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression
http://bugs.winehq.org/show_bug.cgi?id=28137
--- Comment #1 from Henri Verbeet hverbeet@gmail.com 2011-08-21 05:27:50 CDT --- Could you add a +ddraw,+d3d_surface log?
http://bugs.winehq.org/show_bug.cgi?id=28137
--- Comment #2 from A Wine user RandomAccountName@mail.com 2011-08-21 06:30:25 CDT --- Created an attachment (id=36061) --> (http://bugs.winehq.org/attachment.cgi?id=36061) +ddraw,+d3d_surface log
Done.
http://bugs.winehq.org/show_bug.cgi?id=28137
--- Comment #3 from Henri Verbeet hverbeet@gmail.com 2011-08-21 06:54:47 CDT --- Created an attachment (id=36063) --> (http://bugs.winehq.org/attachment.cgi?id=36063) patch
This patch may help.
http://bugs.winehq.org/show_bug.cgi?id=28137
--- Comment #4 from A Wine user RandomAccountName@mail.com 2011-08-21 08:10:46 CDT --- (In reply to comment #3)
Created an attachment (id=36063)
--> (http://bugs.winehq.org/attachment.cgi?id=36063) [details]
patch
This patch may help.
Thanks for taking a look, I can confirm the patch prevents the crash. The only downside is that some trivial visual glitches are introduced (using fglrx):
- In-game dialogs flicker as they appear - Object which are in the process of scrolling off the screen are invisible - Object which are in the process of scrolling onto the screen are invisible
The first two problems actually appear to have been fixed by the same commit that caused the crash, and two new visual problems were introduced by it as well. Your patch reverts all of this, removing the new bugs and bringing back the original bugs.
The third problem was present back in 1.1.x but was fixed in one of the 1.2 RCs (IIRC).
Of course, these issues are still preferable to a crash. :)
http://bugs.winehq.org/show_bug.cgi?id=28137
--- Comment #5 from Henri Verbeet hverbeet@gmail.com 2011-08-21 08:48:23 CDT --- (In reply to comment #4)
Thanks for taking a look, I can confirm the patch prevents the crash. The only downside is that some trivial visual glitches are introduced (using fglrx):
- In-game dialogs flicker as they appear
- Object which are in the process of scrolling off the screen are invisible
- Object which are in the process of scrolling onto the screen are invisible
The first two problems actually appear to have been fixed by the same commit that caused the crash, and two new visual problems were introduced by it as well. Your patch reverts all of this, removing the new bugs and bringing back the original bugs.
Yeah, that's somewhat expected. The basic issue is that clippers don't actually work. Before 92e616f these blits were rejected, after that commit they caused memory corruption instead.
http://bugs.winehq.org/show_bug.cgi?id=28137
--- Comment #6 from Henri Verbeet hverbeet@gmail.com 2011-08-22 13:54:10 CDT --- Should be fixed by e1ab5f6e6bf251566289ccf3177ebaf8102cb72b.
http://bugs.winehq.org/show_bug.cgi?id=28137
A Wine user RandomAccountName@mail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #7 from A Wine user RandomAccountName@mail.com 2011-08-23 00:59:36 CDT --- Fixed in wine-1.3.26-89-g84da6ae.
http://bugs.winehq.org/show_bug.cgi?id=28137
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org 2011-08-26 13:25:05 CDT --- Closing bugs fixed in 1.3.27.
http://bugs.winehq.org/show_bug.cgi?id=28137
A Wine user RandomAccountName@mail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |e1ab5f6e6bf251566289ccf3177 | |ebaf8102cb72b
http://bugs.winehq.org/show_bug.cgi?id=28137
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|directx-ddraw |directx-d3d
-
wine-bugs＠winehq.org