[Bug 26340] New: MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

Summary: MSXML3, HTTP POST fails
           Product: Wine
           Version: 1.3.15
          Platform: x86
               URL: http://netikka.net/dev/upload.exe
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msxml3
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Example: Loading photograph (jpg) to photoserver.

http://netikka.net/dev/upload.exe

Just select some JPG-file and after waiting you should get image html tag in
return. But failure Ubuntu 10.10

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

--- Comment #1 from Nikolay Sivov  2011-03-07 04:17:40 CST ---
Attach source code for that application please.

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

--- Comment #2 from Nikolay Sivov  2011-03-07 04:31:18 CST ---
This one could be msxml bug, from log:

---
0027:trace:msxml:httprequest_send (0x15e090)->({vt 16396})
0027:trace:msxml:BindStatusCallback_create created callback 0x178888
0027:fixme:msxml:BindStatusCallback_create unsupported body data type 16396
---

so type is VT_BYREF|VT_VARIANT that we don't support for input. Native msxml6
hits a fixme in urlmon instead, probably unrelated thing.

Anyway I'm waiting for source to write a test for that.

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

--- Comment #3 from [e-mail] 2011-03-07 05:14:07 CST ---
Created an attachment (id=33556)
 --> (http://bugs.winehq.org/attachment.cgi?id=33556)
POST function

I don't have complete source for this example with me right now, but I attached
the POST function I use.

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

--- Comment #4 from Nikolay Sivov  2011-03-07 05:34:59 CST ---
That's enough, thanks. It looks like you use VT_UI1|VT_ARRAY to store POST
body, and after that this variant is passed as VT_VARIANT|VT_BYREF to send()
method. I'll do some tests for that case, should be simple.

By the way, unrelated to this bug but still. It's better to avoid wait loops
like you use, it's designed to be async so you can set your callback with
onreadystatechange() and use another timer to track timeout. It will be a nice
test for our implementation as well.

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #5 from André H.  2011-03-08 13:21:49 CST ---
confirming

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

--- Comment #6 from [e-mail] 2011-06-13 09:00:05 CDT ---
Now there are no other urlmon/wininet issues in 1.3.22. Winetricks msxml6 and
example works!

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

--- Comment #7 from [e-mail] 2011-06-27 04:40:56 CDT ---
I added support for VT_VARIANT|VT_BYREF and example is now working.

else 
if (V_VT(body) == VT_VARIANT|VT_BYREF)
 {
  HRESULT hrs;
  VARIANTARG tmpdat;
  VariantInit(&tmpdat);
  char *ansistr;
  hrs = VariantCopyInd(&tmpdat, body);
  if(hrs != S_OK) ERR("Could not copy array \n");
  SAFEARRAY *sa = V_ARRAY(&tmpdat);  
  LONG size = sa->rgsabound[0].cElements;
  TRACE("Got size %d\n", size);
  void *ptr;
  SafeArrayAccessData(sa, (void**)&ansistr);  
  bsc->body = GlobalAlloc(GMEM_FIXED, size);
  if (!bsc->body)
    {
     heap_free(bsc);
     return E_OUTOFMEMORY;
    }
  ptr = GlobalLock(bsc->body);
  memcpy(ptr, ansistr, size);
  GlobalUnlock(bsc->body);
  SafeArrayUnaccessData(sa);
  }
else
FIXME("unsupported body data type %d\n", V_VT(body));

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

--- Comment #8 from Austin English  2011-06-27 12:24:34 CDT ---
(In reply to comment #7)
> I added support for VT_VARIANT|VT_BYREF and example is now working.
>
> else 
> if (V_VT(body) == VT_VARIANT|VT_BYREF)
>  {
>   HRESULT hrs;
>   VARIANTARG tmpdat;
>   VariantInit(&tmpdat);
>   char *ansistr;
>   hrs = VariantCopyInd(&tmpdat, body);
>   if(hrs != S_OK) ERR("Could not copy array \n");
>   SAFEARRAY *sa = V_ARRAY(&tmpdat);  
>   LONG size = sa->rgsabound[0].cElements;
>   TRACE("Got size %d\n", size);
>   void *ptr;
>   SafeArrayAccessData(sa, (void**)&ansistr);  
>   bsc->body = GlobalAlloc(GMEM_FIXED, size);
>   if (!bsc->body)
>     {
>      heap_free(bsc);
>      return E_OUTOFMEMORY;
>     }
>   ptr = GlobalLock(bsc->body);
>   memcpy(ptr, ansistr, size);
>   GlobalUnlock(bsc->body);
>   SafeArrayUnaccessData(sa);
>   }
> else
> FIXME("unsupported body data type %d\n", V_VT(body));

Please send a patch to [e-mail]. See
http://wiki.winehq.org/SubmittingPatches for more info.

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #9 from [e-mail] 2011-06-28 06:52:31 CDT ---
I was hoping NS to do those tests..

I'm no C programmer and I guess it would not be accepted as it is. (There are
compiler warnings)

I was trying to access "body" directly, but it just did not work? Anyway, feel
free to modify and send! Same goes for bug 27536 and bug 26355

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

--- Comment #10 from [e-mail] 2011-11-01 05:08:46 CDT ---
Created attachment 37232
  --> http://bugs.winehq.org/attachment.cgi?id=37232
Patch without compiler warnings

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

--- Comment #11 from Nikolay Sivov  2011-11-16 12:46:00 CST ---
I'll try to find time for it this week.

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

--- Comment #12 from Nikolay Sivov  2011-12-19 13:47:12 CST ---
First part is fixed with 466341b6efd6ec9a6213df1081e232482fbde1e4. I have
another patch to support inner variant type that is referred.

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

--- Comment #13 from Nikolay Sivov  2011-12-20 14:02:40 CST ---
Should be fixed with ea75ac8406e71f6cdb3ecfa45408bba5aebdd13e. Retest please.

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|download                    |
             Status|NEW                         |RESOLVED
                URL|http://netikka.net/dev/uplo |
                   |ad.exe                      |
         Resolution|                            |FIXED

--- Comment #14 from [e-mail] 2011-12-20 14:31:21 CST ---
Post is now working here, many thanks! (Download sample was obsolete, because
post url has changed)

But seems this has caused regression to that other bug 27536

Can you check 27536 please?

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

--- Comment #15 from Nikolay Sivov  2011-12-20 20:55:58 CST ---
(In reply to comment #14)
> But seems this has caused regression to that other bug 27536
>
> Can you check 27536 please?

http://bugs.winehq.org/show_bug.cgi?id=29395#c1

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Alexandre Julliard  2011-12-30 12:57:13 CST ---
Closing bugs fixed in 1.3.36.

[Bug 26340] MSXML3, HTTP POST fails

http://bugs.winehq.org/show_bug.cgi?id=26340

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |ea75ac8406e71f6cdb3ecfa4540
                   |                            |8bba5aebdd13e

[Bug 26340] MSXML3, HTTP POST fails

https://bugs.winehq.org/show_bug.cgi?id=26340

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]