[Bug 13111] New: xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

Summary: xfile support is still non-existant in wine
           Product: Wine
           Version: unspecified
          Platform: Other
               URL: http://egs-soft.info/product/gunners_heart/gh_try.lzh
        OS/Version: other
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

In some games (such as Gunners Heart, Duo Princess, etc..), xfile are used to
load textures for objects in DirectX.  However, it is still unimplemented in
wine.

Here's the xfile error from Gunners Heart:

fixme:d3dxof:IDirectXFileImpl_RegisterTemplates 
(0x564e7a8/0x564e7a8)->(0x5dbe80,3278) stub!
fixme:d3dxof:IDirectXFileImpl_RegisterTemplates
(0x564e7a8/0x564e7a8)->(0x5dbe80,3278) stub!
...

You would need to disable sound to have it run, which is another bug I had
filed.

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

Ed Kolis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Ed Kolis   2008-07-12 17:23:15 ---
This same error occurs when starting a game of Space Empires V, making the game
completely unplayable beyond the game setup menus.

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

Ron Coit  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #2 from Ron Coit   2008-07-16 06:28:56 ---
*** This bug has been confirmed by popular vote. ***

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

Jeff Gringo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Jeff Gringo   2008-08-31 06:12:21 ---
Söldner Marine Corps is affected, too.

fixme:d3dxof:IDirectXFileEnumObjectImpl_GetNextDataObject
(0x11752b20/0x11752b20)->(0x32c3b0) stub!
fixme:d3dxof:IDirectXFileDataImpl_GetType (0x11752b38/0x11752b38)->(0x32c0e0)
stub!
fixme:d3dxof:IDirectXFileDataImpl_GetName
(0x11752b38/0x11752b38)->(0x32c170,0x32c0e4) stub!

this appears in an infinite loop. With native d3dxof, it works.

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

Christian Costa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Christian Costa   2008-09-01 14:58:51 ---
I'm currently working on d3dxof but it's still not usable yet.
Use native dll for now.

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #5 from Christian Costa   2008-11-22 04:17:58 ---
Builtin d3dxof is usable now. Please test and report bugs if any.

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #6 from Jeff Gringo   2008-11-22 07:47:41 ---
(In reply to comment #5)
> Builtin d3dxof is usable now. Please test and report bugs if any.

While starting soldner, following debug message appears, then the app crashes:

fixme:d3dxof:parse_template_members_list No support for multi-dimensional array
yet

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #7 from Ed Kolis   2008-11-22 08:55:44 ---
Well, I tried it in Space Empires 5, and none of the planets or stars were
visible (just the hex map was visible, and some warp points and text), and
after a few seconds of scrolling around the map, the game crashed, with the
last entries in the terminal being a zillion of them like this one:

fixme:d3d7:IDirect3DDeviceImpl_7_ComputeSphereVisibility
(0x1583d8)->(0x33fd30,0x33fd48,00000001,00000000,0x33fd3c): stub!

Dang it! I thought SE5 used DirectX 8! :P /me whines at Aaron Hall for using a
bastard mix of 7 and 8 ;)

Still, I *think* it's progress, as before, the game crashed before even
displaying anything unless I used a native d3dxof.dll ;)

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #8 from Christian Costa   2008-11-25 15:52:28 ---
WRT Soldner Marine Corps, support for multi-dimensional arrays has been
committed. Please retest.

WRT Gunner Heart, the game crashes (in dmusic ?) before any d3dxof calls.

More generally, it would be much better to enter separate bugs for different
problems and provide logs and download links if possible. I would even suggest
to close this bug since d3dxof common features are implemented.

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #9 from Wai Ling Tsang   2008-11-28 22:59:45 ---
Gunner Heart can start without problem if you disabled sound.

Objects are still will not displayed using the native implementation of dxof. 
A simpler game you can try that use xfile extensively is duopri, which can be
downloaded from:

http://egs-soft.info/product/duoprincess/duotry.lzh

Once again, you would have to disable sound since the dmusic bug still have not
be addressed.  Anyway, thanks for working on this issue.  Although the support
is not non-existent, it isn't really working either.

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #10 from Christian Costa   2008-11-29 03:56:12 ---
Created an attachment (id=17536)
 --> (http://bugs.winehq.org/attachment.cgi?id=17536)
Patch for Gunner Heart

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #11 from Christian Costa   2008-11-29 03:56:45 ---
Well, I'm not able to disable sound, I have a problem with fonts which makes
text unreadable.
Anyway I fix the dmusic crash. Patch is commited.

Indeed even in native dll, they are invisible objects. I guess it's more a d3d
bug.

Ok. I manage to get the builtin dll working with this game.
The changes will be in git in a couple of days.
If you really can't wait, here is the patch. :-)

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #12 from Wai Ling Tsang   2008-11-29 13:41:07 ---
I have applied the patch.  More objects can now be displayed (such as the
ocean), but it still wouldn't display certain objects that the native dll will
display.

For example, in duopri, the ship is invisible whereas using the native dll
(d3dxof.dll), the ship will be there.

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #13 from Christian Costa   2008-12-01 16:18:42 ---
My changes have been commited. There is some more fixes inside.

With my testing:
- Gunners is same as native for all 3 levels.
- Duopri seems ok too but haven't finished the level (A little boring for
me;-))
If you still find problem you can attach screenshot to see the difference. Any
d3dxof ouput would be also usefull.

For Soldner and SE5, you can retest them too.

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #14 from Wai Ling Tsang   2008-12-03 00:02:44 ---
I have compiled wine from GIT today, the boat is still missing.  This is the
screenshot of the beginning of duopri.  The heroine is supposed to be standing
on the dock of the boat:

http://img123.imageshack.us/img123/5358/duopribeginningrp7.png

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #15 from Christian Costa   2008-12-04 13:48:05 ---
The game starts in a forest.

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #16 from Wai Ling Tsang   2008-12-07 23:55:42 ---
Nope, the game start at the boat, then the forest.

This is the content of my duop.ini:

[setup]
winmode=0
fps=1
dispfps=0
texmode=1
mapmode=1
demomode=1

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #17 from Wai Ling Tsang   2008-12-08 00:05:53 ---
oh, my bad.  I got the full version of the game, which start at the boat.  The
trial version start in the forest.

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #18 from Wai Ling Tsang   2008-12-08 00:10:43 ---
Created an attachment (id=17740)
 --> (http://bugs.winehq.org/attachment.cgi?id=17740)
The xfile for the boat in first stage.

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #19 from Christian Costa   2008-12-09 15:15:24 ---
These objects are parsed correctly. Generated data is the same as native.
Is there any d3dxof output (w/o traces enabled) while loading the level ?

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #20 from Wai Ling Tsang   2008-12-09 18:13:24 ---
Yes, I got this fixme warning:

fixme:d3dxof:parse_object_members_list Buffer too small 0x1ff3c7 0x1ff300 14
fixme:d3dxof:parse_object_members_list Buffer too small 0x1ff3ef 0x1ff328 14

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #21 from Christian Costa   2008-12-10 13:30:51 ---
Created an attachment (id=17810)
 --> (http://bugs.winehq.org/attachment.cgi?id=17810)
Patch for Duo Princess

Does this patch fixes the problem.

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #22 from Wai Ling Tsang   2008-12-11 18:09:20 ---
Yes, your patch works.  Thank you so much.  I can see the boat now.

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #23 from Wai Ling Tsang   2008-12-14 20:20:25 ---
Actually, I have just compiled wine from GIT again, instead of using
wine-1.1.10.   The boat is visible even without the patch.  In wine-1.1.10, the
MAX_STRINGS_BUFFER value is only 200, which is not enough.

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

--- Comment #24 from Christian Costa   2008-12-15 15:20:24 ---
Cool! :-) Is there any issue remaining ?

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

Wai Ling Tsang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #25 from Wai Ling Tsang   2008-12-16 10:15:45 ---
None that I know of. :)

Let's close this bug.  Closing bug.

[Bug 13111] xfile support is still non-existant in wine

http://bugs.winehq.org/show_bug.cgi?id=13111

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #26 from Alexandre Julliard   2008-12-20 09:04:23 ---
Closing bugs fixed in 1.1.11.