[Bug 15215] New: Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

Summary: Microsoft Office 2007: Attempting to update IME
                    dictionary => crash (dogfood)
           Product: Wine
           Version: 1.1.4
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Now that Office 2007 installs without any bugs (aside from bug 15027, but
that's no big deal), I tried Word out a bit.

First dogfood bug:

Fire up Word 2007.
Click 'Review' tab.
Click 'Update IME dictionary'.

CRASH.

Working on getting a backtrace. Did so the first time, but now can't seem to
get one...hmm

=>1 0x7e565c0b ImmConfigureIMEA+0x8b(hKL=0x4090409, hWnd=0x2004a, dwMode=2,
lpData=(nil)) [/home/austin/wine-git/dlls/imm32/imm.c:523] in imm32
(0x0032daec)

Was all I got the first time. Logs coming shortly.

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

--- Comment #1 from Austin English   2008-09-09 20:33:50 ---
Created an attachment (id=15972)
 --> (http://bugs.winehq.org/attachment.cgi?id=15972)
+imm in git

Seems the +seh was blocking a backtrace...+imm & backtrace

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

--- Comment #2 from Juan Lang   2008-09-10 10:06:41 ---
Created an attachment (id=15987)
 --> (http://bugs.winehq.org/attachment.cgi?id=15987)
Patch

How odd, it seems as though the lpData is NULL even though the mode is
IME_CONFIG_REGISTERWORD, which according to MSDN implies "this
parameter[lpData] must indicate a REGISTERWORD structure".  Does this patch
help?

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #3 from Austin English   2008-09-10 13:07:39 ---
I'll test this afternoon. Thanks for the quick work!

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

--- Comment #4 from Austin English   2008-09-11 02:12:36 ---
(In reply to comment #2)
> Created an attachment (id=15987)

--> (http://bugs.winehq.org/attachment.cgi?id=15987) [details]
> Patch
>
> How odd, it seems as though the lpData is NULL even though the mode is
> IME_CONFIG_REGISTERWORD, which according to MSDN implies "this
> parameter[lpData] must indicate a REGISTERWORD structure".  Does this patch
> help?

No dice. Output looks roughly the same. Do you want another +imm trace?

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

--- Comment #5 from Juan Lang   2008-09-11 09:30:49 ---
(In reply to comment #4)
> No dice. Output looks roughly the same. Do you want another +imm trace?

Yes, I'd be interested in seeing that.  Thanks for testing!

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

--- Comment #6 from Austin English   2008-09-11 10:27:50 ---
Created an attachment (id=16017)
 --> (http://bugs.winehq.org/attachment.cgi?id=16017)
+imm, with patch applied

Here you go!

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

--- Comment #7 from Juan Lang   2008-09-11 10:34:42 ---
Hmmm.. are you sure the patch is applied?  The line that shows up as the point
of crash shouldn't be able to cause a crash, it declares a local variable which
has the same value as the passed in parameter (but it doesn't dereference it.)

If you're really sure, then there's something else magical going on, like the
stack got corrupt somehow, and the bug's really elsewhere.  That's just wild
speculation though.  Please doublecheck that you're running with the patch
applied.

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15987|0                           |1
        is obsolete|                            |

--- Comment #8 from Juan Lang   2008-09-11 10:44:11 ---
Created an attachment (id=16018)
 --> (http://bugs.winehq.org/attachment.cgi?id=16018)
Patch

Here's a more complete patch.  With this I'll be able to check that the patch
has, indeed, been applied.  Would you mind running with this and attaching a
+imm log?

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

--- Comment #9 from Austin English   2008-09-11 10:49:20 ---
(In reply to comment #8)
> Created an attachment (id=16018)

--> (http://bugs.winehq.org/attachment.cgi?id=16018) [details]
> Patch
>
> Here's a more complete patch.  With this I'll be able to check that the patch
> has, indeed, been applied.  Would you mind running with this and attaching a
> +imm log?

Patch works great. Crash is avoided, but instead get an error: 'The current IME
does not support editing the user dictionary.'

I'll open a new bug.

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |15241

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

--- Comment #10 from Juan Lang   2008-09-11 10:54:27 ---
Created an attachment (id=16020)
 --> (http://bugs.winehq.org/attachment.cgi?id=16020)
Patch

Out of curiosity, what if you use this patch instead?

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

--- Comment #11 from Austin English   2008-09-11 11:45:23 ---
(In reply to comment #10)
> Created an attachment (id=16020)

--> (http://bugs.winehq.org/attachment.cgi?id=16020) [details]
> Patch
>
> Out of curiosity, what if you use this patch instead?

Works as well.

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

--- Comment #12 from Juan Lang   2008-09-11 12:01:36 ---
Patch sent:
http://www.winehq.org/pipermail/wine-patches/2008-September/061436.html

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

--- Comment #13 from Austin English   2008-09-17 22:40:31 ---
(In reply to comment #12)
> Patch sent:
> http://www.winehq.org/pipermail/wine-patches/2008-September/061436.html

Still present in git...Mind resending your patch Juan? It wasn't accepted, and
none of the other recent imm changes have fixed this.

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

--- Comment #14 from Juan Lang   2008-09-18 13:41:52 ---
(In reply to comment #13)
> Still present in git...Mind resending your patch Juan? It wasn't accepted, and
> none of the other recent imm changes have fixed this.

That got rejected.  It needs some Windows tests to verify.  Unfortunately my
Windows box died, so I might not get to this anytime soon.

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

--- Comment #15 from Juan Lang   2008-09-27 15:29:01 ---
Aric sent an updated patch:
http://www.winehq.org/pipermail/wine-patches/2008-September/062212.html

I'll obsolete mine in a sec.

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16018|0                           |1
        is obsolete|                            |

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16020|0                           |1
        is obsolete|                            |

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #16 from Juan Lang   2008-10-02 13:46:36 ---
Aric's patch got committed.

[Bug 15215] Microsoft Office 2007: Attempting to update IME dictionary => crash (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=15215

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #17 from Alexandre Julliard   2008-10-10 10:10:53 ---
Closing bugs fixed in 1.1.6.