[Bug 36061] New: winedbg crash dialog shows a leak in imm32

https://bugs.winehq.org/show_bug.cgi?id=36061

Bug ID: 36061
           Summary: winedbg crash dialog shows a leak in imm32
           Product: Wine
           Version: 1.7.17
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]

Noticed while valgrinding various test failures:
==13839== 24 bytes in 1 blocks are definitely lost in loss record 250 of 889
==13839==    at 0x7BC4C735: notify_alloc (heap.c:255)
==13839==    by 0x7BC50F79: RtlAllocateHeap (heap.c:1716)
==13839==    by 0x7B84584B: HeapAlloc (heap.c:271)
==13839==    by 0x7B845B80: GlobalAlloc (heap.c:388)
==13839==    by 0x62CB1A6: ImmCreateIMCC (imm.c:2738)
==13839==    by 0x62C4AB7: ImmCreateContext (imm.c:697)
==13839==    by 0x62C6F93: ImmGetContext (imm.c:1422)
==13839==    by 0x62CB807: ImmProcessKey (imm.c:2891)
==13839==    by 0x538AB14: process_keyboard_message (message.c:2469)
==13839==    by 0x538B2F4: process_hardware_message (message.c:2692)
==13839==    by 0x538BFAD: peek_message (message.c:2900)
==13839==    by 0x538E12C: GetMessageW (message.c:3817)
==13839==    by 0x534ADB9: DIALOG_DoDialogBox (dialog.c:816)
==13839==    by 0x534B064: DialogBoxParamW (dialog.c:879)
==13839==    by 0x476B945: display_crash_dialog (crashdlg.c:369)
==13839==    by 0x4784337: dbg_active_auto (tgt_active.c:816)
==13839==    by 0x478A98C: main (winedbg.c:673)
==13839== 
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   match-leak-kinds: definite
   fun:notify_alloc
   fun:RtlAllocateHeap
   fun:HeapAlloc
   fun:GlobalAlloc
   fun:ImmCreateIMCC
   fun:ImmCreateContext
   fun:ImmGetContext
   fun:ImmProcessKey
   fun:process_keyboard_message
   fun:process_hardware_message
   fun:peek_message
   fun:GetMessageW
   fun:DIALOG_DoDialogBox
   fun:DialogBoxParamW
   fun:display_crash_dialog
   fun:dbg_active_auto
   fun:main
}

wine-1.7.16-178-g7e874ae

[Bug 36061] winedbg crash dialog shows a leak in imm32

https://bugs.winehq.org/show_bug.cgi?id=36061

Qian Hong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]        |[e-mail]

--- Comment #1 from Qian Hong  ---
Created attachment 48246
  --> https://bugs.winehq.org/attachment.cgi?id=48246
Patch: Fix IMC leak

Hi Austin, could you test this patch? Thanks!

[Bug 36061] winedbg crash dialog shows a leak in imm32

https://bugs.winehq.org/show_bug.cgi?id=36061

--- Comment #2 from Austin English  ---
No, still there. I'll attach a full log (from ddraw/ddrawmodes.c).

[Bug 36061] winedbg crash dialog shows a leak in imm32

https://bugs.winehq.org/show_bug.cgi?id=36061

--- Comment #3 from Austin English  ---
Created attachment 48254
  --> https://bugs.winehq.org/attachment.cgi?id=48254
valgrind log/backtrace

[Bug 36061] winedbg crash dialog shows a leak in imm32

https://bugs.winehq.org/show_bug.cgi?id=36061

--- Comment #4 from Austin English  ---
I can also reproduce it with comdlg32/tests/filedlg.c, which may be easier for
debugging:
==30451== 152 bytes in 1 blocks are definitely lost in loss record 734 of 1,115
==30451==    at 0x7BC4C735: notify_alloc (heap.c:255)
==30451==    by 0x7BC50F79: RtlAllocateHeap (heap.c:1716)
==30451==    by 0x7B84586B: HeapAlloc (heap.c:271)
==30451==    by 0x7B845BA0: GlobalAlloc (heap.c:388)
==30451==    by 0x78E11A6: ImmCreateIMCC (imm.c:2738)
==30451==    by 0x78DA9B6: ImmCreateContext (imm.c:682)
==30451==    by 0x78DCF93: ImmGetContext (imm.c:1422)
==30451==    by 0x78E1807: ImmProcessKey (imm.c:2891)
==30451==    by 0x535EB24: process_keyboard_message (message.c:2469)
==30451==    by 0x535F304: process_hardware_message (message.c:2692)
==30451==    by 0x535FFBD: peek_message (message.c:2900)
==30451==    by 0x5361E3A: PeekMessageW (message.c:3757)
==30451==    by 0x531ED24: DIALOG_DoDialogBox (dialog.c:803)
==30451==    by 0x531F0DB: DialogBoxIndirectParamAorW (dialog.c:892)
==30451==    by 0x531F133: DialogBoxIndirectParamA (dialog.c:902)
==30451==    by 0x5E0D4B0: GetFileName95 (filedlg.c:324)
==30451==    by 0x5E0D9F8: GetFileDialog95A (filedlg.c:457)
==30451==    by 0x5E17262: GetOpenFileNameA (filedlg.c:4102)
==30451==    by 0x49578FF: test_resize (filedlg.c:551)
==30451==    by 0x495A1C2: func_filedlg (filedlg.c:1247)
==30451==

[Bug 36061] winedbg crash dialog shows a leak in imm32

https://bugs.winehq.org/show_bug.cgi?id=36061

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |imm32

[Bug 36061] winedbg crash dialog shows a leak in imm32

https://bugs.winehq.org/show_bug.cgi?id=36061

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase, valgrind

[Bug 36061] winedbg crash dialog shows a leak in imm32

https://bugs.winehq.org/show_bug.cgi?id=36061

--- Comment #5 from Austin English  ---
Still in wine-1.7.51-225-g3966aff (crypt32/tests/msg.c)

[Bug 36061] winedbg crash dialog shows a leak in imm32

https://bugs.winehq.org/show_bug.cgi?id=36061

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from joaopa  ---
Does the bug still occur with wine-4.4?

[Bug 36061] winedbg crash dialog shows a leak in imm32

https://bugs.winehq.org/show_bug.cgi?id=36061

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #7 from Austin English  ---
(In reply to joaopa from comment #6)
> Does the bug still occur with wine-4.4?

No, it's been fixed.

[Bug 36061] winedbg crash dialog shows a leak in imm32

https://bugs.winehq.org/show_bug.cgi?id=36061

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  ---
Closing bugs fixed in 4.12.