https://bugs.winehq.org/show_bug.cgi?id=50436
Bug ID: 50436 Summary: Upstream FAudio pkg-config file not found Product: Wine Version: 6.0-rc4 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: build-env Assignee: wine-bugs@winehq.org Reporter: j-r@online.de Distribution: ---
FAusdio recently (November 2020) added an upstream package config file using the name FAudio.pc, while configure looks for lowercase faudio.pc.
Note that the upstream config file is AFAICT not usable for gstreamer enabled FAUdio builds. Depending on the fix for that (e.g. if gstreamer is added as an Dependency in FAudio.pc), an option filtering similar to the one used for gstreamer might become neccessary.
https://bugs.winehq.org/show_bug.cgi?id=50436
Sveinar Søpler cybermax@dexter.no changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cybermax@dexter.no
--- Comment #1 from Sveinar Søpler cybermax@dexter.no --- Sorry for being dense here, but could you elaborate what issues this is causing? (Logs maybe where FAudio.pc is not found or something like that).
You gather the pkg file should have something like: Requires: gstreamer-1.0
If so, this might be better suited for https://github.com/FNA-XNA/FAudio/issues since it would not be a wine issue i guess. (Or perhaps a distro/packaging issue?)
https://bugs.winehq.org/show_bug.cgi?id=50436
--- Comment #2 from j-r@online.de --- Created attachment 69065 --> https://bugs.winehq.org/attachment.cgi?id=69065 Shell session of configure --with-faudio
Since config.log contains mostly noise I've added a log of a shell session hopefully illustrating the problem and possible solution (i.e. upcasing the package name in configure.ac/configure).
Note that a non gstreamer enabled build of FAudio was used. The linking test in configure would still fail otherwise, because references to gstreamer could not be resolved.
https://bugs.winehq.org/show_bug.cgi?id=50436
--- Comment #3 from j-r@online.de --- (In reply to Sveinar Søpler from comment #1)
Sorry for being dense here, but could you elaborate what issues this is causing? (Logs maybe where FAudio.pc is not found or something like that).
I was reluctant to post config.log, because it doesn't directly show the pkg-config result. I think I'll open an enhancement ticket for that (spamming config.log with failed pkg-config invocations).
I hope the information I posted above shows the problem more clearly.
You gather the pkg file should have something like: Requires: gstreamer-1.0
Yes, but I don't know whether that is the correct solution. Since the FAudio user doesn't care about the backend, FAudio should perhaps handle the dynamic loading of its backend internally.
If so, this might be better suited for https://github.com/FNA-XNA/FAudio/issues since it would not be a wine issue i guess. (Or perhaps a distro/packaging issue?)
Yes. The reasons why I was mentioning this were
a) using a gstreamer enabled FAudio build will currently give an unrelated error while configuring --with-faudio using the upstream generated pkg-config file
b) if FAudio should opt for the above solution, wine will need something like the cflags filtering currently used for gstreamer (because then FAudio cflags may contain -pthread)
https://bugs.winehq.org/show_bug.cgi?id=50436
--- Comment #4 from j-r@online.de --- Created attachment 69067 --> https://bugs.winehq.org/attachment.cgi?id=69067 Trivial configure.ac patch
https://bugs.winehq.org/show_bug.cgi?id=50436
--- Comment #5 from Sveinar Søpler cybermax@dexter.no --- Hmm.. it could maybe look like a typo in configure perhaps? I would assume so, even tho configure finds the right libraries when it is installed in system folders (by other means i guess... -lFAudio flag and such).
running: pkg-config --cflags faudio produces an error for me aswell, but using pkg-config --cflags FAudio does not.
So it seems this is a bug.
Not sure what would be the correct approach when generating the .pc file - after all it is kinda up to the end-user/distro to choose build flags, and possible scripts generating this in the .pc file. One thing i am fairly certain of, is that it is not a wine issue.
The configure script is tho :)
https://bugs.winehq.org/show_bug.cgi?id=50436
--- Comment #6 from j-r@online.de --- (In reply to Sveinar Søpler from comment #5)
Hmm.. it could maybe look like a typo in configure perhaps? I would assume so, even tho configure finds the right libraries when it is installed in system folders (by other means i guess... -lFAudio flag and such).
running: pkg-config --cflags faudio produces an error for me aswell, but using pkg-config --cflags FAudio does not.
If pkg-config doesn't work, configure uses -lFAudio by default, therefore everything is fine as long as FAudio is installed in standard include and lib directories.
I think it is not a typo in configure. The upstream FAudio.pc file has only been added recently. It seems that earlier some distributions provided their own pkg-config file and it seems at least some of them used the lowercase variant.
https://bugs.winehq.org/show_bug.cgi?id=50436
Gcenx gcenx83@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gcenx83@gmail.com
--- Comment #7 from Gcenx gcenx83@gmail.com --- (In reply to j-r from comment #6)
(In reply to Sveinar Søpler from comment #5)
Hmm.. it could maybe look like a typo in configure perhaps? I would assume so, even tho configure finds the right libraries when it is installed in system folders (by other means i guess... -lFAudio flag and such).
running: pkg-config --cflags faudio produces an error for me aswell, but using pkg-config --cflags FAudio does not.
If pkg-config doesn't work, configure uses -lFAudio by default, therefore everything is fine as long as FAudio is installed in standard include and lib directories.
I think it is not a typo in configure. The upstream FAudio.pc file has only been added recently. It seems that earlier some distributions provided their own pkg-config file and it seems at least some of them used the lowercase variant.
No the type is in configure.ac it should be an upper case F not a lower case f, everything else also uses an upper case first letter.
https://bugs.winehq.org/show_bug.cgi?id=50436
--- Comment #8 from Gcenx gcenx83@gmail.com --- Dam auto correct sigh..
The typo is within configure.ac
https://bugs.winehq.org/show_bug.cgi?id=50436
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |f126809ec017570325b98abd797 | |356ceba17e15e
--- Comment #9 from Alexandre Julliard julliard@winehq.org --- It should be fixed by f126809ec017570325b98abd797356ceba17e15e.
https://bugs.winehq.org/show_bug.cgi?id=50436
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #10 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.6.
https://bugs.winehq.org/show_bug.cgi?id=50436
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |6.0.x
https://bugs.winehq.org/show_bug.cgi?id=50436
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|6.0.x |---
--- Comment #11 from Michael Stefaniuc mstefani@winehq.org --- Removing the 6.0.x milestone from bug fixes included in 6.0.2.
-
WineHQ Bugzilla