[Bug 18558] New: d3d9/visual: tests fail with fbo or +heap enabled

http://bugs.winehq.org/show_bug.cgi?id=18558

Summary: d3d9/visual: tests fail with fbo or +heap enabled
           Product: Wine
           Version: unspecified
          Platform: PC-x86-64
               URL: http://test.winehq.org/data/1394c6eee3150c2ecf588a25ee
                    d6d329adc91950/wine_ae-ub904-fbo/d3d9:visual.html
        OS/Version: Linux
            Status: NEW
          Keywords: download, testcase
          Severity: minor
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

I noticed today that d3d9:visual fails the same way with +heap or FBO enabled.
Fixing the memory corruption may also fix the FBO tests?

http://test.winehq.org/data/1394c6eee3150c2ecf588a25eed6d329adc91950/wine_ae...

visual.c:183: Driver string: "Display"
visual.c:184: Description string: "NVIDIA GeForce 9800 GT"
visual.c:185: Device name string: "\.\DISPLAY"
visual.c:186: Driver version 7.15.11.8044

The tests pass fine with backbuffer/-heap.

[Bug 18558] d3d9/visual: tests fail with fbo or +heap enabled

http://bugs.winehq.org/show_bug.cgi?id=18558

--- Comment #1 from Austin English   2009-05-28 19:04:53 ---
Created an attachment (id=21390)
 --> (http://bugs.winehq.org/attachment.cgi?id=21390)
warn+heap,+d3d9

[Bug 18558] d3d9/visual: tests fail with fbo or +heap enabled

http://bugs.winehq.org/show_bug.cgi?id=18558

--- Comment #2 from Henri Verbeet   2009-06-04 03:50:28 ---
(In reply to comment #1)
> visual.c:10225: Tests skipped: Sanity check returned an incorrect color(00ede9e3), can't assure the correctness of the tests, skipping

The warn+heap case looks rather different to me (and works here). The failures
in yuv_color_test() with FBO ORM are a known issue. I have some patches for
this that should be going in in the next couple of days.

[Bug 18558] d3d9/visual: tests fail with fbo or +heap enabled

http://bugs.winehq.org/show_bug.cgi?id=18558

--- Comment #3 from Austin English   2009-06-04 11:27:35 ---
(In reply to comment #2)
> (In reply to comment #1)
> > visual.c:10225: Tests skipped: Sanity check returned an incorrect color(00ede9e3), can't assure the correctness of the tests, skipping
>
> The warn+heap case looks rather different to me (and works here).

Hmm. Does this look any different:
http://test.winehq.org/data/1643679476c88953c6c506c152c7d25ba2219716/wine_ae...
> The failures in yuv_color_test() with FBO ORM are a known issue. I have some patches for this that should be going in in the next couple of days.

Excellent.

[Bug 18558] d3d9/visual: tests fail with fbo or +heap enabled

http://bugs.winehq.org/show_bug.cgi?id=18558

--- Comment #4 from Henri Verbeet   2009-06-04 11:39:56 ---
That looks like the FBO failures, yeah. No idea why warn+heap would cause that
though.

[Bug 18558] d3d9/visual: tests fail with fbo or +heap enabled

http://bugs.winehq.org/show_bug.cgi?id=18558

--- Comment #5 from Austin English   2009-06-04 12:35:25 ---
(In reply to comment #4)
> That looks like the FBO failures, yeah. No idea why warn+heap would cause that
> though.

Can you post the patches fixing FBO?

[Bug 18558] d3d9/visual: tests fail with fbo or +heap enabled

http://bugs.winehq.org/show_bug.cgi?id=18558

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Austin English   2009-06-05 11:36:20 ---
Fixed in today's git by Henri's FBO series.

[Bug 18558] d3d9/visual: tests fail with fbo or +heap enabled

http://bugs.winehq.org/show_bug.cgi?id=18558

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard   2009-06-05 12:46:31 ---
Closing bugs fixed in 1.1.23.