[Bug 18165] New: dlls/winhttp/net.c: assignment discards qualifies from pointer target type

http://bugs.winehq.org/show_bug.cgi?id=18165

Summary: dlls/winhttp/net.c: assignment discards qualifies from
                    pointer target type
           Product: Wine
           Version: 1.1.19
          Platform: PC
        OS/Version: NetBSD
            Status: NEW
          Keywords: patch, source
          Severity: minor
          Priority: P2
         Component: build-env
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=20629)
 --> (http://bugs.winehq.org/attachment.cgi?id=20629)
patch

gcc -c -I. -I. -I../../include -I../../include  -D__WINESRC__  -D_REENTRANT
-fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement
-Wwrite-strings -Wpointer-arith -I/usr/pkg/include -I/usr/include
-I/usr/X11R7/include/f
reetype2 -I/usr/X11R7/include -O2 -I/usr/pkg/include -I/usr/include
-I/usr/X11R7/include/freetype2 -I/usr/X11R7/include  -o net.o net.c
net.c: In function 'netconn_init':
net.c:243: warning: assignment discards qualifiers from pointer target type

attached patch fixes it.

[Bug 18165] dlls/winhttp/net.c: assignment discards qualifies from pointer target type

http://bugs.winehq.org/show_bug.cgi?id=18165

--- Comment #1 from Austin English   2009-04-23 01:50:56 ---
Also affects wininet/netconnection.c:

static SSL_METHOD *meth;
...
         meth = pSSLv23_method();

[Bug 18165] dlls/winhttp/net.c: assignment discards qualifies from pointer target type

http://bugs.winehq.org/show_bug.cgi?id=18165

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20629|0                           |1
        is obsolete|                            |

--- Comment #2 from Austin English   2009-04-23 01:51:47 ---
Created an attachment (id=20630)
 --> (http://bugs.winehq.org/attachment.cgi?id=20630)
updated patch

[Bug 18165] dlls/winhttp/net.c: assignment discards qualifies from pointer target type

http://bugs.winehq.org/show_bug.cgi?id=18165

--- Comment #3 from Austin English   2009-05-28 22:12:11 ---
Still present in git.

[Bug 18165] dlls/winhttp/net.c: assignment discards qualifies from pointer target type

http://bugs.winehq.org/show_bug.cgi?id=18165

--- Comment #4 from Juan Lang   2009-11-12 18:04:23 ---
Patch looks fine, why don't you send it in?

[Bug 18165] dlls/winhttp/net.c: assignment discards qualifies from pointer target type

http://bugs.winehq.org/show_bug.cgi?id=18165

--- Comment #5 from Austin English   2009-11-12 18:05:55 ---
(In reply to comment #4)
> Patch looks fine, why don't you send it in?

Apparently it breaks when compiling on non-NetBSD. On Karmic:
austin@midna:~/wine-git/dlls/winhttp$ make
ccache gcc -m32 -c -I. -I. -I../../include -I../../include  -D__WINESRC__ 
-D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing
-Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -Wtype-limits
-Wpointer-arith  -g -O2  -o net.o net.c
net.c: In function ‘netconn_init’:
net.c:284: warning: passing argument 1 of ‘pSSL_CTX_new’ discards qualifiers
from pointer target type
net.c:284: note: expected ‘struct SSL_METHOD *’ but argument is of type ‘const
struct SSL_METHOD *’

[Bug 18165] dlls/winhttp/net.c: assignment discards qualifies from pointer target type

http://bugs.winehq.org/show_bug.cgi?id=18165

Gilboa Davara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Gilboa Davara   2010-04-06 02:09:30 ---
The same patch seems to work here (F12/i686/0.42).

- Gilboa

[Bug 18165] dlls/winhttp/net.c: assignment discards qualifies from pointer target type

http://bugs.winehq.org/show_bug.cgi?id=18165

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Austin English   2010-08-04 01:04:37 ---
Should be fixed by
http://source.winehq.org/git/wine.git/?a=commitdiff;h=53391a344546b3e71a302a...

[Bug 18165] dlls/winhttp/net.c: assignment discards qualifies from pointer target type

http://bugs.winehq.org/show_bug.cgi?id=18165

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard   2010-08-20 12:38:52 ---
Closing bugs fixed in 1.3.1.