http://bugs.winehq.org/show_bug.cgi?id=17986
Summary: BrsFolder_OnCommand make new folder not implemented Product: Wine Version: 1.1.18 Platform: All OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: shell32 AssignedTo: wine-bugs@winehq.org ReportedBy: teach2000@basement.nl
Created an attachment (id=20354) --> (http://bugs.winehq.org/attachment.cgi?id=20354) Test project created with Delphi 2007.
The SHBrowseForFolder dialog doesn't allow creating directories.
Log: BrsFolder_OnCommand make new folder not implemented
Open attached executable. Click 'Button1'. Browse to directory in which to create new directory. Click 'Make New Folder'.
Exp.: Folder 'New Folder' is created. Act.: Nothing happens, except fixme:shell:BrsFolder_OnCommand make new folder not implemented.
http://bugs.winehq.org/show_bug.cgi?id=17986
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |trivial Platform|All |Other
http://bugs.winehq.org/show_bug.cgi?id=17986
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |FIXME Status|UNCONFIRMED |NEW CC| |kennybobs@o2.co.uk Ever Confirmed|0 |1
--- Comment #1 from Ken Sharp kennybobs@o2.co.uk 2009-05-31 18:54:38 --- Confirming.. not implemented.
http://bugs.winehq.org/show_bug.cgi?id=17986
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|FIXME |
http://bugs.winehq.org/show_bug.cgi?id=17986
Michael Mc Donnell michael@mcdonnell.dk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |michael@mcdonnell.dk
http://bugs.winehq.org/show_bug.cgi?id=17986
--- Comment #2 from Michael Mc Donnell michael@mcdonnell.dk 2009-11-28 13:24:22 --- It seems like Jonathan Armond wrote a patch that hasn't been merged yet: http://www.winehq.org/pipermail/wine-devel/2009-March/074352.html
http://bugs.winehq.org/show_bug.cgi?id=17986
Jeff Zaroyko jeffz@jeffz.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch, testcase
http://bugs.winehq.org/show_bug.cgi?id=17986
--- Comment #3 from Michael Mc Donnell michael@mcdonnell.dk 2010-07-19 10:24:26 --- Created an attachment (id=29705) --> (http://bugs.winehq.org/attachment.cgi?id=29705) Wine test case. Checks that a folder is created when the "Make New Folder" button is clicked.
I've sent this test case patch to wine-patches.
http://bugs.winehq.org/show_bug.cgi?id=17986
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh@gmail.com
--- Comment #4 from Jerome Leclanche adys.wh@gmail.com 2010-08-08 12:19:47 --- *** Bug 23943 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=17986
--- Comment #5 from Jerome Leclanche adys.wh@gmail.com 2010-08-08 12:21:30 --- What happened to the patch?
http://bugs.winehq.org/show_bug.cgi?id=17986
--- Comment #6 from Michael Mc Donnell michael@mcdonnell.dk 2010-08-08 18:38:36 --- (In reply to comment #5)
What happened to the patch?
My test case patch is in wine. I emailed Jon and he couldn't remember the exact reason why the patch was rejected, except for some stylistic issues. I have picked up his patch and I'm trying to improve it. I've tried to improve the style and I've also added editing capabilities. I will post it here soon.
http://bugs.winehq.org/show_bug.cgi?id=17986
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com
--- Comment #7 from Dan Kegel dank@kegel.com 2010-08-08 19:58:27 --- Jerome says this affects the WoW Cataclysm installer.
http://bugs.winehq.org/show_bug.cgi?id=17986
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fgouget@codeweavers.com
--- Comment #8 from Michael Stefaniuc mstefani@redhat.com 2010-08-09 04:13:16 --- *** Bug 18169 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=17986
--- Comment #9 from Michael Mc Donnell michael@mcdonnell.dk 2011-01-31 16:45:27 CST --- Created an attachment (id=33077) --> (http://bugs.winehq.org/attachment.cgi?id=33077) Implement IDD_MAKENEWFOLDER with renaming
Please apply this and see if it helps. I'll let it sit here for a while before sending it to wine-patches.
http://bugs.winehq.org/show_bug.cgi?id=17986
Michael Mc Donnell michael@mcdonnell.dk changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #33077|0 |1 is obsolete| |
--- Comment #10 from Michael Mc Donnell michael@mcdonnell.dk 2011-02-05 13:38:09 CST --- Created an attachment (id=33154) --> (http://bugs.winehq.org/attachment.cgi?id=33154) Implement IDD_MAKENEWFOLDER with renaming
Updated so that it applies to 1.3.13
http://bugs.winehq.org/show_bug.cgi?id=17986
--- Comment #11 from Michael Mc Donnell michael@mcdonnell.dk 2011-02-06 09:12:59 CST --- (In reply to comment #10)
Created an attachment (id=33154)
--> (http://bugs.winehq.org/attachment.cgi?id=33154) [details]
Implement IDD_MAKENEWFOLDER with renaming
Updated so that it applies to 1.3.13
Unfortunately this patch still has some bugs. If the test is modified so pidlRoot and the callback is set to NULL and a folder is created manually by clicking the make new folder button, then an extra tree item called "New Folder" is inserted. It is only a graphical glitch though and it does not create an extra folder. I will see if I can write a test to reproduce this consistently.
The patch does also not implement sorting, but I have found out how to do this and will upload a new patch with it fixed.
http://bugs.winehq.org/show_bug.cgi?id=17986
Michael Mc Donnell michael@mcdonnell.dk changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #29705|0 |1 is obsolete| |
--- Comment #12 from Michael Mc Donnell michael@mcdonnell.dk 2011-02-06 09:14:25 CST --- (From update of attachment 29705) This patch is obsolete as it has been included in wine.
http://bugs.winehq.org/show_bug.cgi?id=17986
Michael Mc Donnell michael@mcdonnell.dk changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #33154|0 |1 is obsolete| |
--- Comment #13 from Michael Mc Donnell michael@mcdonnell.dk 2011-02-20 10:09:41 CST --- Created an attachment (id=33370) --> (http://bugs.winehq.org/attachment.cgi?id=33370) Patch to implement IDD_MAKENEWFOLDER with renaming
This updated patch fixes the previously described issues.
http://bugs.winehq.org/show_bug.cgi?id=17986
--- Comment #14 from Michael Mc Donnell michael@mcdonnell.dk 2011-02-20 10:11:31 CST --- Created an attachment (id=33371) --> (http://bugs.winehq.org/attachment.cgi?id=33371) Patch for showing error message box during rename
http://bugs.winehq.org/show_bug.cgi?id=17986
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |nerv@dawncrow.de Resolution| |FIXED
--- Comment #15 from André H. nerv@dawncrow.de 2011-07-04 14:55:03 CDT --- fixed in todays git
http://bugs.winehq.org/show_bug.cgi?id=17986
--- Comment #16 from Jerome Leclanche adys.wh@gmail.com 2011-07-05 01:41:02 CDT --- Those would be commits: 74c47d0a6709386ea8d28566c5d91fae4d4373e8 f984d4d7f98861a2dab3d5aa4f820068b84ce2b8
http://bugs.winehq.org/show_bug.cgi?id=17986
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #17 from Alexandre Julliard julliard@winehq.org 2011-07-08 13:48:08 CDT --- Closing bugs fixed in 1.3.24.
https://bugs.winehq.org/show_bug.cgi?id=17986
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |74c47d0a6709386ea8d28566c5d | |91fae4d4373e8
-
wine-bugs＠winehq.org